Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027226
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2014-07-29 12:072014-08-11 09:44
ReportercaristuView Statuspublic 
Assigned Toshankarb 
PriorityhighResolutionfixedFixed in Version3.0PR14Q4
StatusclosedFix in branchFixed in SCM revisionbe933e11432c
ProjectionnoneETAnoneTarget Version3.0PR14Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027226: Possible undefined value should be controlled in OBPlainToOBMasked method

DescriptionThe OBPlainToOBMasked method in ob-utilities-number.js file receives several parameters. One of them is groupInterval and in some parts of the application this method is called without defining this parameter. For example in the blur function of the OBNumberItem class, this parameter is not defined.

If this value is not defined a javascript error is raised when the execution arrives to the following point of the OBPlainToOBMasked method:

if (groupCounter.toString() === groupInterval.toString() && k !== 1) {

It should be checked if the groupInterval is null or undefined before this point.
Steps To Reproduce1) Create a new numeric base reference
2) Create a column and field in a window that uses the previous reference
3) Try to save a record that contains that field
Proposed SolutionAdd a check in the OBPlainToOBMasked method like this:

  if (groupInterval === null || groupInterval === undefined) {
    groupInterval = OB.Format.defaultGroupingSize;
  }
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0068991)
hgbot (developer)
2014-07-31 06:09

Repository: erp/devel/pi
Changeset: be933e11432ce4785c2bea4ee38281f67d6f2c5e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jul 30 11:58:04 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/be933e11432ce4785c2bea4ee38281f67d6f2c5e [^]

Fixes issue 27226: Possible undefined value should be controlled in OBPlainToOBMasked method

When grouping interval is undefined, use the default grouping interval.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities-number.js
---
(0069248)
hudsonbot (developer)
2014-08-08 18:54

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test
(0069286)
alostale (manager)
2014-08-11 09:44

code reviewed + tested

- Issue History
Date Modified Username Field Change
2014-07-29 12:07 caristu New Issue
2014-07-29 12:07 caristu Assigned To => AugustoMauch
2014-07-29 12:07 caristu Modules => Core
2014-07-29 12:07 caristu Resolution time => 1409263200
2014-07-29 12:07 caristu Triggers an Emergency Pack => No
2014-07-29 12:08 caristu Proposed Solution updated
2014-07-29 12:08 caristu Issue Monitored: networkb
2014-07-30 06:32 shankarb Assigned To AugustoMauch => shankarb
2014-07-30 08:32 shankarb Status new => scheduled
2014-07-30 08:32 shankarb fix_in_branch => pi
2014-07-31 06:05 shankarb Review Assigned To => alostale
2014-07-31 06:05 shankarb fix_in_branch pi =>
2014-07-31 06:09 hgbot Checkin
2014-07-31 06:09 hgbot Note Added: 0068991
2014-07-31 06:09 hgbot Status scheduled => resolved
2014-07-31 06:09 hgbot Resolution open => fixed
2014-07-31 06:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/be933e11432ce4785c2bea4ee38281f67d6f2c5e [^]
2014-08-08 18:54 hudsonbot Checkin
2014-08-08 18:54 hudsonbot Note Added: 0069248
2014-08-11 09:44 alostale Note Added: 0069286
2014-08-11 09:44 alostale Status resolved => closed
2014-08-11 09:44 alostale Fixed in Version => 3.0PR14Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker