Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027225
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2014-07-29 08:372014-11-16 22:01
ReportermtaalView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR15Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027225: ProcessCashClose: Infinite loop/stackoverflow when there are reconcilliations in draft mode

DescriptionWhen there are reconcilliations in draft mode the process cash close (ProcessCashClose class) reports an error. The way this is done results in an infinite loop as one jsonobject (the jsonresponse in the code) is set in itself resulting in an infinite loop when doing to String.

See the stack trace in the steps to reproduce.

Note that it seems that the admin mode is not handled correctly in this case either.

The attached diff solves the stackoverflow but not the admin mode topic
Steps To Reproduce- Create manually a reconcilliations for a pos payment method for one of the pos terminals
- in that terminal create a ticket and do a cashup

You will get the following stack trace:
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
        at org.codehaus.jettison.json.JSONObject.toString(JSONObject.java:1038)
        at org.codehaus.jettison.json.JSONObject.valueToString(JSONObject.java:1159)
fff0bb6f 2014-07-29 02:34:32,797 [ajp-8809-5] WARN org.openbravo.dal.core.OBContext - Unbalanced calls to setAdminMode and restorePreviousMode. Consider setting the constant OBContext.ADMIN_TRACE_SIZE to a value higher than 0 to debug this situation
TagsNo tags attached.
Attached Filespatch file icon 27225.patch [^] (1,111 bytes) 2014-07-29 08:40 [Show Content]
diff file icon issue-27225-retailq2.2.diff [^] (1,308 bytes) 2014-07-29 08:57 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0026942 closedmarvintm Cash up process doesn't work correctly in case a reconciliation in draft status exists in the system 
related to defect 0027394 closedmarvintm Cash up process doesn't work correctly in case a reconciliation in draft status exists in the system 

-  Notes
(0068946)
mtaal (manager)
2014-07-29 08:58

The second diff is patching on 2014 q2.2 release.
(0071673)
mtaal (manager)
2014-11-16 22:00

.
(0071674)
mtaal (manager)
2014-11-16 22:01

Patch works fine at Grape customer for months now
(0071675)
mtaal (manager)
2014-11-16 22:01

Patch works fine at Grape customer for months now

- Issue History
Date Modified Username Field Change
2014-07-29 08:37 mtaal New Issue
2014-07-29 08:37 mtaal Assigned To => marvintm
2014-07-29 08:37 mtaal Triggers an Emergency Pack => No
2014-07-29 08:40 mtaal File Added: 27225.patch
2014-07-29 08:57 mtaal File Added: issue-27225-retailq2.2.diff
2014-07-29 08:58 mtaal Note Added: 0068946
2014-08-29 15:01 mtaal Relationship added related to 0026942
2014-08-29 15:02 mtaal Relationship added related to 0027394
2014-11-11 18:00 mtaal Target Version RR14Q3 => RR15Q1
2014-11-16 22:00 mtaal Status new => scheduled
2014-11-16 22:00 mtaal Note Added: 0071673
2014-11-16 22:00 mtaal fix_in_branch => pi
2014-11-16 22:01 mtaal Note Added: 0071674
2014-11-16 22:01 mtaal Status scheduled => resolved
2014-11-16 22:01 mtaal Resolution open => fixed
2014-11-16 22:01 mtaal Review Assigned To => mtaal
2014-11-16 22:01 mtaal Note Added: 0071675
2014-11-16 22:01 mtaal Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker