Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0027059 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2014-07-14 10:43 | 2014-08-18 01:21 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | marvintm | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 6838f8d66702 | ||||
| Projection | none | ETA | none | Target Version | RR14Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | mtaal | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0027059: Discounts processing will be delayed for a bit of time to improve performance | |||||||
| Description | Currently, if the user executes multiple actions very quickly, it is possible that there is several redundant promotion calculations running at the same time. A timeout should be added to ensure that the discounts are computed only once. | |||||||
| Steps To Reproduce | - Add several (>10) units of the same product, one by one. - Notice that the discounts are being launched for each unit. This is not needed, a single execution could be launched when the user has stopped adding units. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0068608) hgbot (developer) 2014-07-14 10:43 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: aa2b0dfb8f1de9e462285ce52b9fcc36747d58ff Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Jul 14 10:43:13 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa2b0dfb8f1de9e462285ce52b9fcc36747d58ff [^] Fixed issue 27059. Discounts will only be launched once when appropriate. --- M web/org.openbravo.retail.posterminal/js/model/discounts.js --- |
|
(0068614) hgbot (developer) 2014-07-14 12:14 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ea41ceef1f8643e3dd5afa8366c6725f24060e33 Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Jul 14 12:14:15 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ea41ceef1f8643e3dd5afa8366c6725f24060e33 [^] Related to issue 27059. Now the call to the right function will be made --- M web/org.openbravo.retail.posterminal/js/model/discounts.js --- |
|
(0068618) hgbot (developer) 2014-07-14 13:31 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 1284f048299cc067f908c85702300887fff6f6cc Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Mon Jul 14 13:31:15 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1284f048299cc067f908c85702300887fff6f6cc [^] Related to issue 27059: pay button deactivates while 'thinking' --- M web/org.openbravo.retail.posterminal/js/model/discounts.js --- |
|
(0068625) adrianromero (manager) 2014-07-14 16:54 |
Reviewed |
|
(0068629) hgbot (developer) 2014-07-14 19:32 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 185e40f2536e48aa01beb7b38f47e1e960a6488d Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Mon Jul 14 19:32:09 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/185e40f2536e48aa01beb7b38f47e1e960a6488d [^] Related to issue 27059: a zero timeout also do the trick as it sorts the heap --- M web/org.openbravo.retail.posterminal/js/model/discounts.js --- |
|
(0068631) Orekaria (administrator) 2014-07-15 09:58 edited on: 2014-07-15 10:41 |
Tests fail if a timeout of 300. Fine tuning required. |
|
(0069051) hgbot (developer) 2014-08-02 04:41 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6838f8d667028895c51de944625a5240d3cddeb4 Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Sat Aug 02 04:41:29 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6838f8d667028895c51de944625a5240d3cddeb4 [^] Fixes issue 27059: all the discounts algorithm's computations are stopped (killed) if they have to start over This way, only the last computation (and the valid one) is performed if several requests are done within a short period of time (e.g. when the user adds several products fast) --- M web/org.openbravo.retail.posterminal/js/model/discounts.js M web/org.openbravo.retail.posterminal/js/model/executor.js --- |
|
(0069100) hgbot (developer) 2014-08-06 14:44 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: cc8bb4fbae14330df64b61bf841fc035685fd6fe Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Wed Aug 06 14:44:42 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cc8bb4fbae14330df64b61bf841fc035685fd6fe [^] Related to issue 27059: refactoring for easier maintenance --- M web/org.openbravo.retail.posterminal/js/model/executor.js --- |
|
(0069442) mtaal (manager) 2014-08-18 01:21 |
Reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-07-14 10:43 | marvintm | New Issue | |
| 2014-07-14 10:43 | marvintm | Assigned To | => marvintm |
| 2014-07-14 10:43 | marvintm | Triggers an Emergency Pack | => No |
| 2014-07-14 10:43 | hgbot | Checkin | |
| 2014-07-14 10:43 | hgbot | Note Added: 0068608 | |
| 2014-07-14 10:43 | hgbot | Status | new => resolved |
| 2014-07-14 10:43 | hgbot | Resolution | open => fixed |
| 2014-07-14 10:43 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa2b0dfb8f1de9e462285ce52b9fcc36747d58ff [^] |
| 2014-07-14 12:14 | hgbot | Checkin | |
| 2014-07-14 12:14 | hgbot | Note Added: 0068614 | |
| 2014-07-14 12:30 | Orekaria | Relationship added | related to 0026894 |
| 2014-07-14 13:31 | hgbot | Checkin | |
| 2014-07-14 13:31 | hgbot | Note Added: 0068618 | |
| 2014-07-14 16:54 | adrianromero | Review Assigned To | => adrianromero |
| 2014-07-14 16:54 | adrianromero | Note Added: 0068625 | |
| 2014-07-14 16:54 | adrianromero | Status | resolved => closed |
| 2014-07-14 16:54 | adrianromero | Fixed in Version | => RR14Q4 |
| 2014-07-14 19:32 | hgbot | Checkin | |
| 2014-07-14 19:32 | hgbot | Note Added: 0068629 | |
| 2014-07-15 09:58 | Orekaria | Note Added: 0068631 | |
| 2014-07-15 09:58 | Orekaria | Status | closed => new |
| 2014-07-15 09:58 | Orekaria | Resolution | fixed => open |
| 2014-07-15 09:58 | Orekaria | Fixed in Version | RR14Q4 => |
| 2014-07-15 10:41 | Orekaria | Note Edited: 0068631 | View Revisions |
| 2014-07-25 10:21 | Orekaria | Relationship added | related to 0027192 |
| 2014-08-01 20:35 | Orekaria | Relationship replaced | depends on 0026894 |
| 2014-08-02 04:41 | hgbot | Checkin | |
| 2014-08-02 04:41 | hgbot | Note Added: 0069051 | |
| 2014-08-02 04:41 | hgbot | Status | new => resolved |
| 2014-08-02 04:41 | hgbot | Resolution | open => fixed |
| 2014-08-02 04:41 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aa2b0dfb8f1de9e462285ce52b9fcc36747d58ff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6838f8d667028895c51de944625a5240d3cddeb4 [^] |
| 2014-08-06 14:44 | hgbot | Checkin | |
| 2014-08-06 14:44 | hgbot | Note Added: 0069100 | |
| 2014-08-18 01:21 | mtaal | Note Added: 0069442 | |
| 2014-08-18 01:21 | mtaal | Status | resolved => closed |
| 2014-08-18 01:21 | mtaal | Review Assigned To | adrianromero => mtaal |
| 2014-08-18 01:21 | mtaal | Target Version | => RR14Q4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |