Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027027
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Warehouse Pickingmajorhave not tried2014-07-07 17:212015-02-24 16:59
ReporteralostaleView Statuspublic 
Assigned Toeduardo_Argal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision9f0cfcd2d5fd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Regression introduced in release
Summary

0027027: Generate Picking List process doesn't scale

DescriptionGenerate Picking List process doesn't scale when the number of order lines increases.

Times taken regarding number of order lines:

-100 lines: 45s
-200 lines: 115s
-400 lines: 320s
-800 lines: 20min
Steps To Reproduce-Install org.openbravo.warehouse.pickinglist
-Create a Sales Order with 800 lines
-Execute Generate Picking List Process -> It takes ~20min to complete
Proposed SolutionThe problem has 2 root causes:
-All DAL objects are stored session and it is never cleared, in addition to mentioned issue, this causes OOM error with orders having some Ks of lines
-Number of flushes. Flushes performed by this process need also to be reviewed, testing with 100 lines flush takes ~50% of the time. Note the bigger the number of in session objects is, the slower the flush is, that's why resolving 1st point flush time will also decrease.
TagsPerformance
Attached Filesdiff file icon issue-27027.diff [^] (1,878 bytes) 2014-07-07 17:30 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on defect 0027160 closededuardo_Argal Openbravo ERP C_Order_Post poor performance 

-  Notes
(0069792)
hgbot (developer)
2014-08-27 11:06

Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 9f0cfcd2d5fde2b9579a0388fa3c7ae05031aeb4
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Aug 27 11:06:31 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/9f0cfcd2d5fde2b9579a0388fa3c7ae05031aeb4 [^]

Fixed issue 27027: Using scroll to iterate though orderlines [performance]

---
M src/org/openbravo/warehouse/pickinglist/SelectOrdersHandler.java
---
(0069809)
hgbot (developer)
2014-08-27 15:48

Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 8b41fca094652c8b9eba8aa1e92ed034c7c678fa
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Aug 27 15:48:06 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/8b41fca094652c8b9eba8aa1e92ed034c7c678fa [^]

related to issue 27027: Avoid warning when order is saved after clear

---
M src/org/openbravo/warehouse/pickinglist/SelectOrdersHandler.java
---
(0070307)
dmitry_mezentsev (developer)
2014-09-24 10:55

Guys!
Not closed for 28 days now!!!
(0070920)
vmromanos (manager)
2014-10-14 12:51

Code review OK
(0070932)
dmitry_mezentsev (developer)
2014-10-14 15:49

The increase in the performance is not enough
https://docs.google.com/a/openbravo.com/spreadsheets/d/1ND7_6xSY9Kn8CkWj530LpqY8IMlAiytEZWlZvgQrQnM/edit#gid=0 [^]
(0074856)
Sandrahuguet (developer)
2015-02-24 16:53

Generate a PickList

Previously

Generate a PickList of 800 lines -> 20 minutes

After the changes

Genearte a PickList of 1000 lines -> 4 minutes
Genearte a PickList of 10000 lines -> 1 hour 30 mins
(0074858)
Sandrahuguet (developer)
2015-02-24 16:59

Fixed in issue 27160, C_Order_Post poor performance

https://code.openbravo.com/erp/devel/pi/rev/7091c40b9be09114b26b6cefeb45bc30c2650bf3 [^]

- Issue History
Date Modified Username Field Change
2014-07-07 17:21 alostale New Issue
2014-07-07 17:21 alostale Assigned To => eduardo_Argal
2014-07-07 17:23 alostale Tag Attached: Performance
2014-07-07 17:30 alostale File Added: issue-27027.diff
2014-07-10 08:16 jpcalvente Issue Monitored: jpcalvente
2014-07-21 16:35 jonalegriaesarte Resolution time => 1407362400
2014-07-23 10:57 mtaal Issue Monitored: mtaal
2014-08-26 13:23 ngarcia Category Picking and Packaging => Warehouse Picking
2014-08-27 11:06 hgbot Checkin
2014-08-27 11:06 hgbot Note Added: 0069792
2014-08-27 11:06 hgbot Status new => resolved
2014-08-27 11:06 hgbot Resolution open => fixed
2014-08-27 11:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/9f0cfcd2d5fde2b9579a0388fa3c7ae05031aeb4 [^]
2014-08-27 15:48 hgbot Checkin
2014-08-27 15:48 hgbot Note Added: 0069809
2014-09-24 10:55 dmitry_mezentsev Note Added: 0070307
2014-10-14 12:51 vmromanos Review Assigned To => vmromanos
2014-10-14 12:51 vmromanos Note Added: 0070920
2014-10-14 12:51 vmromanos Status resolved => closed
2014-10-14 15:49 dmitry_mezentsev Assigned To eduardo_Argal => vmromanos
2014-10-14 15:49 dmitry_mezentsev Note Added: 0070932
2014-10-14 15:49 dmitry_mezentsev Status closed => new
2014-10-14 15:49 dmitry_mezentsev Resolution fixed => open
2014-11-04 12:31 Sandrahuguet Assigned To vmromanos => eduardo_Argal
2015-02-24 16:52 Sandrahuguet Relationship added depends on 0027160
2015-02-24 16:53 Sandrahuguet Note Added: 0074856
2015-02-24 16:59 Sandrahuguet Review Assigned To vmromanos => Sandrahuguet
2015-02-24 16:59 Sandrahuguet Note Added: 0074858
2015-02-24 16:59 Sandrahuguet Status new => closed
2015-02-24 16:59 Sandrahuguet Resolution open => fixed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker