0026978: Define Buy X and get Y as gift and verify that it does not work fine in the ERP

diff -r ff64aefab4b0 -r 3f4fe62ff078 src-db/database/model/functions/OBDISC_XY_GIFT.xml
--- a/src-db/database/model/functions/OBDISC_XY_GIFT.xml	Tue Jun 10 19:19:42 2014 +0200
+++ b/src-db/database/model/functions/OBDISC_XY_GIFT.xml	Wed Jul 02 04:17:25 2014 -0300
@@ -33,6 +33,12 @@
   v_y NUMBER;
   v_chunks NUMBER;
   v_gift_chunks NUMBER;
+  v_total_chunks NUMBER;
+  v_total_gift_chunks NUMBER;
+  v_total_qtyordered NUMBER;
+  v_total_qtyordered_gift NUMBER;
+  v_total_x NUMBER;
+  v_total_y NUMBER;
   v_product VARCHAR(32);
   v_totalAmt NUMBER;
   v_promotionAmt NUMBER;
@@ -89,13 +95,14 @@
 		 select min(floor(ol.qtyordered / coalesce(op.em_obdisc_qty, 1)))
 			 into v_chunks
 			 from c_orderline ol, m_offer_product op
-			where c_order_id = v_docId
+			where ol.c_order_id = v_docId
 				and op.m_product_id = ol.m_product_id
 				and op.m_offer_id = p_rule_id;		
 
 	        if (coalesce(v_chunks, 0) = 0 OR v_gift_chunks < v_chunks) then
 	          v_chunks := v_gift_chunks;
-	        end if; 
+	        end if;
+	         
   else
 		select gross_unit_price, c_tax_id, qtyinvoiced,
 					 c_invoice_id, m_product_id, line_gross_amount, priceactual, linenetamt
@@ -263,8 +270,33 @@
        v_totalPromotion := v_netAmt - v_newNetAmt;
      end if;
    end if;
-
-   M_PROMOTION_ADD(p_type, p_line_id, p_rule_id, p_taxIncluded, v_newUnitPrice, v_newGrossAmt, v_newNetPrice, v_newNetAmt, v_totalPromotion, v_displayedPromotion, v_basePrice, p_user_id);
+   
+	-- Check if we already created all the promotions for this order
+	if (p_type ='O') then
+		select count(*)
+		into v_total_x
+		from c_orderline_offer offe
+		inner join c_orderline ol on ol.c_orderline_id=offe.c_orderline_id
+		where offe.m_offer_id = p_rule_id
+		and ol.m_product_id = v_product
+		and ol.c_order_id=v_docId;
+	else
+		select count(*)
+		into v_total_x
+		from c_invoiceline_offer offe
+		inner join c_invoiceline ol on ol.c_invoiceline_id=offe.c_invoiceline_id
+		where offe.m_offer_id = p_rule_id
+		and ol.m_product_id = v_product
+		and ol.c_invoice_id=v_docId;
+	end if;
+	
+	--RAISE NO_DATA_FOUND||v_total_gift_chunks;
+	if v_total_x < v_chunks then
+	  M_PROMOTION_ADD(p_type, p_line_id, p_rule_id, p_taxIncluded, v_newUnitPrice, v_newGrossAmt, v_newNetPrice, v_newNetAmt, v_totalPromotion, v_displayedPromotion, v_basePrice, p_user_id);
+	  
+	end if;
+				
+   
 		 
    return 'N';
 END OBDISC_XY_GIFT