Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0026847
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2014-06-11 18:292014-06-19 22:31
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR14Q3
StatusclosedFix in branchFixed in SCM revision1909dd43a825
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026847: Remove inactive sessions earlier

DescriptionCurrently inactive sessions (those who do not do active logout) are technically detected by not receiving anymore 'check for alerts' requests.

However they are only removed (deactivated in ad_session) only when max number of concurrent users is reached.

We should check and probably do this earlier:
Options:
1.) on tomcat restart (Expire all session which last ping before threshold)
2.) maybe on every login (will make login a bit slower, maybe ok on normal login, but could be probably on login check inside webservices)
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00268463.0PR14Q3 closedalostale Code running on tomcat start to search in remote tomcats is not needed anymore and can't work with Load Balanced Tomcats 

-  Notes
(0068124)
alostale (manager)
2014-06-18 14:43

 Selected option 1, which is the most similar to the behavior previous to fix of 0026846 and doesn't affect login performance.

Tested in oracle and postgresql. Query used to detect active sessions correctly scales as it uses index, tested in an instance with ~600K existent sessions it takes ~10ms to execute.
(0068127)
hgbot (developer)
2014-06-18 14:44

 Repository: erp/devel/pi
Changeset: 1909dd43a825cc38fa6ffbca4307c069a13a2539
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jun 18 14:32:02 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1909dd43a825cc38fa6ffbca4307c069a13a2539 [^]

fixed issue 26847: remove inactive sessions earlier

  inactive sessions are removed on tomcat start

---
M src/org/openbravo/erpCommon/security/SessionListener.java
M src/org/openbravo/erpCommon/security/SessionLogin_data.xsql
---
(0068149)
shankarb (reporter)
2014-06-19 09:21

 Code reviewed and verified in pi changeset 31caeb8872f0.
(0068189)
hudsonbot (developer)
2014-06-19 22:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1e0221328796 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-06-11 18:29 shuehner New Issue
2014-06-11 18:29 shuehner Assigned To => AugustoMauch
2014-06-11 18:29 shuehner Modules => Core
2014-06-11 18:29 shuehner Triggers an Emergency Pack => No
2014-06-11 18:29 shuehner Relationship added related to 0026846
2014-06-18 14:29 alostale Review Assigned To => shankarb
2014-06-18 14:29 alostale Assigned To AugustoMauch => alostale
2014-06-18 14:43 alostale Note Added: 0068124
2014-06-18 14:44 hgbot Checkin
2014-06-18 14:44 hgbot Note Added: 0068127
2014-06-18 14:44 hgbot Status new => resolved
2014-06-18 14:44 hgbot Resolution open => fixed
2014-06-18 14:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1909dd43a825cc38fa6ffbca4307c069a13a2539 [^]
2014-06-19 09:21 shankarb Note Added: 0068149
2014-06-19 09:21 shankarb Status resolved => closed
2014-06-19 09:21 shankarb Fixed in Version => PR14Q3
2014-06-19 22:31 hudsonbot Checkin
2014-06-19 22:31 hudsonbot Note Added: 0068189

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker