Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0026818 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2014-06-09 18:24 | 2014-09-02 09:29 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR14Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 09161e698613 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR14Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0026818: new fk-batching code in dbsm behaves wrong when having at least 1 fk which cannot be enabled (on postgresql) | |||||||
| Description | This bug is known to happen on postgresql. Unknown if it also applies to oracle. Some time ago code for dropping + re-enabling foreign keys inside update.database was changed to use jdbc-batching (to improve performance). That code contains fallback to non-batching in case of any fk failing to enable (because of non-conforming data). Idea was -> fast with batching if all fk's are fine fall back to be slow if now (slow not so important as should not happen frequently in practice). Now it is noticed that the fallback is not working properly. If you have a fk failing to enable in postgres then update.db does show error message about a different fk which is completely unrelated to user. That is happening frequently in CI (every 1-2 weeks at least) + also at least in one client. AMO has a patch in progress which should fix it but this needs more work. | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0069114) hgbot (developer) 2014-08-07 15:20 |
Repository: erp/devel/pi Changeset: 09161e69861377accfb61ef9afdbfb912115c3c2 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Aug 07 15:19:21 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/09161e69861377accfb61ef9afdbfb912115c3c2 [^] Fixes issue 26818: Handles properly a failure when applying a batch Changes done for PostgreSQL: - The Connection will not autocommit when evaluating a batch - If a batch fails, the connection does a rollback, sets the autoCommit to true, and evaluates the sql commands in a non-batched connection. Changes dsone for Oracle: - If a batch fails, the sql commands of the batch that have not been executed yet will be executed in a non-batched connection --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0069115) hgbot (developer) 2014-08-07 15:20 |
Repository: erp/devel/pi Changeset: 09161e69861377accfb61ef9afdbfb912115c3c2 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Aug 07 15:19:21 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/09161e69861377accfb61ef9afdbfb912115c3c2 [^] Fixes issue 26818: Handles properly a failure when applying a batch Changes done for PostgreSQL: - The Connection will not autocommit when evaluating a batch - If a batch fails, the connection does a rollback, sets the autoCommit to true, and evaluates the sql commands in a non-batched connection. Changes dsone for Oracle: - If a batch fails, the sql commands of the batch that have not been executed yet will be executed in a non-batched connection --- M src-db/database/lib/dbsourcemanager.jar --- |
|
(0069269) hudsonbot (developer) 2014-08-08 18:54 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-06-09 18:24 | shuehner | New Issue | |
| 2014-06-09 18:24 | shuehner | Assigned To | => AugustoMauch |
| 2014-06-09 18:24 | shuehner | Modules | => Core |
| 2014-06-09 18:24 | shuehner | Triggers an Emergency Pack | => No |
| 2014-06-20 14:49 | alostale | Target Version | PR14Q3 => PR14Q4 |
| 2014-07-24 12:30 | jonalegriaesarte | Resolution time | => 1407967200 |
| 2014-08-07 15:19 | AugustoMauch | Issue Monitored: marvintm | |
| 2014-08-07 15:20 | AugustoMauch | Review Assigned To | => marvintm |
| 2014-08-07 15:20 | hgbot | Checkin | |
| 2014-08-07 15:20 | hgbot | Note Added: 0069114 | |
| 2014-08-07 15:20 | hgbot | Checkin | |
| 2014-08-07 15:20 | hgbot | Note Added: 0069115 | |
| 2014-08-07 15:20 | hgbot | Status | new => resolved |
| 2014-08-07 15:20 | hgbot | Resolution | open => fixed |
| 2014-08-07 15:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/09161e69861377accfb61ef9afdbfb912115c3c2 [^] |
| 2014-08-07 15:20 | hgbot | Status | new => resolved |
| 2014-08-08 18:54 | hudsonbot | Checkin | |
| 2014-08-08 18:54 | hudsonbot | Note Added: 0069269 | |
| 2014-09-02 09:29 | marvintm | Status | resolved => closed |
| 2014-09-02 09:29 | marvintm | Fixed in Version | => 3.0PR14Q4 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |