Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0026635
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2014-05-20 16:222015-03-17 09:47
ReporterguillermogilView Statuspublic 
Assigned Todbaz 
PrioritynormalResolutionfixedFixed in Version3.0PR14Q4
StatusclosedFix in branchFixed in SCM revision7ad630b1df1f
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026635: Canvas field design is broken on edition

DescriptionSee the attached screenshot.

The width is not correct on editing a record on grid view.
On pick and Execute windows the canvas fields seems to be duplicated when the record gets selected.

Steps To ReproduceTo reproduce:
- open sales invoice window
- select a completed sales invoice
- click the pick example 3 button
- select a record

To get the pick example 3 button you have to install the application.example module.
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2014-05-20 16:00:22.png [^] (23,128 bytes) 2014-05-20 16:22


diff file icon patch.diff [^] (5,637 bytes) 2014-07-28 13:47 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0068703)
dbaz (developer)
2014-07-17 15:23

This column is not showed anymore following the steps to reproduce.

Is there any other place/flow where the issue can be reproduces?
(0068920)
guillermogil (developer)
2014-07-28 13:48

Hi, apply the attached patch to the examples module to have an example of the button.
Regards.
(0068966)
hgbot (developer)
2014-07-30 01:38

Repository: erp/devel/pi
Changeset: 7ad630b1df1f129b00f4cf29ee3ce7bb716e5707
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Jul 30 01:37:56 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7ad630b1df1f129b00f4cf29ee3ce7bb716e5707 [^]

Related to issue 27083, Related to issue 27085, Related to issue 26635:
* Now clientClass OBGridFromButton used as editorType doesn't span the row width
* 'isShownInGridEdit' now it works ok in grid view (pick and execute grids still pending)
* 'canEdit' can be overwritten by specifying it in the clientClass widget

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-canvas.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0068967)
dbaz (developer)
2014-07-30 01:45

A changeset has been added to, in the wrong case that a new button is shown in top of the previous one, its width be the proper one.

Anyway, there are two things wrong with the current samplecode
* Ensure that the column having the button is in 'Read Only' mode to avoid the new button in the top of the previous one.
* Optional: add the attribute 'isShownInGridEdit: true' to the button definition to ensure that it always is going to be shown in the row. I said optional because this property it is not completly well implemented in the pick and execute grids, so is possible that the button be shown even without it.
(0069237)
hudsonbot (developer)
2014-08-08 18:54

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test
(0075680)
AugustoMauch (manager)
2015-03-17 09:47

Code reviewed and verified in pi@7ad630b1df1f

- Issue History
Date Modified Username Field Change
2014-05-20 16:22 guillermogil New Issue
2014-05-20 16:22 guillermogil Assigned To => dbaz
2014-05-20 16:22 guillermogil File Added: Screenshot from 2014-05-20 16:00:22.png
2014-05-20 16:22 guillermogil Web browser => Google Chrome
2014-05-20 16:22 guillermogil Modules => Core
2014-05-20 16:22 guillermogil Triggers an Emergency Pack => No
2014-05-20 16:23 guillermogil Web browser Google Chrome => Google Chrome
2014-05-20 16:23 guillermogil Description Updated View Revisions
2014-07-17 15:23 dbaz Note Added: 0068703
2014-07-17 15:23 dbaz Status new => feedback
2014-07-28 13:47 guillermogil File Added: patch.diff
2014-07-28 13:48 guillermogil Note Added: 0068920
2014-07-30 01:38 hgbot Checkin
2014-07-30 01:38 hgbot Note Added: 0068966
2014-07-30 01:45 dbaz Note Added: 0068967
2014-08-08 18:54 hudsonbot Checkin
2014-08-08 18:54 hudsonbot Note Added: 0069237
2015-03-04 13:24 dbaz Review Assigned To => AugustoMauch
2015-03-04 13:24 dbaz Web browser Google Chrome => Google Chrome
2015-03-04 13:24 dbaz Status feedback => scheduled
2015-03-04 13:24 dbaz Resolution open => fixed
2015-03-04 13:24 dbaz Issue Monitored: AugustoMauch
2015-03-04 13:24 dbaz Status scheduled => resolved
2015-03-04 13:24 dbaz Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ad630b1df1f129b00f4cf29ee3ce7bb716e5707 [^]
2015-03-17 09:47 AugustoMauch Note Added: 0075680
2015-03-17 09:47 AugustoMauch Status resolved => closed
2015-03-17 09:47 AugustoMauch Fixed in Version => 3.0PR14Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker