Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026635Openbravo ERPA. Platformpublic2014-05-20 16:222015-03-17 09:47
Reporterguillermogil 
Assigned Todbaz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version
Product Version 
Target VersionFixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026635: Canvas field design is broken on edition
DescriptionSee the attached screenshot.

The width is not correct on editing a record on grid view.
On pick and Execute windows the canvas fields seems to be duplicated when the record gets selected.

Steps To ReproduceTo reproduce:
- open sales invoice window
- select a completed sales invoice
- click the pick example 3 button
- select a record

To get the pick example 3 button you have to install the application.example module.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2014-05-20 16:00:22.png (23,128) 2014-05-20 16:22
https://issues.openbravo.com/file_download.php?file_id=6937&type=bug
png

diff patch.diff (5,637) 2014-07-28 13:47
https://issues.openbravo.com/file_download.php?file_id=7094&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-05-20 16:22guillermogilNew Issue
2014-05-20 16:22guillermogilAssigned To => dbaz
2014-05-20 16:22guillermogilFile Added: Screenshot from 2014-05-20 16:00:22.png
2014-05-20 16:22guillermogilWeb browser => Google Chrome
2014-05-20 16:22guillermogilModules => Core
2014-05-20 16:22guillermogilTriggers an Emergency Pack => No
2014-05-20 16:23guillermogilWeb browserGoogle Chrome => Google Chrome
2014-05-20 16:23guillermogilDescription Updatedbug_revision_view_page.php?rev_id=5871#r5871
2014-07-17 15:23dbazNote Added: 0068703
2014-07-17 15:23dbazStatusnew => feedback
2014-07-28 13:47guillermogilFile Added: patch.diff
2014-07-28 13:48guillermogilNote Added: 0068920
2014-07-30 01:38hgbotCheckin
2014-07-30 01:38hgbotNote Added: 0068966
2014-07-30 01:45dbazNote Added: 0068967
2014-08-08 18:54hudsonbotCheckin
2014-08-08 18:54hudsonbotNote Added: 0069237
2015-03-04 13:24dbazReview Assigned To => AugustoMauch
2015-03-04 13:24dbazWeb browserGoogle Chrome => Google Chrome
2015-03-04 13:24dbazStatusfeedback => scheduled
2015-03-04 13:24dbazResolutionopen => fixed
2015-03-04 13:24dbazIssue Monitored: AugustoMauch
2015-03-04 13:24dbazStatusscheduled => resolved
2015-03-04 13:24dbazFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7ad630b1df1f129b00f4cf29ee3ce7bb716e5707 [^]
2015-03-17 09:47AugustoMauchNote Added: 0075680
2015-03-17 09:47AugustoMauchStatusresolved => closed
2015-03-17 09:47AugustoMauchFixed in Version => 3.0PR14Q4

Notes
(0068703)
dbaz   
2014-07-17 15:23   
This column is not showed anymore following the steps to reproduce.

Is there any other place/flow where the issue can be reproduces?
(0068920)
guillermogil   
2014-07-28 13:48   
Hi, apply the attached patch to the examples module to have an example of the button.
Regards.
(0068966)
hgbot   
2014-07-30 01:38   
Repository: erp/devel/pi
Changeset: 7ad630b1df1f129b00f4cf29ee3ce7bb716e5707
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Jul 30 01:37:56 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7ad630b1df1f129b00f4cf29ee3ce7bb716e5707 [^]

Related to issue 27083, Related to issue 27085, Related to issue 26635:
* Now clientClass OBGridFromButton used as editorType doesn't span the row width
* 'isShownInGridEdit' now it works ok in grid view (pick and execute grids still pending)
* 'canEdit' can be overwritten by specifying it in the clientClass widget

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-canvas.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0068967)
dbaz   
2014-07-30 01:45   
A changeset has been added to, in the wrong case that a new button is shown in top of the previous one, its width be the proper one.

Anyway, there are two things wrong with the current samplecode
* Ensure that the column having the button is in 'Read Only' mode to avoid the new button in the top of the previous one.
* Optional: add the attribute 'isShownInGridEdit: true' to the button definition to ensure that it always is going to be shown in the row. I said optional because this property it is not completly well implemented in the pick and execute grids, so is possible that the button be shown even without it.
(0069237)
hudsonbot   
2014-08-08 18:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test
(0075680)
AugustoMauch   
2015-03-17 09:47   
Code reviewed and verified in pi@7ad630b1df1f