Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0026500

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

feature request

[Openbravo ERP] A. Platform

minor

have not tried

2014-05-08 17:47

2022-02-01 08:09

Reporter

shuehner

View Status

public

Assigned To

Triage Platform Base

Priority

normal

Resolution

open

Fixed in Version

Status

acknowledged

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0026500: Speed up import client by factor 3-4

Description

While debugging a performance problem with import client the following came up that the following call:

log("Inserted entity " + bob.getIdentifier() + originalIdStr);
in method: addToInsertOrUpdateLists

src/org/openbravo/dal/xml/BaseXMLEntityConverter.java

Has a very big (and bad) impact on runtime.

Commenting out that call shows a reduction of runtime from 22min down to 5m40.

Checking usage of that log-output.

In most cases it is only printed to server log (if .debug level is activated).

However it is also exposed via api and seems to be part of ws-response.

So completely removing the call would be at least an api-change.
As less intrusive approach could be to make it configurabl and remove the call in the common case where it is not needed.

Steps To Reproduce

Run export.client
run import.client to import that file again
Measure runtime
Applied patch attached to this issue
Repeat import and measure runtime again.

Tags

26500.diff [^] (622 bytes) 2014-05-08 17:48 [Show Content] [Hide Content]

diff -r 6a127be95605 src/org/openbravo/dal/xml/BaseXMLEntityConverter.java
--- a/src/org/openbravo/dal/xml/BaseXMLEntityConverter.java	Thu May 08 12:46:08 2014 +0200
+++ b/src/org/openbravo/dal/xml/BaseXMLEntityConverter.java	Thu May 08 17:48:13 2014 +0200
@@ -138,7 +138,7 @@
     } else if (bob.isNewOBObject()) {
       if (!checkInsert.contains(bob)) {
         warnDifferentClientOrg(bob, "Creating");
-        log("Inserted entity " + bob.getIdentifier() + originalIdStr);
+        // log("Inserted entity " + bob.getIdentifier() + originalIdStr);
         toInsert.add(bob);
         checkInsert.add(bob);
       }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2014-05-08 17:47	shuehner	New Issue
2014-05-08 17:47	shuehner	Assigned To	=> AugustoMauch
2014-05-08 17:47	shuehner	Modules	=> Core
2014-05-08 17:47	shuehner	OBNetwork customer	=> No
2014-05-08 17:47	shuehner	Triggers an Emergency Pack	=> No
2014-05-08 17:48	shuehner	File Added: 26500.diff
2014-05-09 08:11	alostale	Tag Attached: Performance
2014-05-09 08:12	alostale	Target Version	=> PR14Q2
2014-05-20 13:42	shuehner	Target Version	PR14Q2 => PR14Q3
2014-06-25 16:16	AugustoMauch	Target Version	PR14Q3 => PR14Q4
2014-10-02 11:11	alostale	Target Version	3.0PR14Q4 => 3.0PR15Q1
2014-12-22 17:51	alostale	Target Version	3.0PR15Q1 => 3.0PR15Q2
2015-03-31 14:23	alostale	Target Version	3.0PR15Q2 => 3.0PR15Q3
2015-03-31 14:24	alostale	Assigned To	AugustoMauch => platform
2015-03-31 14:24	alostale	Status	new => acknowledged
2015-06-16 11:12	alostale	Target Version	3.0PR15Q3 => 3.0PR15Q4
2015-10-01 07:51	alostale	Target Version	3.0PR15Q4 =>
2022-02-01 08:09	alostale	Assigned To	platform => Triage Platform Base

Copyright © 2000 - 2009 MantisBT Group