Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0026500Openbravo ERPA. Platformpublic2014-05-08 17:472022-02-01 08:09
shuehner 
Triage Platform Base 
normalminorhave not tried
acknowledgedopen 
5
 
 
Core
No
0026500: Speed up import client by factor 3-4
While debugging a performance problem with import client the following came up that the following call:

        log("Inserted entity " + bob.getIdentifier() + originalIdStr);
in method: addToInsertOrUpdateLists

src/org/openbravo/dal/xml/BaseXMLEntityConverter.java

Has a very big (and bad) impact on runtime.

Commenting out that call shows a reduction of runtime from 22min down to 5m40.

Checking usage of that log-output.

In most cases it is only printed to server log (if .debug level is activated).

However it is also exposed via api and seems to be part of ws-response.

So completely removing the call would be at least an api-change.
As less intrusive approach could be to make it configurabl and remove the call in the common case where it is not needed.
Run export.client
run import.client to import that file again
Measure runtime
Applied patch attached to this issue
Repeat import and measure runtime again.

Performance
diff 26500.diff (622) 2014-05-08 17:48
https://issues.openbravo.com/file_download.php?file_id=6913&type=bug
Issue History
2014-05-08 17:47shuehnerNew Issue
2014-05-08 17:47shuehnerAssigned To => AugustoMauch
2014-05-08 17:47shuehnerModules => Core
2014-05-08 17:47shuehnerTriggers an Emergency Pack => No
2014-05-08 17:48shuehnerFile Added: 26500.diff
2014-05-09 08:11alostaleTag Attached: Performance
2014-05-09 08:12alostaleTarget Version => PR14Q2
2014-05-20 13:42shuehnerTarget VersionPR14Q2 => PR14Q3
2014-06-25 16:16AugustoMauchTarget VersionPR14Q3 => PR14Q4
2014-10-02 11:11alostaleTarget Version3.0PR14Q4 => 3.0PR15Q1
2014-12-22 17:51alostaleTarget Version3.0PR15Q1 => 3.0PR15Q2
2015-03-31 14:23alostaleTarget Version3.0PR15Q2 => 3.0PR15Q3
2015-03-31 14:24alostaleAssigned ToAugustoMauch => platform
2015-03-31 14:24alostaleStatusnew => acknowledged
2015-06-16 11:12alostaleTarget Version3.0PR15Q3 => 3.0PR15Q4
2015-10-01 07:51alostaleTarget Version3.0PR15Q4 =>
2022-02-01 08:09alostaleAssigned Toplatform => Triage Platform Base

There are no notes attached to this issue.