Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0026217
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2014-04-08 18:302014-06-27 16:50
ReporterjecharriView Statuspublic 
Assigned Tomalsasua 
PriorityurgentResolutionfixedFixed in VersionRR14Q3
StatusclosedFix in branchFixed in SCM revision7b35aae163e6
ProjectionnoneETAnoneTarget VersionRR14Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRMP31.2SCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026217: When the order goes to Errors while importing POS Data due to a wrong configuration in the BP

DescriptionWhen the order goes to Errors while importing POS Data due to a wrong configuration in the BP
Steps To Reproduce-Configure a business partner without payment method
-Go to Web POS and create and order
-Pay it
-The order will go to "errors while importing pos data"

At this point, you need to edit JSON object and isert a valid payment method id. It will be easier if the user has to change only the BP configuration using UI, so when the java OrderLoader try to create the order, can get the BusinessPartner object using DAL and not from the JSON object.
Proposed SolutionInstead of taking the BP values from json object, use DAL to get last BP object:
order.setPartnerAddress(OBDal.getInstance().get(Location.class,
        jsonorder.getJSONObject("bp").getString("locId")));
    order.setInvoiceAddress(order.getPartnerAddress());
    order.setPaymentMethod((FIN_PaymentMethod) OBDal.getInstance().getProxy("FIN_PaymentMethod",
        jsonorder.getJSONObject("bp").getString("paymentMethod")));
    order.setPaymentTerms((PaymentTerm) OBDal.getInstance().getProxy("FinancialMgmtPaymentTerm",
        jsonorder.getJSONObject("bp").getString("paymentTerms")));
    order.setInvoiceTerms(jsonorder.getJSONObject("bp").getString("invoiceTerms"));
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0032777 closedranjith_qualiantech_com [SER QA 974] Ticket not synchronized to the backoffice because the Invoice Term is not defined  

-  Notes
(0068324)
hgbot (developer)
2014-06-26 00:06

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7b35aae163e6ef90996a7d80b6f64a226e5958ae
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Wed Jun 25 18:47:04 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b35aae163e6ef90996a7d80b6f64a226e5958ae [^]

fixed issue 26217: customer data came from bp now except address

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0068422)
hgbot (developer)
2014-06-27 16:50

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 409cef1f6b5c8e9d47aaef5bb0316395b6807ecf
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jun 27 16:50:17 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/409cef1f6b5c8e9d47aaef5bb0316395b6807ecf [^]

Related to issue 26217. Improved efficiency a bit by avoiding additional OBDal.get

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2014-04-08 18:30 jecharri New Issue
2014-04-08 18:30 jecharri Assigned To => malsasua
2014-04-08 18:30 jecharri Resolution time => 1399932000
2014-04-08 18:30 jecharri Triggers an Emergency Pack => No
2014-06-26 00:06 hgbot Checkin
2014-06-26 00:06 hgbot Note Added: 0068324
2014-06-26 00:06 hgbot Status new => resolved
2014-06-26 00:06 hgbot Resolution open => fixed
2014-06-26 00:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b35aae163e6ef90996a7d80b6f64a226e5958ae [^]
2014-06-27 16:50 hgbot Checkin
2014-06-27 16:50 hgbot Note Added: 0068422
2014-06-27 16:50 marvintm Review Assigned To => marvintm
2014-06-27 16:50 marvintm Status resolved => closed
2014-06-27 16:50 marvintm Fixed in Version => RR14Q3
2016-04-28 17:09 VictorVillar Relationship added related to 0032777


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker