0026148: Journal entries report entry number is not correctly displayed when the number is greater than 9999

CREATE OR REPLACE FUNCTION generate_gljournallines() RETURNS void AS $BODY$ DECLARE client_id VARCHAR(32) := '23C59575B9CF467C9620760EB255B389'; org_id VARCHAR(32) := 'B843C30461EA4501935CB1D125C9C25A'; user_id VARCHAR(32) := '100'; description_batch VARCHAR(2000) := 'Ampliaciones de capital'; description_gl VARCHAR(2000) := 'Ampliacion de capital'; currency_id VARCHAR(2000) := '102'; period_id VARCHAR(2000) := '311614366A88487B89B3E0D66100C0DC'; batch_no VARCHAR(32); batch_id VARCHAR(32); gl_no VARCHAR(32); gl_id VARCHAR(32); acctschema_id VARCHAR(32) := 'F6488042ACD14B6A87EBF42DB13F9EFC'; doctype_id VARCHAR(32) := 'BE84926D9C1B4C98866E3F5BE8621F02'; glcategory_id VARCHAR(32) := 'EDA7B85AF9A5486D9B00CAFFD3B86FC2'; validcomb_dr VARCHAR(32) := 'FA63454C68B84209906CC855EEAE6B0D'; validcomb_cr VARCHAR(32) := '28EAF153C6DA46F382E8D71B9725ACCB'; amount NUMERIC := 50000; i NUMERIC := 0; max NUMERIC := 10000; BEGIN SELECT DOCUMENTNO INTO batch_no FROM GL_JOURNALBATCH WHERE AD_CLIENT_ID = client_id AND AD_ORG_ID = org_id ORDER BY DOCUMENTNO DESC LIMIT 1; batch_no := TO_CHAR(TO_NUMBER(batch_no)+1); batch_id := GET_UUID(); -- Create batch INSERT INTO GL_JOURNALBATCH (GL_JOURNALBATCH_ID, AD_CLIENT_ID, AD_ORG_ID, CREATEDBY, UPDATEDBY, DESCRIPTION, DOCUMENTNO, POSTINGTYPE, C_PERIOD_ID, C_CURRENCY_ID, TOTALDR, TOTALCR) VALUES (batch_id, client_id, org_id, user_id, user_id, description_batch, batch_no, 'A', period_id, currency_id, amount, amount); SELECT DOCUMENTNO INTO gl_no FROM GL_JOURNAL WHERE AD_CLIENT_ID = client_id AND AD_ORG_ID = org_id ORDER BY DOCUMENTNO DESC LIMIT 1; gl_no := TO_CHAR(TO_NUMBER(gl_no)+1); WHILE i < max LOOP gl_no := TO_CHAR(TO_NUMBER(gl_no)+1); gl_id := GET_UUID(); -- Create journal header INSERT INTO GL_JOURNAL (GL_JOURNALBATCH_ID, GL_JOURNAL_ID, AD_CLIENT_ID, AD_ORG_ID, CREATEDBY, UPDATEDBY, C_ACCTSCHEMA_ID, C_DOCTYPE_ID, DOCUMENTNO, DESCRIPTION, POSTINGTYPE, DOCSTATUS, DOCACTION, GL_CATEGORY_ID, C_PERIOD_ID, C_CURRENCY_ID, TOTALDR, TOTALCR, DATEDOC, DATEACCT, CURRENCYRATETYPE, CURRENCYRATE) VALUES (batch_id, gl_id, client_id, org_id, user_id, user_id, acctschema_id, doctype_id, gl_no, description_gl, 'A', 'DR', 'CO', glcategory_id, period_id, currency_id, amount, amount, NOW(), NOW(), 'S', 1); -- Create journal lines -- Debit INSERT INTO GL_JOURNALLINE (GL_JOURNAL_ID, GL_JOURNALLINE_ID, AD_CLIENT_ID, AD_ORG_ID, CREATEDBY, UPDATEDBY, DESCRIPTION, AMTSOURCEDR, AMTACCTDR, C_VALIDCOMBINATION_ID, C_CURRENCY_ID, CURRENCYRATETYPE, CURRENCYRATE, LINE) VALUES (gl_id, GET_UUID(), client_id, org_id, user_id, user_id, description_gl, amount, amount, validcomb_dr, currency_id, 'S', 1, 10); -- Credit INSERT INTO GL_JOURNALLINE (GL_JOURNAL_ID, GL_JOURNALLINE_ID, AD_CLIENT_ID, AD_ORG_ID, CREATEDBY, UPDATEDBY, DESCRIPTION, AMTSOURCECR, AMTACCTCR, C_VALIDCOMBINATION_ID, C_CURRENCY_ID, CURRENCYRATETYPE, CURRENCYRATE, LINE) VALUES (gl_id, GET_UUID(), client_id, org_id, user_id, user_id, description_gl, amount, amount, validcomb_cr, currency_id, 'S', 1, 20); i := i+1; END LOOP; RETURN; END $BODY$ LANGUAGE plpgsql VOLATILE COST 100; ALTER FUNCTION generate_gljournallines() OWNER TO tad;

diff --git a/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.jrxml b/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.jrxml --- a/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.jrxml +++ b/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.jrxml @@ -168,7 +168,7 @@ <printWhenExpression><![CDATA[$P{ShowDescription}.equals( "" )]]></printWhenExpression> </reportElement> <staticText> - <reportElement key="staticText-9" style="GroupHeader_DarkGray" x="2" y="2" width="31" height="18" forecolor="#000000" backcolor="#FFFFFF"/> + <reportElement key="staticText-9" style="GroupHeader_DarkGray" x="2" y="2" width="48" height="18" forecolor="#000000" backcolor="#FFFFFF"/> <box leftPadding="5"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -181,7 +181,7 @@ <text><![CDATA[Entry]]></text> </staticText> <staticText> - <reportElement key="staticText-10" style="GroupHeader_DarkGray" x="31" y="2" width="54" height="18" forecolor="#000000" backcolor="#FFFFFF"/> + <reportElement key="staticText-10" style="GroupHeader_DarkGray" x="50" y="2" width="68" height="18" forecolor="#000000" backcolor="#FFFFFF"/> <box leftPadding="5"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -194,7 +194,7 @@ <text><![CDATA[Date]]></text> </staticText> <staticText> - <reportElement key="staticText-3" style="GroupHeader_Gray" x="213" y="2" width="76" height="18" backcolor="#FFFFFF"/> + <reportElement key="staticText-3" style="GroupHeader_Gray" x="195" y="2" width="60" height="18" backcolor="#FFFFFF"/> <box leftPadding="2" rightPadding="2"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -207,7 +207,7 @@ <text><![CDATA[Account No]]></text> </staticText> <staticText> - <reportElement key="staticText-4" style="GroupHeader_Gray" x="291" y="2" width="118" height="18" backcolor="#FFFFFF"/> + <reportElement key="staticText-4" style="GroupHeader_Gray" x="255" y="2" width="154" height="18" backcolor="#FFFFFF"/> <box leftPadding="2" rightPadding="2"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -246,7 +246,7 @@ <text><![CDATA[Credit]]></text> </staticText> <staticText> - <reportElement mode="Opaque" x="89" y="2" width="125" height="18" isPrintWhenDetailOverflows="true" forecolor="#000000" backcolor="#FFFFFF"/> + <reportElement mode="Opaque" x="118" y="2" width="75" height="18" isPrintWhenDetailOverflows="true" forecolor="#000000" backcolor="#FFFFFF"/> <textElement textAlignment="Left" verticalAlignment="Middle" rotation="None" lineSpacing="Single" markup="none"> <font fontName="DejaVu Sans" size="8" isBold="true" isItalic="false" isUnderline="false" isStrikeThrough="false" pdfFontName="Helvetica" pdfEncoding="Cp1252" isPdfEmbedded="false"/> </textElement> @@ -254,7 +254,7 @@ </staticText> <line> <reportElement key="line-1" x="0" y="1" width="535" height="1"/> - </line> +  </line> <line> <reportElement key="line-1" x="0" y="20" width="535" height="1"/> @@ -367,7 +367,7 @@ <printWhenExpression><![CDATA[$P{ShowDescription}.equals( "" )]]></printWhenExpression> </reportElement> <textField isBlankWhenNull="false"> - <reportElement key="textField" x="215" y="0" width="76" height="10"/> + <reportElement key="textField" x="198" y="0" width="57" height="10"/> <box leftPadding="2" rightPadding="2"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -379,8 +379,8 @@ </textElement> <textFieldExpression class="java.lang.String"><![CDATA[$F{VALUE}]]></textFieldExpression> </textField> - <textField isBlankWhenNull="false"> - <reportElement key="textField" x="291" y="0" width="118" height="10"/> + <textField isStretchWithOverflow="true" isBlankWhenNull="false"> + <reportElement key="textField" x="255" y="0" width="154" height="10"/> <box leftPadding="2" rightPadding="2"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -421,7 +421,7 @@ <frame> <reportElement isPrintRepeatedValues="false" x="0" y="0" width="217" height="10"/> <textField pattern="" isBlankWhenNull="false"> - <reportElement key="textField-1" style="GroupHeader_DarkGray" mode="Opaque" x="3" y="0" width="28" height="10" printWhenGroupChanges="JournalEntry" forecolor="#000000" backcolor="#FFFFFF"/> + <reportElement key="textField-1" style="GroupHeader_DarkGray" mode="Opaque" x="3" y="0" width="47" height="10" printWhenGroupChanges="JournalEntry" forecolor="#000000" backcolor="#FFFFFF"/> <box leftPadding="5"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -434,7 +434,7 @@ <textFieldExpression class="java.math.BigDecimal"><![CDATA[($V{entry}!=null)?$V{entry}.add(new BigDecimal($P{InitialEntryNumber})).subtract(BigDecimal.ONE): BigDecimal.ONE]]></textFieldExpression> </textField> <textField isBlankWhenNull="false"> - <reportElement key="textField-2" style="GroupHeader_DarkGray" mode="Opaque" x="33" y="0" width="54" height="10" printWhenGroupChanges="JournalEntry" forecolor="#000000" backcolor="#FFFFFF"/> + <reportElement key="textField-2" style="GroupHeader_DarkGray" mode="Opaque" x="50" y="0" width="68" height="10" printWhenGroupChanges="JournalEntry" forecolor="#000000" backcolor="#FFFFFF"/> <box leftPadding="5"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -447,7 +447,7 @@ <textFieldExpression class="java.util.Date"><![CDATA[$F{DATEACCT}]]></textFieldExpression> </textField> <textField isStretchWithOverflow="true" isBlankWhenNull="true"> - <reportElement key="textField" x="91" y="0" width="126" height="10" isPrintWhenDetailOverflows="true" printWhenGroupChanges="JournalEntry"/> + <reportElement key="textField" x="118" y="0" width="75" height="10" isPrintWhenDetailOverflows="true" printWhenGroupChanges="JournalEntry"/> <box leftPadding="2" rightPadding="2"> <topPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> <leftPen lineWidth="0.0" lineStyle="Solid" lineColor="#000000"/> @@ -458,7 +458,7 @@ <font fontName="DejaVu Sans" size="8" isBold="false"/> </textElement> <textFieldExpression class="java.lang.String"><![CDATA[$F{DOCNAME}]]></textFieldExpression> - </textField> +  </textField> </frame> </frame>

Notes
(0067076) rafaroda (viewer) 2014-05-09 17:18	Steps to reproduce the issue and test the fix: 1) Go to database and execute query inside generate_gljournallines.txt (file attached) 2) Execute query: SELECT * FROM generate_gljournallines(); (this will take some time) 3) Go to Openbravo en enter with F&B International Group Admin 4) Go to G/L Journal window and look for record with description "Ampliaciones de capital" 5) Select this record and click on Process Batch (this will quite a long time, be patient) 6) Once finished, go to Process request window and click on Unschedule and then on Reschedule in Acct Server Process record 7) Go to Journal Entries Report and launch it in PDF (this will take some time) 8) As seen in the image and the PDF attached, entries' numbers bigger than 9999 aren't correctly displayed.

(0067139) rafaroda (viewer) 2014-05-15 10:54	Attached diff of fix and screenshot and PDF of the report corrected.

(0067248) hgbot (developer) 2014-05-19 12:07	Repository: erp/devel/pi Changeset: c60e27530619b375095c13e3578bce2b09d0af52 Author: Rafa Roda Palacios <rafa.roda <at> ubiquads.com> Date: Wed May 14 10:32:46 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c60e27530619b375095c13e3578bce2b09d0af52 [^] Fixes Issue 26148 Modified ReportGeneralLedgerJournal JRXML file so entry numbers > 9999 are displayed --- M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.jrxml ---

(0067324) hudsonbot (viewer) 2014-05-20 17:53	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8d555b8cf67e [^] Maturity status: Test

(0067329) AtulOpenbravo (viewer) 2014-05-20 20:28	Verified

Issue History
Date Modified	Username	Field	Change
2014-04-02 14:28	jonalegriaesarte	New Issue
2014-04-02 14:28	jonalegriaesarte	Assigned To	=> pramakrishnan
2014-04-02 14:28	jonalegriaesarte	Modules	=> Core
2014-04-02 14:28	jonalegriaesarte	OBNetwork customer	=> Yes
2014-04-02 14:28	jonalegriaesarte	Support ticket	=> 27645
2014-04-02 14:28	jonalegriaesarte	Resolution time	=> 1399327200
2014-04-02 14:28	jonalegriaesarte	Triggers an Emergency Pack	=> No
2014-05-09 17:18	rafaroda	Note Added: 0067076
2014-05-09 17:19	rafaroda	File Added: generate_gljournallines.txt
2014-05-09 17:19	rafaroda	File Added: JournalEntriesReportBug.png
2014-05-09 17:19	rafaroda	File Added: JournalEntriesReport10000.pdf
2014-05-12 12:00	rafaroda	Assigned To	pramakrishnan => rafaroda
2014-05-12 16:20	AtulOpenbravo	Status	new => scheduled
2014-05-12 16:20	AtulOpenbravo	fix_in_branch	=> pi
2014-05-15 10:52	rafaroda	File Added: JournalEntriesReportFixed.png
2014-05-15 10:53	rafaroda	File Added: JournalEntriesReport10000Fixed.pdf
2014-05-15 10:53	rafaroda	File Added: issue-26148.diff
2014-05-15 10:54	rafaroda	Note Added: 0067139
2014-05-19 12:07	hgbot	Checkin
2014-05-19 12:07	hgbot	Note Added: 0067248
2014-05-19 12:07	hgbot	Status	scheduled => resolved
2014-05-19 12:07	hgbot	Resolution	open => fixed
2014-05-19 12:07	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/c60e27530619b375095c13e3578bce2b09d0af52 [^]
2014-05-20 17:53	hudsonbot	Checkin
2014-05-20 17:53	hudsonbot	Note Added: 0067324
2014-05-20 20:28	AtulOpenbravo	Note Added: 0067329
2014-05-20 20:28	AtulOpenbravo	Status	resolved => closed
2014-05-20 20:28	AtulOpenbravo	Fixed in Version	=> pi

Relationships [ Relation Graph ] [ Dependency Graph ]