Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0026118
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2014-03-28 11:072014-12-16 22:29
ReportermigueldejuanaView Statuspublic 
Assigned ToOsmany 
PrioritynormalResolutionfixedFixed in VersionRR15Q1
StatusclosedFix in branchFixed in SCM revision929aa6ebf814
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026118: When we are in Multiorders if we press F5 we get an error.

DescriptionWhen we are in Multiorders if we press F5 we get an error.
Steps To ReproduceWhen we are in Multiorders if we press F5 we get an error.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0028057 closedmigueldejuana Undefined js error when refreshing page from pay open tickets 
has duplicate defect 0026032 closedmarvintm If we are in multiorder window and we pres F5 we get an error 

-  Notes
(0072556)
hgbot (developer)
2014-12-16 15:04

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f8e536acea0d11d6213bbb5cececd1221da37aef
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Tue Dec 16 08:03:26 2014 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f8e536acea0d11d6213bbb5cececd1221da37aef [^]

Fixed issue 26118: When we are in Multiorders if we press F5 we get an error.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0072559)
mtaal (manager)
2014-12-16 16:02

 Hi,
Was checking it, but the code change means that the if this.receipt is null then it will end up in the else of the if-statement.

Is this indeed what you intend?
So instead of this:
    if (!isMultiOrders && !_.isNull(this.receipt)) {
      this.receipt.selectedPayment = payment.payment.searchKey;
      paymentstatus = this.receipt.getPaymentStatus();
    } else {
      this.model.get('multiOrders').set('selectedPayment', payment.payment.searchKey);
      paymentstatus = this.model.get('multiOrders').getPaymentStatus();
    }

I would do this:

if (!_.isNull(this.receipt)) {
    if (!isMultiOrders) {
      this.receipt.selectedPayment = payment.payment.searchKey;
      paymentstatus = this.receipt.getPaymentStatus();
    } else {
      this.model.get('multiOrders').set('selectedPayment', payment.payment.searchKey);
      paymentstatus = this.model.get('multiOrders').getPaymentStatus();
    }
}
(0072561)
Osmany (developer)
2014-12-16 16:17

 Hi, I like idea, but if we do this:

    if (!isMultiOrders) {
       if (!_.isNull(this.receipt)) {
        this.receipt.selectedPayment = payment.payment.searchKey;
        paymentstatus = this.receipt.getPaymentStatus();
       }
    } else {
      this.model.get('multiOrders').set('selectedPayment', payment.payment.searchKey);
      paymentstatus = this.model.get('multiOrders').getPaymentStatus();
    }
What do you think?
Regards.
(0072563)
mtaal (manager)
2014-12-16 16:24

 yes I guess this is best, can you try it and if it works push the change?

I will then close the issue.
(0072575)
hgbot (developer)
2014-12-16 20:26

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 929aa6ebf814eed09d87773bf6891754bb94c314
Author: Osmany Garcia Machado <osmany.machado <at> peoplewalking.com>
Date: Tue Dec 16 13:25:57 2014 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/929aa6ebf814eed09d87773bf6891754bb94c314 [^]

Fixed issue 26118: Validation of paymentstatus and requiredCash when are undefined, because the receipt is null

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0072580)
mtaal (manager)
2014-12-16 22:29

 Reviewed and tested

- Issue History
Date Modified Username Field Change
2014-03-28 11:07 migueldejuana New Issue
2014-03-28 11:07 migueldejuana Assigned To => migueldejuana
2014-03-28 11:07 migueldejuana Triggers an Emergency Pack => No
2014-12-15 10:17 mtaal Relationship added has duplicate 0028057
2014-12-15 17:29 mario_castello Assigned To migueldejuana => mario_castello
2014-12-16 15:02 Osmany Assigned To mario_castello => Osmany
2014-12-16 15:04 hgbot Checkin
2014-12-16 15:04 hgbot Note Added: 0072556
2014-12-16 15:04 hgbot Status new => resolved
2014-12-16 15:04 hgbot Resolution open => fixed
2014-12-16 15:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f8e536acea0d11d6213bbb5cececd1221da37aef [^]
2014-12-16 16:02 mtaal Note Added: 0072559
2014-12-16 16:02 mtaal Status resolved => new
2014-12-16 16:02 mtaal Resolution fixed => open
2014-12-16 16:17 Osmany Note Added: 0072561
2014-12-16 16:24 mtaal Note Added: 0072563
2014-12-16 20:26 hgbot Checkin
2014-12-16 20:26 hgbot Note Added: 0072575
2014-12-16 20:26 hgbot Status new => resolved
2014-12-16 20:26 hgbot Resolution open => fixed
2014-12-16 20:26 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f8e536acea0d11d6213bbb5cececd1221da37aef [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/929aa6ebf814eed09d87773bf6891754bb94c314 [^]
2014-12-16 22:29 mtaal Review Assigned To => mtaal
2014-12-16 22:29 mtaal Note Added: 0072580
2014-12-16 22:29 mtaal Status resolved => closed
2014-12-16 22:29 mtaal Fixed in Version => RR15Q1
2014-12-17 16:52 mtaal Relationship added has duplicate 0026032

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker