Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0026011 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2014-03-15 14:48 | 2014-03-24 12:10 | |||
| Reporter | iperdomo | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR14Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | a4bac660abf1 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR14Q2 | |||
| OS | Linux 64 bit | Database | Oracle | Java version | 1.6.0_30 | |||
| OS Version | Oracle Linux 3.8.13-26.1.1.el6ue | Database version | 11.2.0 (XE) | Ant version | 1.7.1 | |||
| Product Version | 3.0MP29.1 | SCM revision | ||||||
| Review Assigned To | shankarb | |||||||
| Web browser | Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox | |||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0026011: Selector Out Field don't work in grid mode | |||||||
| Description | Selector Out Fields works fine when editing a record in form view, but it fails on grid view. | |||||||
| Steps To Reproduce | * Install the attached module and template * The module changes the Dependency tab in Module window * Pick a module * Create a new dependency in form view, select a module and see that the field `Last Version` gets populated with the module version - OK * Delete the dependency * Repeat the process in Grid view, when selecting a module using the selector, the process of setting the `Last Version` value fails - KO | |||||||
| Proposed Solution | Attached you'll find a proposed patch NOTE: this needs to be tested setting a value for a List|Table references | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  selector-outfields.zip [^] (6,132 bytes) 2014-03-15 14:48 selector-outfield.diff [^] (709 bytes) 2014-03-15 14:49 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0065299) hgbot (developer) 2014-03-20 11:21 |
Repository: erp/devel/pi Changeset: a4bac660abf106f290fc270dc7a0f077dc02a96a Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Mar 20 11:21:11 2014 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/a4bac660abf106f290fc270dc7a0f077dc02a96a [^] Fixes issue 26011: Selector Out Field don't work in grid mode The problem was that the fields[j].setValue function was being used to apply store the value of the out fields, and that function is not available when the sel ector is used in the grid view. To solve this, grid.setEditValue is used if the fields[j].setValue function is not available. --- M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js --- |
|
(0065300) AugustoMauch (manager) 2014-03-20 11:22 |
It has been tested with: - Text out fields - Foreign key out fields |
|
(0065325) hudsonbot (developer) 2014-03-21 07:34 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/264e48f53209 [^] Maturity status: Test |
|
(0065329) iperdomo (reporter) 2014-03-21 07:53 |
@AugustoMuach On using guard `&&` operator https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Logical_Operators [^] |
|
(0065330) AugustoMauch (manager) 2014-03-21 08:14 |
@iperdomo Thanks Ivan. It is not that I did not understand it, the problem was that jslint did not like it: jslint:modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js:719:34:The '&&' subexpression should be wrapped in parens. jslint:modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js:719:111:Expected an assignment or function call and instead saw an expression. |
|
(0065390) shankarb (reporter) 2014-03-24 12:10 |
Code reviewed and verified in pi changeset b24d8a94df0e. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-03-15 14:48 | iperdomo | New Issue | |
| 2014-03-15 14:48 | iperdomo | Assigned To | => AugustoMauch |
| 2014-03-15 14:48 | iperdomo | File Added: selector-outfields.zip | |
| 2014-03-15 14:48 | iperdomo | Web browser | => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox |
| 2014-03-15 14:48 | iperdomo | Modules | => Core |
| 2014-03-15 14:48 | iperdomo | Triggers an Emergency Pack | => No |
| 2014-03-15 14:49 | iperdomo | File Added: selector-outfield.diff | |
| 2014-03-17 08:21 | alostale | Web browser | Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox |
| 2014-03-17 08:21 | alostale | Target Version | => PR14Q2 |
| 2014-03-17 09:25 | jonalegriaesarte | Web browser | Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox |
| 2014-03-17 09:25 | jonalegriaesarte | Resolution time | => 1395961200 |
| 2014-03-17 09:25 | jonalegriaesarte | Web browser | Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox |
| 2014-03-18 11:56 | shankarb | Assigned To | AugustoMauch => shankarb |
| 2014-03-20 10:11 | AugustoMauch | Assigned To | shankarb => AugustoMauch |
| 2014-03-20 11:16 | AugustoMauch | Issue Monitored: shankarb | |
| 2014-03-20 11:16 | AugustoMauch | Review Assigned To | => shankarb |
| 2014-03-20 11:16 | AugustoMauch | Web browser | Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox |
| 2014-03-20 11:21 | hgbot | Checkin | |
| 2014-03-20 11:21 | hgbot | Note Added: 0065299 | |
| 2014-03-20 11:21 | hgbot | Status | new => resolved |
| 2014-03-20 11:21 | hgbot | Resolution | open => fixed |
| 2014-03-20 11:21 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a4bac660abf106f290fc270dc7a0f077dc02a96a [^] |
| 2014-03-20 11:22 | AugustoMauch | Note Added: 0065300 | |
| 2014-03-21 07:34 | hudsonbot | Checkin | |
| 2014-03-21 07:34 | hudsonbot | Note Added: 0065325 | |
| 2014-03-21 07:53 | iperdomo | Note Added: 0065329 | |
| 2014-03-21 08:14 | AugustoMauch | Note Added: 0065330 | |
| 2014-03-24 12:10 | shankarb | Note Added: 0065390 | |
| 2014-03-24 12:10 | shankarb | Status | resolved => closed |
| 2014-03-24 12:10 | shankarb | Fixed in Version | => PR14Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |