Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0025975
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2014-03-12 18:182014-05-16 12:44
ReporterjecharriView Statuspublic 
Assigned Tomalsasua 
PriorityurgentResolutionfixedFixed in VersionRR14Q3
StatusclosedFix in branchFixed in SCM revision31364003833b
ProjectionnoneETAnoneTarget VersionRR14Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionRMP31.2SCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025975: Some business partners are not synchronized when they have 2 addresses

DescriptionSome business partners are not synchronized when they have 2 addresses
Steps To Reproduce-go to https://livebuilds.openbravo.com/retail_pi_pgsql [^]
-select BP "VBS Customer" and go to tab "Location"
-add a location with checkbox shipping address to 'Y' and invoice 'N'
-modify existing address and uncheck shipping address

Verify that BP is not synchronized with Web POS

It happens the same If you uncheck only the shipping address when you have only one address. However this it can be considered as wrong configuration
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0065204)
eintelau (developer)
2014-03-17 00:45

We also just found this issue at a customer. I believe the problem is with the query that retrieves the business partner data. It is filtering for addresses that are invoice to, but has a subquery (selecting max location id) that does not have the same filter.

When a customer has an address which is not invoiceable then the subquery can select that address, but the main query excludes it and hence the partner data is not returned

The particular subquery is

 bpl.id in (select max(bpls.id) as bpLocId from BusinessPartnerLocation AS bpls where bpls.$readableClientCriteria AND "
                + " bpls.$naturalOrgCriteria group by bpls.businessPartner.id)"

and it needs to be changed to

 bpl.id in (select max(bpls.id) as bpLocId from BusinessPartnerLocation AS bpls where bpls.invoiceToAddress = true and bpls.$readableClientCriteria AND "
                + " bpls.$naturalOrgCriteria group by bpls.businessPartner.id)"

(Note addition of bpls.invoiceToAddress = true clause)
This change fixed the problem for us
(0066526)
hgbot (developer)
2014-04-22 11:45

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 31364003833b1005a319710ab6979ce9a47604d7
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue Apr 22 11:45:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31364003833b1005a319710ab6979ce9a47604d7 [^]

fixed issue 0025975: Some business partners are not synchronized when they have 2 addresses

---
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
---
(0066743)
hgbot (developer)
2014-05-01 17:44

Repository: erp/pmods/org.openbravo.retail.posterminal.unstablenetworks
Changeset: 31364003833b1005a319710ab6979ce9a47604d7
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Tue Apr 22 11:45:25 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/31364003833b1005a319710ab6979ce9a47604d7 [^]

fixed issue 0025975: Some business partners are not synchronized when they have 2 addresses

---
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/BusinessPartner.java
---

- Issue History
Date Modified Username Field Change
2014-03-12 18:18 jecharri New Issue
2014-03-12 18:18 jecharri Assigned To => marvintm
2014-03-12 18:18 jecharri Resolution time => 1397599200
2014-03-12 18:18 jecharri Triggers an Emergency Pack => No
2014-03-12 18:21 jecharri Steps to Reproduce Updated View Revisions
2014-03-17 00:11 eintelau Issue Monitored: eintelau
2014-03-17 00:45 eintelau Note Added: 0065204
2014-03-17 10:52 malsasua Assigned To marvintm => malsasua
2014-03-31 16:24 jonalegriaesarte Target Version RR14Q2 => RR14Q3
2014-04-22 11:45 hgbot Checkin
2014-04-22 11:45 hgbot Note Added: 0066526
2014-04-22 11:45 hgbot Status new => resolved
2014-04-22 11:45 hgbot Resolution open => fixed
2014-04-22 11:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31364003833b1005a319710ab6979ce9a47604d7 [^]
2014-05-01 17:44 hgbot Checkin
2014-05-01 17:44 hgbot Note Added: 0066743
2014-05-01 17:44 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/31364003833b1005a319710ab6979ce9a47604d7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/31364003833b1005a319710ab6979ce9a47604d7 [^]
2014-05-16 12:44 marvintm Review Assigned To => marvintm
2014-05-16 12:44 marvintm Status resolved => closed
2014-05-16 12:44 marvintm Fixed in Version => RR14Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker