Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0025969 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | have not tried | 2014-03-12 09:56 | 2014-03-13 07:41 | |||
Reporter | AugustoMauch | View Status | public | |||||
Assigned To | AugustoMauch | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR14Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 143dbdd74f2b | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | alostale | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0025969: Bug in LinkToParentTreeDatasourceService when the parameters of a query are set | |||||||
Description | In this line [1] a parameter is added to the query if the variable fetchRoot is false. In this other line [2], regardless of the value of fetchRoot, the value of the parameter is added to the list that will be assigned to the query. If this function is called with fetchRoot = true, the '?' parameter will not be added to the query, but its value will be assigned as a parameter, resulting in an error. [1] https://code.openbravo.com/erp/devel/pi/file/95e63d963d4d/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java#l249 [^] [2] https://code.openbravo.com/erp/devel/pi/file/95e63d963d4d/modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java#l256 [^] | |||||||
Steps To Reproduce | Check the links in the description box. | |||||||
Proposed Solution | Only set the value of the parameter if the parameter has been actually added. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0065088) hgbot (developer) 2014-03-12 09:58 |
Repository: erp/devel/pi Changeset: 143dbdd74f2baf507122e13348324efb2e0caa98 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Mar 12 09:57:48 2014 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/143dbdd74f2baf507122e13348324efb2e0caa98 [^] Fixes issue 25969: Adds properly the value of a parameter to a query object The value of a parameter is added to a query object only if the parameter has been actually included in the query string. --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/LinkToParentTreeDatasourceService.java --- |
(0065101) hudsonbot (viewer) 2014-03-12 17:35 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9ff7be508001 [^] Maturity status: Test |
(0065112) alostale (viewer) 2014-03-13 07:41 |
code reviewed |
![]() |
|||
Date Modified | Username | Field | Change |
2014-03-12 09:56 | AugustoMauch | New Issue | |
2014-03-12 09:56 | AugustoMauch | Assigned To | => AugustoMauch |
2014-03-12 09:56 | AugustoMauch | Modules | => Core |
2014-03-12 09:56 | AugustoMauch | OBNetwork customer | => No |
2014-03-12 09:56 | AugustoMauch | Triggers an Emergency Pack | => No |
2014-03-12 09:56 | AugustoMauch | Issue Monitored: shankarb | |
2014-03-12 09:58 | hgbot | Checkin | |
2014-03-12 09:58 | hgbot | Note Added: 0065088 | |
2014-03-12 09:58 | hgbot | Status | new => resolved |
2014-03-12 09:58 | hgbot | Resolution | open => fixed |
2014-03-12 09:58 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/143dbdd74f2baf507122e13348324efb2e0caa98 [^] |
2014-03-12 17:35 | hudsonbot | Checkin | |
2014-03-12 17:35 | hudsonbot | Note Added: 0065101 | |
2014-03-13 07:41 | alostale | Review Assigned To | => alostale |
2014-03-13 07:41 | alostale | Note Added: 0065112 | |
2014-03-13 07:41 | alostale | Status | resolved => closed |
2014-03-13 07:41 | alostale | Fixed in Version | => PR14Q2 |
Copyright © 2000 - 2009 MantisBT Group |