Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0025899

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

major

have not tried

2014-03-04 17:13

2014-03-07 05:25

Reporter

egoitz

View Status

public

Assigned To

shankarb

Priority

immediate

Resolution

fixed

Fixed in Version

3.0PR14Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0PR14Q2

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

AugustoMauch

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0025899: When invoking the method Utility.getDocumentNo from a DalBaseProcess the client is not obtained

Description

When invoking the method Utility.getDocumentNo from a DalBaseProcess the client is not obtained

Steps To Reproduce

-Create a new table (Prefix_Tablename) that includes all the mandatory columns and also name and documentno columns.
-Define it on application dictionary with name Prefix_Tablename
-Create a sequence with name DocumentNo_Prefix_Tablename. Do it with role different than system administrator.
-Create a new DalBaseProcess that creates a row on the new table using DAL
-fill only the name
-Define the DalBAseProcess as background process for client different than system
-When saving the documentno column should be filled automatically with the value of the sequence created.
*That does not work becuase the client is not obtained.
This happens because when trying to get the client the following method is used:
String AD_Client_ID = getContext(con, vars, "AD_Client_ID", WindowNo);

ON getcontext method the client is obtained from a preference and if not fromthe httpsesson.
It is null for background processes.

Proposed Solution

Attached a posible solution

Tags

No tags attached.

client.diff [^] (842 bytes) 2014-03-04 17:13 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/utility/Utility.java b/src/org/openbravo/erpCommon/utility/Utility.java
--- a/src/org/openbravo/erpCommon/utility/Utility.java
+++ b/src/org/openbravo/erpCommon/utility/Utility.java
@@ -844,7 +844,10 @@
       String C_DocType_ID, boolean onlyDocType, boolean updateNext) {
     if (TableName == null || TableName.length() == 0)
       throw new IllegalArgumentException("Utility.getDocumentNo - required parameter missing");
-    final String AD_Client_ID = getContext(con, vars, "AD_Client_ID", WindowNo);
+    String AD_Client_ID = getContext(con, vars, "AD_Client_ID", WindowNo);
+    if ("".equals(AD_Client_ID)) {
+      AD_Client_ID = vars.getClient();
+    }
 
     final String cDocTypeID = (C_DocTypeTarget_ID.equals("") ? C_DocType_ID : C_DocTypeTarget_ID);
     if (cDocTypeID.equals(""))

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0064901) hgbot (developer) 2014-03-06 11:25	Repository: erp/devel/pi Changeset: 7b3a543035a290bed343af1cfe290312caf04664 Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Thu Mar 06 13:22:06 2014 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/7b3a543035a290bed343af1cfe290312caf04664 [^] Fixes Issue 0025899: In Utility.getDocumentNo the client is not obtained in some cases When invoking the method Utility.getDocumentNo from a DalBaseProcess the client is not obtained. In case client is not present in context, it is fetched from vars. --- M src/org/openbravo/erpCommon/utility/Utility.java ---

(0064908) AugustoMauch (manager) 2014-03-06 12:09	Code reviewed and verified in pi@7b3a543035a2

(0064944) hudsonbot (developer) 2014-03-07 05:25	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9364dd72aca6 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2014-03-04 17:13	egoitz	New Issue
2014-03-04 17:13	egoitz	Assigned To	=> AugustoMauch
2014-03-04 17:13	egoitz	File Added: client.diff
2014-03-04 17:13	egoitz	Modules	=> Core
2014-03-04 17:13	egoitz	Resolution time	=> 1394406000
2014-03-04 17:13	egoitz	Triggers an Emergency Pack	=> No
2014-03-05 13:03	alostale	Target Version	=> PR14Q2
2014-03-05 13:36	shankarb	Assigned To	AugustoMauch => shankarb
2014-03-06 08:01	shankarb	Status	new => scheduled
2014-03-06 08:01	shankarb	fix_in_branch	=> pi
2014-03-06 11:22	shankarb	Review Assigned To	=> AugustoMauch
2014-03-06 11:22	shankarb	fix_in_branch	pi =>
2014-03-06 11:22	shankarb	Issue Monitored: AugustoMauch
2014-03-06 11:24	hgbot	Checkin
2014-03-06 11:25	hgbot	Note Added: 0064901
2014-03-06 11:25	hgbot	Status	scheduled => resolved
2014-03-06 11:25	hgbot	Resolution	open => fixed
2014-03-06 11:25	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/7b3a543035a290bed343af1cfe290312caf04664 [^]
2014-03-06 12:09	AugustoMauch	Note Added: 0064908
2014-03-06 12:09	AugustoMauch	Status	resolved => closed
2014-03-06 12:09	AugustoMauch	Fixed in Version	=> PR14Q2
2014-03-07 05:25	hudsonbot	Checkin
2014-03-07 05:25	hudsonbot	Note Added: 0064944

Copyright © 2000 - 2009 MantisBT Group