0025718: Sales Orders button is not working on the Warehouse Picking List window

Description

The sales order pick and execute window is not showing records because of an error on its datasource.

The following exception is raised in the log after opening the window: "java.lang.ClassCastException: java.lang.String cannot be cast to org.openbravo.base.structure.BaseOBObject"

Steps To Reproduce

1) Create a sales order and book it
2) In the [Warehous Picking List] window, create a new header and click on the "Sales Orders" button
3) The sales order created in step 1 is not proposed

Proposed Solution

Use the BaseOBObject instead of the id String, for the query in the SelectOrderDS.java (Patch attached)

Tags

No tags attached.

Attached Files

25718.diff [^] (892 bytes) 2014-02-13 10:01 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/warehouse/pickinglist/SelectOrdersDS.java b/src/org/openbravo/warehouse/pickinglist/SelectOrdersDS.java
--- a/src/org/openbravo/warehouse/pickinglist/SelectOrdersDS.java
+++ b/src/org/openbravo/warehouse/pickinglist/SelectOrdersDS.java
@@ -86,7 +86,7 @@
     where.append("                 and p." + Product.PROPERTY_PRODUCTTYPE + " = 'I')");
     OBQuery<Order> qryOrder = OBDal.getInstance().createQuery(Order.class, where.toString());
     qryOrder.setNamedParameter("orgs", childOrgs);
-    qryOrder.setNamedParameter("warehouse", picking.getOutboundStorageBin().getWarehouse().getId());
+    qryOrder.setNamedParameter("warehouse", picking.getOutboundStorageBin().getWarehouse());
     qryOrder.setFilterOnReadableOrganization(false);
     List<Order> orders = qryOrder.list();
     List<Map<String, Object>> result = new ArrayList<Map<String, Object>>();

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0065056) hgbot (developer) 2014-03-11 17:48	Repository: erp/pmods/org.openbravo.warehouse.pickinglist Changeset: 7cad2ac0651931303c2a94a4afc6c8a119441b26 Author: Jon Alegría <jon.alegria <at> openbravo.com> Date: Tue Mar 11 17:48:41 2014 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/7cad2ac0651931303c2a94a4afc6c8a119441b26 [^] Fixes issue 0025718: Sales Orders button is not working on the Warehouse Picking List window --- M src/org/openbravo/warehouse/pickinglist/SelectOrdersDS.java ---

(0065379) caristu (manager) 2014-03-24 08:44	Verified

Issue History
Date Modified	Username	Field	Change
2014-02-13 09:50	caristu	New Issue
2014-02-13 09:50	caristu	Assigned To	=> naiaramartinez
2014-02-13 09:50	caristu	Issue Monitored: networkb
2014-02-13 10:01	caristu	File Added: 25718.diff
2014-03-11 17:48	hgbot	Checkin
2014-03-11 17:48	hgbot	Note Added: 0065056
2014-03-11 17:48	hgbot	Status	new => resolved
2014-03-11 17:48	hgbot	Resolution	open => fixed
2014-03-11 17:48	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/7cad2ac0651931303c2a94a4afc6c8a119441b26 [^]
2014-03-24 08:44	caristu	Review Assigned To	=> caristu
2014-03-24 08:44	caristu	Note Added: 0065379
2014-03-24 08:44	caristu	Status	resolved => closed