Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0025671
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2014-02-05 17:212014-03-21 15:59
ReportermaiteView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionef97a78cfebd
ProjectionnoneETAnoneTarget Version3.0PR14Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomaite
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025671: Wrong "Last Price" calculated when Discounts and Promotions found

DescriptionWrong "Last Price" calculated when Discounts and Promotions found
Steps To Reproduce1. Access "Discounts and Promotions" window and create new record of type "Price Adjustment". Set valid Starting Date, Included Products=Only those defined, Discount Amount=1 and define any product in "Products" tab
2. Access "Sales Order" window and create new record for any partner. Add line using previous product and realize that discount is applied. Process order.
3. Register new Sales Order header for same Business Partner. Run "Copy Lines" process and verify that line of your product is not showing proper "Last Price"(but it is showing price without apply price adjustment)
Proposed SolutionProblem is that "select" method of CopyFromOrder_data.xsql file is using database procedure "M_GET_OFFERS_PRICE" for LASTPRICESO calculation. But "M_GET_OFFERS_PRICE" is a deprecated function:

DEPRECATED!
This function should not be used. Promotions are calcualted by M_Promotion_Calculate when posting orders/invoices.

Proper function should be used instead of "M_GET_OFFERS_PRICE"
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00281773.0PR15Q2 closedAtulOpenbravo "Copy Lines" process is recalculating "lastpriceso" using "pricestd" instead of "lastpriceso" 

-  Notes
(0064973)
AtulOpenbravo (developer)
2014-03-10 06:40

Test Plan
- Navigate to "Discounts and Promotions" window. Create new record of type "Price Adjustment". Set valid Starting Date, Included Products=Only those defined, Discount Amount=1 and define any product in "Products" tab
- Navigate to "Sales Order" window and create new record for any partner. Add line using previous product and realize that discount is applied. Process order.
- Create a Sales Order header for same Business Partner. Run "Copy Lines" process and verify that line of your product is showing proper "Last Price". It shows price that is after applying the discount and promotions on Net List Price of the selected line.
(0065324)
hgbot (developer)
2014-03-21 06:21

Repository: erp/devel/pi
Changeset: ef97a78cfebd2f900acd19d13eed387ce311c67e
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Mar 11 22:41:37 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ef97a78cfebd2f900acd19d13eed387ce311c67e [^]

Fixes Issue 25671 Wrong "Last Price" calculated when Discounts and Promotions.

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.java
---
(0065335)
maite (developer)
2014-03-21 09:07

verified
(0065364)
hudsonbot (developer)
2014-03-21 15:59

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e18c6c3d258e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-02-05 17:21 maite New Issue
2014-02-05 17:21 maite Assigned To => dmiguelez
2014-02-05 17:21 maite Modules => Core
2014-02-05 17:21 maite Triggers an Emergency Pack => No
2014-02-05 17:22 maite Target Version => 3.0MP33
2014-02-05 17:23 maite Issue Monitored: networkb
2014-02-14 13:30 dmiguelez Assigned To dmiguelez => jonalegriaesarte
2014-02-19 13:05 jonalegriaesarte Assigned To jonalegriaesarte => pramakrishnan
2014-02-27 05:54 AtulOpenbravo Assigned To pramakrishnan => AtulOpenbravo
2014-02-27 05:54 AtulOpenbravo Status new => scheduled
2014-02-27 05:54 AtulOpenbravo fix_in_branch => pi
2014-03-10 06:40 AtulOpenbravo Note Added: 0064973
2014-03-11 12:57 jonalegriaesarte Resolution time => 1394838000
2014-03-11 12:57 jonalegriaesarte fix_in_branch pi =>
2014-03-17 14:19 jonalegriaesarte Target Version PR14Q3 => PR14Q2
2014-03-21 06:15 AtulOpenbravo Review Assigned To => maite
2014-03-21 06:21 hgbot Checkin
2014-03-21 06:21 hgbot Note Added: 0065324
2014-03-21 06:21 hgbot Status scheduled => resolved
2014-03-21 06:21 hgbot Resolution open => fixed
2014-03-21 06:21 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ef97a78cfebd2f900acd19d13eed387ce311c67e [^]
2014-03-21 09:07 maite Note Added: 0065335
2014-03-21 09:07 maite Status resolved => closed
2014-03-21 15:59 hudsonbot Checkin
2014-03-21 15:59 hudsonbot Note Added: 0065364
2014-11-14 11:07 maite Relationship added related to 0028177


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker