0025452: When documentNo is get in class POSUtils.java an exception is raised if OBPOS_ERRORS table has errors of type BP

Description

When documentNo is get in class POSUtils.java an exception is raised if OBPOS_ERRORS table has errors of type BP

It happend because BP errors doesn't have the field documentNo

exception raised:
org.codehaus.jettison.json.JSONException: JSONObject["documentNo"] not found.
    at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360)
    at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487)
    at org.openbravo.retail.posterminal.POSUtils.getLastDocumentNumberForPOS(POSUtils.java:346)
    at org.openbravo.retail.posterminal.term.Terminal.getQuery(Terminal.java:60)
    at org.openbravo.mobile.core.process.ProcessHQLQuery.exec(ProcessHQLQuery.java:63)
    at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:36)
    at org.openbravo.mobile.core.process.MobileService.execClassName(MobileService.java:154)
    at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:77)
    at org.openbravo.mobile.core.process.MobileService.doGet(MobileService.java:42)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:440)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:52)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:861)
    at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:606)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
    at java.lang.Thread.run(Thread.java:662)
org.codehaus.jettison.json.JSONException: JSONObject["documentNo"] not found.
    at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360)
    at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487)
    at org.openbravo.retail.posterminal.POSUtils.getLastDocumentNumberForPOS(POSUtils.java:346)
    at org.openbravo.retail.posterminal.POSUtils.getLastDocumentNumberForPOS(POSUtils.java:365)
    at org.openbravo.retail.posterminal.term.Terminal.getQuery(Terminal.java:64)
    at org.openbravo.mobile.core.process.ProcessHQLQuery.exec(ProcessHQLQuery.java:63)
    at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:36)
    at org.openbravo.mobile.core.process.MobileService.execClassName(MobileService.java:154)
    at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:77)
    at org.openbravo.mobile.core.process.MobileService.doGet(MobileService.java:42)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:440)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:52)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:861)
    at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:606)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
    at java.lang.Thread.run(Thread.java:662)

Steps To Reproduce

PRE: having an error of BP in the OBPOS_ERRORS table
1. login
2. An exception is raised

The login is working fine but an exception is raised. If it happens a wrong docuemnt number could be selected.

Proposed Solution

Add a new condition to the query

    // This number will be compared against the maximum number of the failed orders
    OBCriteria<OBPOSErrors> errorCrit = OBDal.getInstance().createCriteria(OBPOSErrors.class);
    errorCrit.add(Restrictions.eq(OBPOSErrors.PROPERTY_OBPOSAPPLICATIONS, terminal));
++ errorCrit.add(Restrictions.eq(OBPOSErrors.PROPERTY_TYPEOFDATA, "order"));

Notes
(0063336) hgbot (developer) 2014-01-09 11:18	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 16364be0a78e4b67127a14aa7d95c369a9ecf4fc Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu Jan 09 11:18:27 2014 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/16364be0a78e4b67127a14aa7d95c369a9ecf4fc [^] fixed issue 25452: get Doc number will not fail ir there are BP in obpos_errors table --- M src/org/openbravo/retail/posterminal/POSUtils.java ---

(0063417) hgbot (developer) 2014-01-15 14:46	Repository: erp/pmods/org.openbravo.retail.posterminal.cirque Changeset: 16364be0a78e4b67127a14aa7d95c369a9ecf4fc Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu Jan 09 11:18:27 2014 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/16364be0a78e4b67127a14aa7d95c369a9ecf4fc [^] fixed issue 25452: get Doc number will not fail ir there are BP in obpos_errors table --- M src/org/openbravo/retail/posterminal/POSUtils.java ---

(0063530) malsasua (viewer) 2014-01-20 09:45	tested

Issue History
Date Modified	Username	Field	Change
2014-01-09 11:17	guilleaer	New Issue
2014-01-09 11:17	guilleaer	Assigned To	=> guilleaer
2014-01-09 11:17	guilleaer	OBNetwork customer	=> No
2014-01-09 11:17	guilleaer	Triggers an Emergency Pack	=> No
2014-01-09 11:18	hgbot	Checkin
2014-01-09 11:18	hgbot	Note Added: 0063336
2014-01-09 11:18	hgbot	Status	new => resolved
2014-01-09 11:18	hgbot	Resolution	open => fixed
2014-01-09 11:18	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/16364be0a78e4b67127a14aa7d95c369a9ecf4fc [^]
2014-01-15 14:46	hgbot	Checkin
2014-01-15 14:46	hgbot	Note Added: 0063417
2014-01-15 14:46	hgbot	Fixed in SCM revision	http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/16364be0a78e4b67127a14aa7d95c369a9ecf4fc [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cirque/rev/16364be0a78e4b67127a14aa7d95c369a9ecf4fc [^]
2014-01-20 09:45	malsasua	Review Assigned To	=> malsasua
2014-01-20 09:45	malsasua	Note Added: 0063530
2014-01-20 09:45	malsasua	Status	resolved => closed
2014-01-20 09:45	malsasua	Fixed in Version	=> RMP31

Relationships [ Relation Graph ] [ Dependency Graph ]