Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0025310
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorrandom2013-12-11 16:522014-03-24 12:09
ReporteregoitzView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR14Q2
StatusclosedFix in branchFixed in SCM revision530197ef5760
ProjectionnoneETAnoneTarget Version3.0PR14Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025310: Java processes locked on tomcat

DescriptionWhen login to the server from a pos terminal, on some cases there are some locks that causes processes being using 100% of a cpu.
They never finish and it is needed to restart tomcat.
Steps To Reproduce-Login with different users to pos terminal
*Attached yo can find a stack trace with some lock processes.

Editing the file
src/org/openbravo/dal/security/EntityAccessChecker.java
by replacing
public void initialize() {
with
public synchronized void initialize() {
solves the problem but this is a workarround and not a final solution.
TagsNo tags attached.
Attached Filestxt file icon jstack-2013-10-08_13.07.07.txt [^] (50,680 bytes) 2013-12-11 16:52 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00244213.0MP28 closedalostale ApplicationDictionaryCachedStructures is not thread safe 

-  Notes
(0065349)
alostale (manager)
2014-03-21 10:52

 The problem seen in the attached stack trace occurs if more than one thread with the same session are concurrently executed, the 2nd one is launched while the 1st one is initializing access checker, it is detected as not initialized and starts parallel initialization. In this situation, it is possible both threads to be concurrently modifying not syncrhonized Maps causing this problem.

Proposed solution is going to be applied. Making init method synchronized should not cause performance degradation problems as it should executed just once per context session so not much concurrency should happen at this point.
(0065350)
hgbot (developer)
2014-03-21 10:57

 Repository: erp/devel/pi
Changeset: 530197ef5760542451747fd554e0cd613c3837f5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 21 10:56:40 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/530197ef5760542451747fd554e0cd613c3837f5 [^]

fixed bug 25310: EntityAccessChecker can be locked by concurrent rquests

 Making initialize method synchronized prevents this problem, this is the only
 method modifying internal variables which are not synchronized.

---
M src/org/openbravo/dal/security/EntityAccessChecker.java
---
(0065374)
hudsonbot (developer)
2014-03-22 04:14

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b70224bef848 [^]
Maturity status: Test
(0065389)
shankarb (reporter)
2014-03-24 12:09

 Code reviewed and verified in pi changeset b24d8a94df0e.

- Issue History
Date Modified Username Field Change
2013-12-11 16:52 egoitz New Issue
2013-12-11 16:52 egoitz Assigned To => AugustoMauch
2013-12-11 16:52 egoitz File Added: jstack-2013-10-08_13.07.07.txt
2013-12-11 16:52 egoitz Modules => Core
2013-12-11 16:52 egoitz Resolution time => 1358204400
2013-12-11 16:52 egoitz Triggers an Emergency Pack => No
2014-01-24 08:45 alostale Assigned To AugustoMauch => alostale
2014-03-12 10:42 jonalegriaesarte Resolution time 1358204400 => 1363302000
2014-03-21 10:48 alostale Relationship added related to 0024421
2014-03-21 10:52 alostale Note Added: 0065349
2014-03-21 10:52 alostale Review Assigned To => shankarb
2014-03-21 10:57 hgbot Checkin
2014-03-21 10:57 hgbot Note Added: 0065350
2014-03-21 10:57 hgbot Status new => resolved
2014-03-21 10:57 hgbot Resolution open => fixed
2014-03-21 10:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/530197ef5760542451747fd554e0cd613c3837f5 [^]
2014-03-22 04:14 hudsonbot Checkin
2014-03-22 04:14 hudsonbot Note Added: 0065374
2014-03-24 12:09 shankarb Note Added: 0065389
2014-03-24 12:09 shankarb Status resolved => closed
2014-03-24 12:09 shankarb Fixed in Version => PR14Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker