Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0025130 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | always | 2013-11-12 02:21 | 2013-11-19 19:07 | |||
| Reporter | dbaz | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP30 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | dc863e6e11e3 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | shankarb | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0025130: Java error if no record indentifier is defined in the parent record | |||||||
| Description | Java error if no record indentifier is defined in the parent record: If you define a parent/child window structure, and you don't define a record indentifier in the parent, you get an ugly java error in the backend that doesn't let you know at all where the error could be. | |||||||
| Steps To Reproduce | Create two new tables (father and child). Set both tables in "Tables and Columns" and in "Windows Tabs and Fields". It is important that you don't set any field as "Record Identifier" (in the 'Column' tab) Create a new entry in "Menu" window to be able to navigate to the created window Do "ant smartbuild" Go to the created window. Create a father/header Create a child/line Notice that it seems like the child/line form doesn't finish to load. There is a Java error in the backend like: ERROR org.openbravo.erpCommon.utility.ComboTableData - Error of SQL in query: SELECT td0.Obuiapp_Grid_Configuration_ID AS ID, , '' AS DESCRIPTION FROM Obuiapp_Grid_Configuration td0 WHERE td0.AD_Client_ID IN ('0','0') AND td0.AD_Org_ID IN ('0') AND (td0.isActive = 'Y' OR td0.Obuiapp_Grid_Configuration_ID = (?) ) ORDER BY 2Exception:org.postgresql.util.PSQLException: ERROR: error de sintaxis en o cerca de «,» Position: 49 b3e0edee 97748 [http-8880-4] ERROR org.openbravo.base.exception.OBException - Error while computing combo data java.lang.Exception: @CODE=0@ERROR: error de sintaxis en o cerca de «,» Position: 49 at org.openbravo.erpCommon.utility.ComboTableData.select(ComboTableData.java:1102) at org.openbravo.client.kernel.reference.UIDefinition.getValueInComboReference(UIDefinition.java:473) at org.openbravo.client.kernel.reference.FKComboUIDefinition.getFieldProperties(FKComboUIDefinition.java:101) ... | |||||||
| Proposed Solution | Avoid this Java error and show in the client something that points the user/developer that something has failed. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0062075) dbaz (viewer) 2013-11-12 02:37 |
With the solution, the java console will show an error like: "Foreign table referenced by 'whatever' does not have 'Record Identifier' defined" and also, the UI will not be blocked: the combo will be filled with ">>No Record Identifier<<" lines |
|
(0062076) hgbot (developer) 2013-11-12 02:41 |
Repository: erp/devel/pi Changeset: dc863e6e11e31739d4e4fbbb831d91418fe48d64 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Tue Nov 12 02:41:00 2013 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/dc863e6e11e31739d4e4fbbb831d91418fe48d64 [^] Fixed issue 25130: Proper message if there is no 'Record Identifier' defined in the parent window of any window. Before this fix, an exception was thrown in the console, and the UI rendered an incomplete form impossible to be filled --- M src/org/openbravo/erpCommon/utility/ComboTableData.java --- |
|
(0062085) shankarb (viewer) 2013-11-12 11:32 |
Code reviewed and verified in pi changeset e3a8f5f3ca3b. |
|
(0062251) hudsonbot (viewer) 2013-11-19 19:07 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ab71e0273dc1 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-11-12 02:21 | dbaz | New Issue | |
| 2013-11-12 02:21 | dbaz | Assigned To | => dbaz |
| 2013-11-12 02:21 | dbaz | Modules | => Core |
| 2013-11-12 02:21 | dbaz | OBNetwork customer | => No |
| 2013-11-12 02:21 | dbaz | Triggers an Emergency Pack | => No |
| 2013-11-12 02:36 | dbaz | Review Assigned To | => shankarb |
| 2013-11-12 02:36 | dbaz | Issue Monitored: shankarb | |
| 2013-11-12 02:37 | dbaz | Note Added: 0062075 | |
| 2013-11-12 02:41 | hgbot | Checkin | |
| 2013-11-12 02:41 | hgbot | Note Added: 0062076 | |
| 2013-11-12 02:41 | hgbot | Status | new => resolved |
| 2013-11-12 02:41 | hgbot | Resolution | open => fixed |
| 2013-11-12 02:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/dc863e6e11e31739d4e4fbbb831d91418fe48d64 [^] |
| 2013-11-12 11:32 | shankarb | Note Added: 0062085 | |
| 2013-11-12 11:32 | shankarb | Status | resolved => closed |
| 2013-11-12 11:32 | shankarb | Fixed in Version | => 3.0MP30 |
| 2013-11-19 19:07 | hudsonbot | Checkin | |
| 2013-11-19 19:07 | hudsonbot | Note Added: 0062251 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |