Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0025015
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2013-10-24 22:252013-11-19 19:07
ReporteregoitzView Statuspublic 
Assigned Tomtaal 
PriorityurgentResolutionfixedFixed in Version3.0MP30
StatusclosedFix in branchFixed in SCM revision900483c4a614
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket24213
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025015: Many instances of WidgetClass consuming tomcat memory

DescriptionAfter some time using the application thousand of instances of WidgetClass are located on the memory.
Steps To Reproduce-Take a memory dump of an application being used during several days.
-See on the dump using MAT that there are thousands of instances of WidgetClass
TagsPerformance
Attached Filesdiff file icon 25015.diff [^] (820 bytes) 2013-11-05 00:32 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0062021)
mtaal (viewer)
2013-11-05 00:37

 To reproduce test, add the following lines to the DataSourceComponent.

  public DataSourceComponent() {
    System.err.println("Creating " + getClass().getName());
  }

  protected void finalize() {
    System.err.println("Finalizing " + getClass().getName());
  }

And add the following line to a place which is being called often, for example in KernelServlet.service:
System.gc()

Without the diff you see only creating datasourcecomponent lines. With the diff you see also finalizing printlns.
(0062031)
hgbot (developer)
2013-11-05 17:37

 Repository: erp/devel/pi
Changeset: d152fbd22bdd2f20b8ea4377fbef386464788b9b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Nov 05 10:50:44 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d152fbd22bdd2f20b8ea4377fbef386464788b9b [^]

Fixes issue 25015: Many instances of WidgetClass consuming tomcat memory
The ComponentProviders are applicationscoped, this ment that the member instances and its references were maintained throughout the lifetime of the application. Causing each time a new component being created and stored there. The change creates a new instance dynamically all the time.

---
M .project
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponentProvider.java
---
(0062032)
hgbot (developer)
2013-11-05 17:43

 Repository: erp/devel/pi
Changeset: 900483c4a614c3afef408e7b61d7dbe7b7a5437c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Nov 05 17:42:51 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/900483c4a614c3afef408e7b61d7dbe7b7a5437c [^]

Fixes issue 25015: Many instances of WidgetClass consuming tomcat memory
The ComponentProviders are applicationscoped, this ment that the member instances and its references were maintained throughout the lifetime of the application. Causing each time a new component being created and stored there. The change creates a new instance dynamically all the time.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/BaseComponentProvider.java
---
(0062123)
AugustoMauch (administrator)
2013-11-13 12:28

 Code reviewed and verified in pi@fceec837bb81
(0062235)
hudsonbot (viewer)
2013-11-19 19:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ab71e0273dc1 [^]

Maturity status: Test
(0062236)
hudsonbot (viewer)
2013-11-19 19:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ab71e0273dc1 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-10-24 22:25 egoitz New Issue
2013-10-24 22:25 egoitz Assigned To => mtaal
2013-10-24 22:25 egoitz Modules => Core
2013-10-24 22:25 egoitz OBNetwork customer => Yes
2013-10-24 22:25 egoitz Support ticket => 24213
2013-10-24 22:25 egoitz Resolution time => 1384470000
2013-10-24 22:25 egoitz Triggers an Emergency Pack => No
2013-10-24 23:09 egoitz Tag Attached: Performance
2013-10-25 00:11 shuehner Issue Monitored: shuehner
2013-10-31 19:27 johnfandl Issue Monitored: johnfandl
2013-11-05 00:32 mtaal File Added: 25015.diff
2013-11-05 00:37 mtaal Note Added: 0062021
2013-11-05 17:37 mtaal Review Assigned To => AugustoMauch
2013-11-05 17:37 hgbot Checkin
2013-11-05 17:37 hgbot Note Added: 0062031
2013-11-05 17:37 hgbot Status new => resolved
2013-11-05 17:37 hgbot Resolution open => fixed
2013-11-05 17:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d152fbd22bdd2f20b8ea4377fbef386464788b9b [^]
2013-11-05 17:43 hgbot Checkin
2013-11-05 17:43 hgbot Note Added: 0062032
2013-11-05 17:43 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/d152fbd22bdd2f20b8ea4377fbef386464788b9b [^] => http://code.openbravo.com/erp/devel/pi/rev/900483c4a614c3afef408e7b61d7dbe7b7a5437c [^]
2013-11-13 12:28 AugustoMauch Note Added: 0062123
2013-11-13 12:28 AugustoMauch Status resolved => closed
2013-11-13 12:28 AugustoMauch Fixed in Version => 3.0MP31
2013-11-13 12:33 AugustoMauch Fixed in Version 3.0MP31 => 3.0MP30
2013-11-19 19:07 hudsonbot Checkin
2013-11-19 19:07 hudsonbot Note Added: 0062235
2013-11-19 19:07 hudsonbot Checkin
2013-11-19 19:07 hudsonbot Note Added: 0062236

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker