Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024924
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorsometimes2013-10-10 13:022013-10-16 19:46
ReporterplujanView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0MP29
StatusclosedFix in branchFixed in SCM revision2b5c09bed087
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browserGoogle Chrome
ModulesCore
Regression levelQA functional test
Regression date2013-09-11
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Triggers an Emergency PackNo
Summary

0024924: Combining grid and row record editions generate an error on a filtered grid

DescriptionWhile working in a filtered grid, if I try to save a record in form view and later in grid view, I get an StaleObjectException. See steps.
Steps To Reproduce1. Login as Openbravo user (F&B admin)
2. Open Unit of Measure window
3. Create on Form two new records: QA-Test1 and QA-Test2
4. On Grid, filter name="QA" to get the two recently created QA-* values
5. Click the Edit in Form icon for the first record. It will open the QA-Test1 in Form
6. Change name to QA-Test1-1 and save
7. Close the form to return to Grid view. Check the value has no changed.
8. Edit record in Grid mode. When saving, you get an error and a Exception in the log. (See attached screenshot)

Exception thrown is:
org.openbravo.service.json.OBStaleObjectException: @OBJSON_StaleDate@
    at org.openbravo.service.json.JsonToDataConverter.setData(JsonToDataConverter.java:386)
    at org.openbravo.service.json.JsonToDataConverter.toBaseOBObject(JsonToDataConverter.java:353)
    at org.openbravo.service.json.DefaultJsonDataService.update(DefaultJsonDataService.java:607)
    at org.openbravo.service.datasource.DefaultDataSourceService.update(DefaultDataSourceService.java:178)
    at org.openbravo.service.datasource.DataSourceServlet.doPut(DataSourceServlet.java:746)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:640)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:440)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:63)
    at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:138)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    at org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:448)
    at org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:399)
    at org.apache.tomcat.util.net.AprEndpoint$Worker.run(AprEndpoint.java:1675)
    at java.lang.Thread.run(Thread.java:679)
TagsNo tags attached.
Attached Filesjpg file icon ErrorSavingRecord.jpg [^] (67,165 bytes) 2013-10-10 13:02

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0061649)
hgbot (developer)
2013-10-10 17:42

 Repository: erp/devel/pi
Changeset: 2b5c09bed08793caa2a4d64778de24e5daac658c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Oct 10 17:41:32 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2b5c09bed08793caa2a4d64778de24e5daac658c [^]

Fixes issue 24924: Changes are applied to the grid with adaptive filtering

When a record was updated in form view with the record filtered using adaptive filtering, the changes were not being applied to the grid. This happened because the changes were being applied to the allRows property of the ResultSet, but not to the localData property, which is what contains the data of the filtered records.

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0061650)
hgbot (developer)
2013-10-11 10:00

 Repository: erp/devel/pi
Changeset: df0dea56e2c80b949068327607975ebb5ed71d65
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Oct 11 09:59:28 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/df0dea56e2c80b949068327607975ebb5ed71d65 [^]

Related to issue 24924: Fixes integration test failure

Fixes this integration test failure [1]. A change from null to empty String, which should not have been detected as a change, caused the editColumnValues property of the selected record to be lost. This has been fixed by not considering the change from null to empty String as a change.




[1] http://builds.openbravo.com/job/int-gui-oracle/1271/ [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0061653)
shankarb (reporter)
2013-10-14 05:39

 Code reviewed and verified in pi changeset df0dea56e2c8.
(0061745)
hudsonbot (developer)
2013-10-16 19:46

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^]

Maturity status: Test
(0061746)
hudsonbot (developer)
2013-10-16 19:46

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-10-10 13:02 plujan New Issue
2013-10-10 13:02 plujan Assigned To => AugustoMauch
2013-10-10 13:02 plujan File Added: ErrorSavingRecord.jpg
2013-10-10 13:02 plujan Web browser => Google Chrome
2013-10-10 13:02 plujan Modules => Core
2013-10-10 13:02 plujan Triggers an Emergency Pack => No
2013-10-10 13:03 plujan Web browser Google Chrome => Google Chrome
2013-10-10 13:03 plujan Regression level => QA functional test
2013-10-10 14:04 AugustoMauch Web browser Google Chrome => Google Chrome
2013-10-10 14:04 AugustoMauch Regression date => 2013-09-11
2013-10-10 14:04 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
2013-10-10 17:38 AugustoMauch Issue Monitored: shankarb
2013-10-10 17:39 AugustoMauch Review Assigned To => shankarb
2013-10-10 17:39 AugustoMauch Web browser Google Chrome => Google Chrome
2013-10-10 17:42 hgbot Checkin
2013-10-10 17:42 hgbot Note Added: 0061649
2013-10-10 17:42 hgbot Status new => resolved
2013-10-10 17:42 hgbot Resolution open => fixed
2013-10-10 17:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2b5c09bed08793caa2a4d64778de24e5daac658c [^]
2013-10-11 10:00 hgbot Checkin
2013-10-11 10:00 hgbot Note Added: 0061650
2013-10-14 05:39 shankarb Note Added: 0061653
2013-10-14 05:39 shankarb Status resolved => closed
2013-10-14 05:39 shankarb Fixed in Version => 3.0MP29
2013-10-16 19:46 hudsonbot Checkin
2013-10-16 19:46 hudsonbot Note Added: 0061745
2013-10-16 19:46 hudsonbot Checkin
2013-10-16 19:46 hudsonbot Note Added: 0061746

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker