Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0024919 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | major | have not tried | 2013-10-09 19:38 | 2013-10-16 19:46 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 1da36fb5ddbe | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | dmiguelez | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0024919: AccountingServer.checkDocuments is too slow and repeats same work multiple times | |||||||
| Description | The BackgroundAccountingProcess is running checkDocumentsDates method for each client to find out if there are any documents in open periods to be posted. That check is done for each docbasetype in a client. However docbasetype are defined on organization level. In practice (i.e. F&B) that means the same docbasetype code exists several times in a client so the check is unnecessarily repeated multiple times. | |||||||
| Steps To Reproduce | fresh install.source of pi on oracle (as there the queries involved are slower) Instrument the selectDocumentsDates xsql method (or AcctServerData class) with info about docbasetype and notice that it gets called multiple times for the same docbasetype. | |||||||
| Proposed Solution | Add distinct to selectDocTypes method to only report every docbasetype once. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0061641) hgbot (developer) 2013-10-09 19:46 |
Repository: erp/devel/pi Changeset: 1da36fb5ddbe739d316cd1a65088f3b4604dd265 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Wed Oct 09 19:43:59 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1da36fb5ddbe739d316cd1a65088f3b4604dd265 [^] Fixed 24919: Speedup AcctServer.checkDocuments Avoid checking same docbasetype several times by only doing check for distinct docbasetype values thus skipping duplicates which happen as docbasetypes are defined per organization. --- M src/org/openbravo/erpCommon/ad_forms/AcctServer_data.xsql --- |
|
(0061642) hgbot (developer) 2013-10-09 19:46 |
Repository: erp/devel/pi Changeset: e721f9bcbfc12aba39c46e660d0efc03bf31c8b3 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Wed Oct 09 19:45:30 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e721f9bcbfc12aba39c46e660d0efc03bf31c8b3 [^] Issue 24919: Small code-cleanup Delete unused (non-public) selectDocuments methods in xsql file to make it obvious that the method is not used. --- M src/org/openbravo/erpCommon/ad_forms/AcctServer_data.xsql --- |
|
(0061646) dmiguelez (viewer) 2013-10-10 10:22 |
Code Review + Testing Ok |
|
(0061741) hudsonbot (viewer) 2013-10-16 19:46 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^] Maturity status: Test |
|
(0061742) hudsonbot (viewer) 2013-10-16 19:46 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-10-09 19:38 | shuehner | New Issue | |
| 2013-10-09 19:38 | shuehner | Assigned To | => shuehner |
| 2013-10-09 19:38 | shuehner | Modules | => Core |
| 2013-10-09 19:38 | shuehner | OBNetwork customer | => No |
| 2013-10-09 19:38 | shuehner | Triggers an Emergency Pack | => No |
| 2013-10-09 19:46 | hgbot | Checkin | |
| 2013-10-09 19:46 | hgbot | Note Added: 0061641 | |
| 2013-10-09 19:46 | hgbot | Status | new => resolved |
| 2013-10-09 19:46 | hgbot | Resolution | open => fixed |
| 2013-10-09 19:46 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/1da36fb5ddbe739d316cd1a65088f3b4604dd265 [^] |
| 2013-10-09 19:46 | hgbot | Checkin | |
| 2013-10-09 19:46 | hgbot | Note Added: 0061642 | |
| 2013-10-09 19:47 | shuehner | Review Assigned To | => dmiguelez |
| 2013-10-09 19:58 | shuehner | Relationship added | related to 0024920 |
| 2013-10-10 10:22 | dmiguelez | Note Added: 0061646 | |
| 2013-10-10 10:22 | dmiguelez | Status | resolved => closed |
| 2013-10-16 19:46 | hudsonbot | Checkin | |
| 2013-10-16 19:46 | hudsonbot | Note Added: 0061741 | |
| 2013-10-16 19:46 | hudsonbot | Checkin | |
| 2013-10-16 19:46 | hudsonbot | Note Added: 0061742 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |