Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024549
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2013-08-20 13:302013-08-21 18:59
ReportervmromanosView Statuspublic 
Assigned Tovmromanos 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisionb09efdf35533
ProjectionnoneETAnoneTarget Version3.0MP27
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_12
OS VersionDebian 5.0Database version8.3.8Ant version1.7.0
Product VersionpiSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024549: Regular expression errors when sending emails

DescriptionIn case the data replacing the report template tags (@cus_ref@, @our_ref@, @cus_nam@, @sal_nam@, @bp_nam@, @doc_date@, @doc_desc@, @doc_nextduedate@ and @doc_lastduedate@) contains backslashes '\' or dollar signs '$', the regular expression replacement done when sending the email may result in a regular expression error that avoids to send the email.

See http://docs.oracle.com/javase/6/docs/api/java/lang/String.html#replaceAll [^](java.lang.String, java.lang.String)
Steps To Reproduce1. Select any sales invoice
2. Browse to the user/contact and replace the first and last name by $mith
3. Ensure the template contains the @cus_nam@ tag in either the subject or the body
4. Try to send the invoice by email. An error is displayed
Proposed SolutionUse Matcher.quoteReplacement(java.lang.String) to suppress the special meaning of these characters ($, \)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 00245323.0MP27 closedvmromanos Support more variables (tags) when sending emails 

-  Notes
(0060682)
hgbot (developer)
2013-08-20 13:37

 Repository: erp/devel/pi
Changeset: b09efdf35533f0e742f97157adce20338752ade6
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Aug 20 13:36:57 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b09efdf35533f0e742f97157adce20338752ade6 [^]

Fixed bug 24549: Regular expression errors when sending emails

Use Matcher.quoteReplacement(java.lang.String) to suppress the special meaning of characters: '$' and '\'

---
M src/org/openbravo/erpCommon/utility/reporting/Report.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0060709)
dmiguelez (viewer)
2013-08-21 13:16

 Code Review + Testing Ok
(0060717)
hudsonbot (viewer)
2013-08-21 18:59

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5a759279dc34 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-08-20 13:30 vmromanos New Issue
2013-08-20 13:30 vmromanos Assigned To => vmromanos
2013-08-20 13:30 vmromanos Modules => Core
2013-08-20 13:30 vmromanos OBNetwork customer => No
2013-08-20 13:30 vmromanos Triggers an Emergency Pack => No
2013-08-20 13:31 vmromanos Relationship added related to 0024532
2013-08-20 13:31 vmromanos Status new => scheduled
2013-08-20 13:31 vmromanos fix_in_branch => pi
2013-08-20 13:37 hgbot Checkin
2013-08-20 13:37 hgbot Note Added: 0060682
2013-08-20 13:37 hgbot Status scheduled => resolved
2013-08-20 13:37 hgbot Resolution open => fixed
2013-08-20 13:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b09efdf35533f0e742f97157adce20338752ade6 [^]
2013-08-21 13:16 dmiguelez Review Assigned To => dmiguelez
2013-08-21 13:16 dmiguelez Note Added: 0060709
2013-08-21 13:16 dmiguelez Status resolved => closed
2013-08-21 18:59 hudsonbot Checkin
2013-08-21 18:59 hudsonbot Note Added: 0060717

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker