Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0024390 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2013-07-22 12:47 | 2013-07-28 03:08 | |||
| Reporter | egoitz | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0MP26 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 7050a4c8d664 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | shankarb | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0024390: The preferences defined with a role differente than system administrator shouldn't be exported | |||||||
| Description | The preferences defined with a role different than system administrator shouldn't be exported. If you define a preference with a role different than system administration and you define a module when defining the preference, this is exported when executing export.database with the module selected as indevelopment. | |||||||
| Steps To Reproduce | -Define a new module and check as indevelopment -Access with a different role than system administrator. -Define a new preference -Select the module created -Export with export.database *Check that the preference has been exported but the ad_client_id and ad_org_id are differente than System (0). | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0060225) hgbot (developer) 2013-07-24 12:01 |
Repository: erp/devel/pi Changeset: 7050a4c8d6649425fec6e2db60a26a5ddb3f98fc Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Jul 24 11:41:06 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/7050a4c8d6649425fec6e2db60a26a5ddb3f98fc [^] Fixes issue 24390: Only System Admin can define the module of preferences Only the role System Admin should be able to define the ad_module_id column of the preferences (only the preferences with ad_module_id defined can be exported). This has been achieved by making that field visible only for that user (by default that field is always empty). A server side check is not going to be done, because it is risky and it could result in proper preferences not being exported. To fix the preference data of existing faulty preferences (preferences defined by a role other than system admin with invalid visibleat_role_id, visibleat_client_id or visibleat_org_id values) this query could be executed: update ad_preference set ad_module_id = null where (visibleat_role_id is not null and visibleat_role_id != '0') or (visibleat_client_id is not null and visibleat_client_id != '0') or (visibleat_org_id is not null and visibleat_org_id != '0') --- M src-db/database/sourcedata/AD_FIELD.xml --- |
|
(0060295) hudsonbot (developer) 2013-07-24 21:31 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/965b32a20794 [^] Maturity status: Test |
|
(0060320) shankarb (reporter) 2013-07-28 03:08 |
Code reviewed and verified in pi changeset f49b9428b38d |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-07-22 12:47 | egoitz | New Issue | |
| 2013-07-22 12:47 | egoitz | Assigned To | => AugustoMauch |
| 2013-07-22 12:47 | egoitz | Modules | => Core |
| 2013-07-22 12:47 | egoitz | Resolution time | => 1376085600 |
| 2013-07-22 12:47 | egoitz | Triggers an Emergency Pack | => No |
| 2013-07-24 12:00 | AugustoMauch | Issue Monitored: shankarb | |
| 2013-07-24 12:00 | AugustoMauch | Review Assigned To | => shankarb |
| 2013-07-24 12:01 | hgbot | Checkin | |
| 2013-07-24 12:01 | hgbot | Note Added: 0060225 | |
| 2013-07-24 12:01 | hgbot | Status | new => resolved |
| 2013-07-24 12:01 | hgbot | Resolution | open => fixed |
| 2013-07-24 12:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/7050a4c8d6649425fec6e2db60a26a5ddb3f98fc [^] |
| 2013-07-24 21:31 | hudsonbot | Checkin | |
| 2013-07-24 21:31 | hudsonbot | Note Added: 0060295 | |
| 2013-07-28 03:08 | shankarb | Note Added: 0060320 | |
| 2013-07-28 03:08 | shankarb | Status | resolved => closed |
| 2013-07-28 03:08 | shankarb | Fixed in Version | => 3.0MP26 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |