Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0024281 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2013-07-08 09:32 | 2013-07-29 11:05 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | shankarb | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP26 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 12bb1c5af3e1 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | main | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0024281: Window, Tab, Field: if clientclass is set then neither column or property should be mandatory | |||||||
| Description | See this howto: http://wiki.openbravo.com/wiki/How_to_add_a_canvas_field_to_a_Form_or_Grid#Defining_the_canvas_in_the_Tab-Field_.28ADField.29 [^] In this case the property/column should not be mandatory, currently it is. Probably this was introduced when property fields were introduced | |||||||
| Steps To Reproduce | Create a new field, or change a current one Clear the property/column fields Enter a value in clientclass Save --> error is shown, it should be fine See the attached screenshot | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Selection_004.png [^] (24,172 bytes) 2013-07-08 09:32
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0059911) mtaal (viewer) 2013-07-08 11:48 |
Here is the stacktrace from the console, the change should probably be made in the FieldHandler class. 886963 [http-8080-3] ERROR org.openbravo.service.json.DefaultJsonDataService - if property is not set then column must be set org.openbravo.base.exception.OBException: if property is not set then column must be set at org.openbravo.client.application.event.FieldHandler.setColumn(FieldHandler.java:76) at org.openbravo.client.application.event.FieldHandler.onUpdate(FieldHandler.java:52) at sun.reflect.GeneratedMethodAccessor773.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:305) at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:54) at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:163) at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:299) at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:188) at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:59) at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:198) at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:282) at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:265) at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:234) at org.jboss.weld.manager.BeanManagerImpl.notifyObservers(BeanManagerImpl.java:632) at org.jboss.weld.manager.BeanManagerImpl.fireEvent(BeanManagerImpl.java:625) at org.jboss.weld.event.EventImpl.fire(EventImpl.java:75) at org.openbravo.client.kernel.event.PersistenceEventOBInterceptor.sendUpdateEvent(PersistenceEventOBInterceptor.java:106) at org.openbravo.client.kernel.event.PersistenceEventOBInterceptor.onFlushDirty(PersistenceEventOBInterceptor.java:75) at org.openbravo.client.kernel.event.org$jboss$weld$bean-flat-ManagedBean-class_org$openbravo$client$kernel$event$PersistenceEventOBInterceptor_$$_WeldClientProxy.onFlushDirty(org$jboss$weld$bean-flat-ManagedBean-class_org$openbravo$client$kernel$event$PersistenceEventOBInterceptor_$$_WeldClientProxy.java) at org.openbravo.dal.core.OBInterceptor.onFlushDirty(OBInterceptor.java:188) at org.hibernate.event.def.DefaultFlushEntityEventListener.invokeInterceptor(DefaultFlushEntityEventListener.java:372) at org.hibernate.event.def.DefaultFlushEntityEventListener.handleInterception(DefaultFlushEntityEventListener.java:349) at org.hibernate.event.def.DefaultFlushEntityEventListener.scheduleUpdate(DefaultFlushEntityEventListener.java:287) at org.hibernate.event.def.DefaultFlushEntityEventListener.onFlushEntity(DefaultFlushEntityEventListener.java:155) at org.hibernate.event.def.AbstractFlushingEventListener.flushEntities(AbstractFlushingEventListener.java:219) at org.hibernate.event.def.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:99) at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:50) at org.hibernate.impl.SessionImpl.flush(SessionImpl.java:1216) at org.openbravo.dal.service.OBDal.flush(OBDal.java:191) at org.openbravo.service.json.DefaultJsonDataService.update(DefaultJsonDataService.java:629) at org.openbravo.service.datasource.DefaultDataSourceService.update(DefaultDataSourceService.java:178) at org.openbravo.service.datasource.DataSourceServlet.doPut(DataSourceServlet.java:746) at javax.servlet.http.HttpServlet.service(HttpServlet.java:640) at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225) at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:440) at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87) at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:63) at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:138) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.codehaus.enunciate.webapp.HTTPRequestContextFilter.doFilter(HTTPRequestContextFilter.java:36) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.openbravo.client.analytics.OBSpringSecurityContextRequestFilter$1.doAction(OBSpringSecurityContextRequestFilter.java:82) at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46) at org.openbravo.client.analytics.OBSpringSecurityContextRequestFilter.doFilter(OBSpringSecurityContextRequestFilter.java:90) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206) at org.openbravo.activiti.OBActivitiRequestFilter$1.doAction(OBActivitiRequestFilter.java:68) at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46) at org.openbravo.activiti.OBActivitiRequestFilter.doFilter(OBActivitiRequestFilter.java:81) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235) |
|
(0060133) hgbot (developer) 2013-07-22 06:33 |
Repository: erp/devel/pi Changeset: 12bb1c5af3e1d9724ac9e90a0e8ae18c7b047469 Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Sun Jul 21 16:08:16 2013 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/12bb1c5af3e1d9724ac9e90a0e8ae18c7b047469 [^] Fixes Issue 0024281: In Field window if clientclass is set then neither column or property should be mandatory The client class should be checked before throwing exception that column or property must be set. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/FieldHandler.java --- |
|
(0060148) hudsonbot (viewer) 2013-07-22 15:01 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/62e6ee09ec57 [^] Maturity status: Test |
|
(0060346) AugustoMauch (administrator) 2013-07-29 11:05 |
Code reviewed and verified in pi@2128830a28ff |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-07-08 09:32 | mtaal | New Issue | |
| 2013-07-08 09:32 | mtaal | Assigned To | => caristu |
| 2013-07-08 09:32 | mtaal | File Added: Selection_004.png | |
| 2013-07-08 09:32 | mtaal | Modules | => Core |
| 2013-07-08 09:32 | mtaal | OBNetwork customer | => No |
| 2013-07-08 09:32 | mtaal | Triggers an Emergency Pack | => No |
| 2013-07-08 11:48 | mtaal | Note Added: 0059911 | |
| 2013-07-16 09:03 | mtaal | Assigned To | caristu => AugustoMauch |
| 2013-07-21 12:04 | shankarb | Assigned To | AugustoMauch => shankarb |
| 2013-07-21 12:38 | shankarb | Status | new => scheduled |
| 2013-07-21 12:38 | shankarb | fix_in_branch | => pi |
| 2013-07-22 06:32 | shankarb | Review Assigned To | => AugustoMauch |
| 2013-07-22 06:32 | shankarb | fix_in_branch | pi => |
| 2013-07-22 06:32 | shankarb | Issue Monitored: AugustoMauch | |
| 2013-07-22 06:33 | hgbot | Checkin | |
| 2013-07-22 06:33 | hgbot | Note Added: 0060133 | |
| 2013-07-22 06:33 | hgbot | Status | scheduled => resolved |
| 2013-07-22 06:33 | hgbot | Resolution | open => fixed |
| 2013-07-22 06:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/12bb1c5af3e1d9724ac9e90a0e8ae18c7b047469 [^] |
| 2013-07-22 15:01 | hudsonbot | Checkin | |
| 2013-07-22 15:01 | hudsonbot | Note Added: 0060148 | |
| 2013-07-29 11:05 | AugustoMauch | Note Added: 0060346 | |
| 2013-07-29 11:05 | AugustoMauch | Status | resolved => closed |
| 2013-07-29 11:05 | AugustoMauch | Fixed in Version | => 3.0MP26 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |