Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0024228 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2013-06-29 14:59 | 2013-07-29 09:42 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP26 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 295e879c0198 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | shankarb | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0024228: When clicking new in Sales Order Grid request is fired to OrderLine data | |||||||
| Description | When having the Sales Order grid open with no row selected and clicking in 'New in Form' then a datasource get request is fired for the OrderLine. That does not make sense as in this situation there cannot be any child-records as with are just creating a new one | |||||||
| Steps To Reproduce | Open Sales Order window Remove implicit filter so that records are shown in the grid Without any record selected use the 'New in Form' button from the toolbar. Observer that there is a request to the OrderLine datasource. | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0059944) hgbot (developer) 2013-07-11 07:17 |
Repository: erp/devel/pi Changeset: 7cb2a57521034eb2db3f61621dc7fa3136fca2fb Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Thu Jul 11 10:46:28 2013 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/7cb2a57521034eb2db3f61621dc7fa3136fca2fb [^] Fixes Issue 0024228: When clicking new in Sales Order Grid request is fired to OrderLine data When new row is opened for editing, if the grid has selected records, then the child tabs has to be refreshed. If no records are selected then the request to child tabs is prevented. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0060036) hudsonbot (viewer) 2013-07-16 14:26 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a5d5983399f [^] Maturity status: Test |
|
(0060226) AugustoMauch (administrator) 2013-07-24 13:23 |
The fix is not proper. If before clicking on the 'New in Form' button the user selects a record in the grid, a request will be done to the Sales Order datasource. |
|
(0060265) hgbot (developer) 2013-07-24 16:54 |
Repository: erp/devel/pi Changeset: 295e879c019810985e4eb7290aa94209fe96566b Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Jul 24 16:52:37 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/295e879c019810985e4eb7290aa94209fe96566b [^] Fixes issue 24228, issue 24229: Avoids not needed datasource Some not needed datasource calls were being made when a record was created in grid or form view. It made no sense to ask the datasource for the data of the child tabs of the new record, we can be sure there are none. To fix this, instead of calling the datasource the data of the child grid is emptied manually, and then the emptyMessage of the grid is updated. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0060312) hudsonbot (viewer) 2013-07-26 20:32 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b9e43ea5aa1b [^] Maturity status: Test |
|
(0060343) shankarb (viewer) 2013-07-29 09:42 |
Code reviewed and tested in pi changeset 2128830a28ff. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-06-29 14:59 | shuehner | New Issue | |
| 2013-06-29 14:59 | shuehner | Assigned To | => AugustoMauch |
| 2013-06-29 14:59 | shuehner | Modules | => Core |
| 2013-06-29 14:59 | shuehner | OBNetwork customer | => No |
| 2013-06-29 14:59 | shuehner | Triggers an Emergency Pack | => No |
| 2013-06-29 14:59 | shuehner | Tag Attached: Performance | |
| 2013-06-29 15:02 | shuehner | Relationship added | related to 0024229 |
| 2013-07-11 07:13 | shankarb | Assigned To | AugustoMauch => shankarb |
| 2013-07-11 07:13 | shankarb | Review Assigned To | => mtaal |
| 2013-07-11 07:16 | shankarb | Issue Monitored: mtaal | |
| 2013-07-11 07:17 | hgbot | Checkin | |
| 2013-07-11 07:17 | hgbot | Note Added: 0059944 | |
| 2013-07-11 07:17 | hgbot | Status | new => resolved |
| 2013-07-11 07:17 | hgbot | Resolution | open => fixed |
| 2013-07-11 07:17 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/7cb2a57521034eb2db3f61621dc7fa3136fca2fb [^] |
| 2013-07-16 14:26 | hudsonbot | Checkin | |
| 2013-07-16 14:26 | hudsonbot | Note Added: 0060036 | |
| 2013-07-24 13:23 | AugustoMauch | Assigned To | shankarb => AugustoMauch |
| 2013-07-24 13:23 | AugustoMauch | Note Added: 0060226 | |
| 2013-07-24 13:23 | AugustoMauch | Status | resolved => new |
| 2013-07-24 13:23 | AugustoMauch | Resolution | fixed => open |
| 2013-07-24 16:53 | AugustoMauch | Issue End Monitor: mtaal | |
| 2013-07-24 16:53 | AugustoMauch | Issue Monitored: shankarb | |
| 2013-07-24 16:53 | AugustoMauch | Review Assigned To | mtaal => shankarb |
| 2013-07-24 16:54 | hgbot | Checkin | |
| 2013-07-24 16:54 | hgbot | Note Added: 0060265 | |
| 2013-07-24 16:54 | hgbot | Status | new => resolved |
| 2013-07-24 16:54 | hgbot | Resolution | open => fixed |
| 2013-07-24 16:54 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/7cb2a57521034eb2db3f61621dc7fa3136fca2fb [^] => http://code.openbravo.com/erp/devel/pi/rev/295e879c019810985e4eb7290aa94209fe96566b [^] |
| 2013-07-26 20:32 | hudsonbot | Checkin | |
| 2013-07-26 20:32 | hudsonbot | Note Added: 0060312 | |
| 2013-07-29 09:42 | shankarb | Note Added: 0060343 | |
| 2013-07-29 09:42 | shankarb | Status | resolved => closed |
| 2013-07-29 09:42 | shankarb | Fixed in Version | => 3.0MP26 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |