0023894: Discounts and Promotions should not be applied to financial invoice lines

Description

Currently the M_PROMOTION_CALCULATE procedure will try to apply discounts and promotions to financial invoice lines. This makes no sense as the prices on these lines are always entered manually.

It may also cause an issue for discounts that assume that the invoice line will have a valid product id included.

Steps To Reproduce

1) Create a discount in the system that applies to all sales transactions
2) Create a sales invoice
3) Add a line to the invoice, check financial invoice line and select a gl item
4) Set price on line
5) Book invoice
6) Note that the discount has been applied to the invoice - this can result in the user entered price changing.

Proposed Solution

Change M_PROMOTION_CALCULATE procedure to ignore financial invoice lines.

This can be done by using the financial_invoice_line field as the source of cancelpricead value

Tags

No tags attached.

Attached Files

23894.patch [^] (758 bytes) 2013-05-23 04:27 [Show Content] [Hide Content]

diff --git a/src-db/database/model/functions/M_PROMOTION_CALCULATE.xml b/src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
--- a/src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
+++ b/src-db/database/model/functions/M_PROMOTION_CALCULATE.xml
@@ -81,7 +81,7 @@
                      where c_order_id = p_doc_id
                        and p_type = 'O'
                      union
-                    select c_invoiceline_id, gross_unit_price, c_tax_id, 'N', 
+                    select c_invoiceline_id, gross_unit_price, c_tax_id, financial_invoice_line, 
                            M_Product_ID, ad_client_id, ad_org_id, c_orderline_id, line
                       from c_invoiceline 
                      where c_invoice_id = p_doc_id

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0058852) eintelau (developer) 2013-05-23 04:27	Patch with suggested fix attached

Issue History
Date Modified	Username	Field	Change
2013-05-23 04:23	eintelau	New Issue
2013-05-23 04:23	eintelau	Assigned To	=> dmiguelez
2013-05-23 04:23	eintelau	Web browser	=> Google Chrome
2013-05-23 04:23	eintelau	Modules	=> Core
2013-05-23 04:23	eintelau	Triggers an Emergency Pack	=> No
2013-05-23 04:27	eintelau	File Added: 23894.patch
2013-05-23 04:27	eintelau	Note Added: 0058852