Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023617
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 01. General setupminoralways2013-04-23 13:392013-06-01 02:14
ReportermaiteView Statuspublic 
Assigned ToSandrahuguet 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7b20cf4da8ef
ProjectionnoneETAnoneTarget Version3.0MP24
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023617: Static alert rule query definition needs to be corrected too

DescriptionStatic alert rule query definition needs to be corrected too
Steps To ReproduceAs consequence of issue number 0022881, alert rule was fixed to not show false positives. However, no changes were performed in Issue21640WrongMatchInvAccounting.java file, which still includes wrong query definition in variable 'ALERT_RULE_SQL2'
Proposed SolutionModify ALERT_RULE_SQL2 variable in Issue21640WrongMatchInvAccounting.java file from
"SELECT DISTINCT ad_column_identifier('m_matchinv', fa.record_id, 'en_US') as record_id, fa.record_id as referencekey_id, 0 as ad_role_id, null as ad_user_id, 'This Matched Invoice need to be posted again due to wrong accounting.' as description, 'Y' as isactive, mi.ad_org_id, mi.ad_client_id, now() as created, 0 as createdBy, now() as updated, 0 as updatedBy FROM fact_acct fa JOIN m_matchinv mi ON fa.record_id = mi.m_matchinv_id LEFT JOIN fact_acct far ON far.line_id = mi.m_inoutline_id AND far.account_id = fa.account_id LEFT JOIN fact_acct fi ON fi.line_id = mi.c_invoiceline_id AND fi.account_id = fa.account_id AND fi.ad_table_id = '318' WHERE fa.ad_table_id = '472' AND (COALESCE(far.amtacctcr + far.amtacctdr, fa.amtacctdr + fa.amtacctcr) <> (fa.amtacctdr + fa.amtacctcr) OR COALESCE(fi.amtacctcr + fi.amtacctdr, fa.amtacctdr + fa.amtacctcr) <> (fa.amtacctdr + fa.amtacctcr))"
to
"SELECT DISTINCT ad_column_identifier('m_matchinv', fa.record_id, 'en_US') as record_id, fa.record_id as referencekey_id, 0 as ad_role_id, null as ad_user_id, 'This Matched Invoice need to be posted again due to wrong accounting.' as description, 'Y' as isactive, mi.ad_org_id, mi.ad_client_id, now() as created, 0 as createdBy, now() as updated, 0 as updatedBy FROM fact_acct fa JOIN m_matchinv mi ON fa.record_id = mi.m_matchinv_id LEFT JOIN fact_acct far ON far.line_id = mi.m_inoutline_id AND far.account_id = fa.account_id LEFT JOIN fact_acct fi ON fi.line_id = mi.c_invoiceline_id AND fi.account_id = fa.account_id AND fi.ad_table_id = '318' WHERE (round((select movementqty from m_inoutline where m_inoutline_id=mi.m_inoutline_id),2) = round((select qtyinvoiced from c_invoiceline where c_invoiceline_id=mi.c_invoiceline_id),2)) AND fa.ad_table_id = '472' AND (COALESCE(far.amtacctcr + far.amtacctdr, fa.amtacctdr + fa.amtacctcr) <> (fa.amtacctdr + fa.amtacctcr) OR COALESCE(fi.amtacctcr + fi.amtacctdr, fa.amtacctdr + fa.amtacctcr) <> (fa.amtacctdr + fa.amtacctcr))"
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00228813.0MP22 closedjecharri Wrong definition of the alert 'Wrong Matched Invoice posting. Wrong currency conversion.' 

-  Notes
(0058988)
hgbot (developer)
2013-05-28 12:58

 Repository: erp/devel/pi
Changeset: 7b20cf4da8efc5ad038d1ede283ae58bcfe9b40f
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri May 17 12:04:47 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7b20cf4da8efc5ad038d1ede283ae58bcfe9b40f [^]

Fixed bug 23617 changed ALERT_RULE_SQL2 in Issue21640WrongMatchInvAccounting

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/Issue21640WrongMatchInvAccounting.class
M src-util/modulescript/src/org/openbravo/modulescript/Issue21640WrongMatchInvAccounting.java
---
(0058992)
maite (developer)
2013-05-28 13:34

 verified
(0059092)
hudsonbot (developer)
2013-06-01 02:14

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/31f9b82dde77 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-04-23 13:39 maite New Issue
2013-04-23 13:39 maite Assigned To => dmiguelez
2013-04-23 13:39 maite Modules => Core
2013-04-23 13:39 maite Triggers an Emergency Pack => No
2013-04-23 13:40 maite Relationship added related to 0022881
2013-04-23 13:40 maite Issue Monitored: networkb
2013-04-23 18:47 dmiguelez Assigned To dmiguelez => jonalegriaesarte
2013-05-13 17:31 dmiguelez Assigned To jonalegriaesarte => dmiguelez
2013-05-28 12:57 Sandrahuguet Assigned To dmiguelez => Sandrahuguet
2013-05-28 12:58 hgbot Checkin
2013-05-28 12:58 hgbot Note Added: 0058988
2013-05-28 12:58 hgbot Status new => resolved
2013-05-28 12:58 hgbot Resolution open => fixed
2013-05-28 12:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b20cf4da8efc5ad038d1ede283ae58bcfe9b40f [^]
2013-05-28 13:34 maite Note Added: 0058992
2013-05-28 13:34 maite Status resolved => closed
2013-06-01 02:14 hudsonbot Checkin
2013-06-01 02:14 hudsonbot Note Added: 0059092

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker