Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023596
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2013-04-19 16:302013-04-23 17:13
ReporterdbazView Statuspublic 
Assigned Todbaz 
PriorityhighResolutionfixedFixed in Version3.0MP23
StatusclosedFix in branchFixed in SCM revision290a173d1040
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023596: Add a more generic way to create a "Copy record" button in a tab

DescriptionAdd a more generic way to create a "Copy record" button in a tab.

Right now, in core, there is only a button which creates a "Copy record". It is placed in modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toobar/ob-clone-order.js

The idea is define a more generic function to save code each time a new "Copy record" button should be added to a tab.
Steps To ReproduceAfter the change, ensure that the following test case works as before:

As "Openbravo Admin"
* Go to "Sales Order"
* Create new record (fill all required fields)
* Save
* Press "Copy record" button ( http://wiki.openbravo.com/w/images/e/e6/WIK_button_Clone.png [^] [^] )
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0058060)
hgbot (developer)
2013-04-19 17:57

 Repository: erp/devel/pi
Changeset: 290a173d1040aa41dbcb73952e52a69f6be0c5ff
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 19 17:57:21 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/290a173d1040aa41dbcb73952e52a69f6be0c5ff [^]

Fixed issue 23596: Added 'OB.ToolbarUtils.createCloneButton' function

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-clone-order.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0058063)
dbaz (viewer)
2013-04-19 18:18

 Added this new function:

// ** {{{ OB.ToolbarUtils.createCloneButton(/*String*/ actionHandler, /*Array[String]*/ tabIds, /*String*/ askMsg, /*Integer*/ sortOrder, /*Boolean*/ editRecordAfterClone, /*String*/ buttonId, /*Boolean*/ overwriteIfExists}}} **
// Automatically set up a clone button for the provided tabs
// Parameters:
// * {{{actionHandler}}}: action handler which processes and returns the cloned record
// * {{{tabIds}}}: array of tabIds where this button will be shown
// * {{{askMsg}}}: (Optional, 'OBUIAPP_WantToCloneRecord' by default) Text that will be displayed when the button be pressed.
// * {{{sortOrder}}}: (Optional, '100' by default) Position in the toolbar of the clone button.
// * {{{editRecordAfterClone}}}: (Optional, true by default) If the form edit view (of the cloned record) should be opened after clone it.
// * {{{buttonId}}}: (Optional, random by default) Don't set it unless you plan to do advanced coding with this button (as, for example, overwrite it later in another place).
// * {{{overwriteIfExists}}}: (Optional, false by default) To be able to overwrite a particular existing clone button. The buttonId should match with the overwritten one.
(0058068)
hgbot (developer)
2013-04-19 20:36

 Repository: erp/devel/pi
Changeset: df60e05286a8abafd6bc832a4aa4d6b5564998ed
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 19 20:36:08 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/df60e05286a8abafd6bc832a4aa4d6b5564998ed [^]

Related to issue 23596: proper variable name

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/CloneOrderActionHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0058072)
hgbot (developer)
2013-04-19 22:57

 Repository: erp/devel/pi
Changeset: 1a725f0ecbe0f0c257b52ef59d46c3342887f183
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Fri Apr 19 22:56:51 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1a725f0ecbe0f0c257b52ef59d46c3342887f183 [^]

Related to issue 23596: added 'requestParams' variable

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-clone-order.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0058073)
hgbot (developer)
2013-04-20 00:59

 Repository: erp/devel/pi
Changeset: 5b4ec31e99fd4cfda41811a6c8ba630573dabf09
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Sat Apr 20 00:58:48 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5b4ec31e99fd4cfda41811a6c8ba630573dabf09 [^]

Related to issue 23596: added 'tabId' and 'windowId' to 'requestParams

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0058104)
hudsonbot (viewer)
2013-04-22 16:36

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058109)
hudsonbot (viewer)
2013-04-22 16:36

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058110)
hudsonbot (viewer)
2013-04-22 16:36

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058111)
hudsonbot (viewer)
2013-04-22 16:36

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f78aa78542fa [^]

Maturity status: Test
(0058141)
AugustoMauch (administrator)
2013-04-23 17:13

 Code reviewed and verified in pi@d4a9088f6a09

- Issue History
Date Modified Username Field Change
2013-04-19 16:30 dbaz New Issue
2013-04-19 16:30 dbaz Assigned To => dbaz
2013-04-19 16:30 dbaz Modules => Core
2013-04-19 16:30 dbaz OBNetwork customer => No
2013-04-19 16:30 dbaz Triggers an Emergency Pack => No
2013-04-19 17:55 dbaz Review Assigned To => AugustoMauch
2013-04-19 17:56 dbaz Issue Monitored: AugustoMauch
2013-04-19 17:57 hgbot Checkin
2013-04-19 17:57 hgbot Note Added: 0058060
2013-04-19 17:57 hgbot Status new => resolved
2013-04-19 17:57 hgbot Resolution open => fixed
2013-04-19 17:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/290a173d1040aa41dbcb73952e52a69f6be0c5ff [^]
2013-04-19 18:18 dbaz Note Added: 0058063
2013-04-19 20:36 hgbot Checkin
2013-04-19 20:36 hgbot Note Added: 0058068
2013-04-19 22:57 hgbot Checkin
2013-04-19 22:57 hgbot Note Added: 0058072
2013-04-20 00:59 hgbot Checkin
2013-04-20 00:59 hgbot Note Added: 0058073
2013-04-22 16:36 hudsonbot Checkin
2013-04-22 16:36 hudsonbot Note Added: 0058104
2013-04-22 16:36 hudsonbot Checkin
2013-04-22 16:36 hudsonbot Note Added: 0058109
2013-04-22 16:36 hudsonbot Checkin
2013-04-22 16:36 hudsonbot Note Added: 0058110
2013-04-22 16:36 hudsonbot Checkin
2013-04-22 16:36 hudsonbot Note Added: 0058111
2013-04-23 17:13 AugustoMauch Note Added: 0058141
2013-04-23 17:13 AugustoMauch Status resolved => closed
2013-04-23 17:13 AugustoMauch Fixed in Version => 3.0MP23

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker