Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0023482
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2013-04-03 17:292013-04-29 10:35
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0MP23
StatusclosedFix in branchFixed in SCM revisiond3651e2ab4bd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseOracleJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023482: Problem in Alert Management window, when the quantity of alerts exceeds the quantity of 1000

DescriptionWhen some part of the alerts shown in the AlertManagement window exceeds 1000 then the queries done for this window fail on oracle as oracle cannot execute an IN-clause having more then 1K values.

The application part doing the query is a datasource:
at org.openbravo.dal.service.OBQuery.list(OBQuery.java:112)
at org.openbravo.service.json.DataEntityQueryService.list(DataEntityQueryService.java:91)
at org.openbravo.service.json.DefaultJsonDataService.fetch(DefaultJsonDataService.java:132)
at org.openbravo.service.datasource.DefaultDataSourceService.fetch(DefaultDataSourceService.java:72)
at org.openbravo.service.datasource.DataSourceServlet.doFetch(DataSourceServlet.java:241)
at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:574)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)

A logfile is attached showing the Hibernate_debug log containing an example of such an failing query.

Steps To ReproduceThis occurs in Oracle, when there is an Alert Rule with a Filter Clause having more than 1000 alert instances for the current user/role.

-Create an Alert Rule that generates more than 1000 alert instances
-Define for this Alert Rule a Filter Clause (i.e. 1=1)
-Try to open Alert Management window (from top bar)
-No data is loaded in any of the grids, the error reported in the description can be seen in the log
Proposed SolutionAs quick fix: split the "IN" part of the query in chunks of at most 1000 elements.
TagsNo tags attached.
Attached Fileslog file icon alert-management-window.log [^] (145,036 bytes) 2013-04-03 17:29
diff file icon 23482.diff [^] (2,627 bytes) 2013-04-04 12:35 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0023490 newAugustoMauch Alert Management window doesn't scale 

-  Notes
(0057726)
alostale (manager)
2013-04-04 12:35

Attached patch till pi is unfrozen
(0057803)
hgbot (developer)
2013-04-09 15:29

Repository: erp/devel/pi
Changeset: d3651e2ab4bda740118d29362150aa44dfd7192f
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 04 12:33:39 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d3651e2ab4bda740118d29362150aa44dfd7192f [^]

fixed bug 23482: Alert Management fails in ORA having more than 1000 alerts
if those alerts belong to Alert Rules with a Filter Clause

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/alert-management/ob-alert-grid.js
---
(0057940)
hudsonbot (developer)
2013-04-16 19:18

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8df08bea850d [^]

Maturity status: Test
(0058296)
AugustoMauch (administrator)
2013-04-29 10:35

Code reviewed and verified in pi@5e5dd4a8b5c0

- Issue History
Date Modified Username Field Change
2013-04-03 17:29 shuehner New Issue
2013-04-03 17:29 shuehner Assigned To => alostale
2013-04-03 17:29 shuehner Modules => Core
2013-04-03 17:29 shuehner Triggers an Emergency Pack => No
2013-04-03 17:29 shuehner File Added: alert-management-window.log
2013-04-04 12:32 alostale Steps to Reproduce Updated View Revisions
2013-04-04 12:32 alostale Proposed Solution updated
2013-04-04 12:35 alostale File Added: 23482.diff
2013-04-04 12:35 alostale Note Added: 0057726
2013-04-04 12:35 alostale Review Assigned To => AugustoMauch
2013-04-04 12:51 alostale Relationship added related to 0023490
2013-04-09 15:29 hgbot Checkin
2013-04-09 15:29 hgbot Note Added: 0057803
2013-04-09 15:29 hgbot Status new => resolved
2013-04-09 15:29 hgbot Resolution open => fixed
2013-04-09 15:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d3651e2ab4bda740118d29362150aa44dfd7192f [^]
2013-04-16 19:18 hudsonbot Checkin
2013-04-16 19:18 hudsonbot Note Added: 0057940
2013-04-29 10:35 AugustoMauch Note Added: 0058296
2013-04-29 10:35 AugustoMauch Status resolved => closed
2013-04-29 10:35 AugustoMauch Fixed in Version => 3.0MP23


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker