Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023305
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2013-03-14 13:022013-04-26 23:54
ReporteregoitzView Statuspublic 
Assigned Topramakrishnan 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision698aa79b72ae
ProjectionnoneETAnoneTarget Version3.0MP23
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023305: When sending multiple documents by email the process does not send properly if the contacts of the partnes have the same name

DescriptionWhen sending multiple documents by email the process does not send properly if the contacts of the partners have the same name.

If i select 3 invoices to send email for the partners, if the three partners are different, but 2 of them have a contact with the same name, the result when sending the invoice is:
3 documents sent to 2 partners.
This is because the process send mails for the contacts and check if the name is different but not the email.
Steps To Reproduce-Define the email server
-Create three partners
-Create three contacts for that partners adding a email for each one
-Two of that contacts should have the same name.
-Create one invoice for each partner and complete it
-Select on the grid the three invoices and click on send email.

*See that 3 documents are sent to 2 customers
Proposed SolutionON PrintController.java file
see the method
getHiddenTags

replace
      final String customer = documentData.contactName;
with
      final String customer = documentData.contactEmail;

The same problem could happen with the salesrep

in this case the solution could be on the same method to replace
      final String salesRep = documentData.salesrepName;
with
       final String salesRep = documentData.salesrepEmail;
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0058164)
pramakrishnan (developer)
2013-04-24 10:33

 Test Plan:
-Define the email server
-Create three partners
-Create three contacts for that partners adding a email for each one
-Two of that contacts should have the same name.
-Create one invoice for each partner and complete it
-Select on the grid the three invoices and click on send email.

*See that 3 documents are sent to 3 customers
(0058249)
hgbot (developer)
2013-04-25 13:42

 Repository: erp/devel/pi
Changeset: 698aa79b72aef989c5158074f2dc676f92df6b8d
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Wed Apr 24 14:01:26 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/698aa79b72aef989c5158074f2dc676f92df6b8d [^]

Fixes Issue 23305: Error sending multiple documents by email
The process does not send properly if the contacts of the partners have the same name

---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0058250)
hgbot (developer)
2013-04-25 13:42

 Repository: erp/devel/pi
Changeset: 474850a4bb4845ad001c9d06212830de3a69e3a1
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Apr 25 13:41:50 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/474850a4bb4845ad001c9d06212830de3a69e3a1 [^]

Related to Issue 23305. Shows name in message instead of mail address.

---
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0058251)
dmiguelez (developer)
2013-04-25 13:43

 Code Review + Testing Ok
(0058285)
hudsonbot (developer)
2013-04-26 23:54

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1db7e66bd5c5 [^]

Maturity status: Test
(0058286)
hudsonbot (developer)
2013-04-26 23:54

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1db7e66bd5c5 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-03-14 13:02 egoitz New Issue
2013-03-14 13:02 egoitz Assigned To => dmiguelez
2013-03-14 13:02 egoitz Modules => Core
2013-03-14 13:02 egoitz Resolution time => 1364598000
2013-03-14 13:02 egoitz Triggers an Emergency Pack => No
2013-03-14 13:03 egoitz Assigned To dmiguelez => ioritzCia
2013-03-14 18:40 dmiguelez Assigned To ioritzCia => jonalegriaesarte
2013-04-02 18:50 jonalegriaesarte Target Version 3.0MP22 => 3.0MP23
2013-04-18 10:13 jonalegriaesarte Assigned To jonalegriaesarte => dmiguelez
2013-04-23 12:14 pramakrishnan Assigned To dmiguelez => pramakrishnan
2013-04-23 12:14 pramakrishnan Status new => scheduled
2013-04-23 12:14 pramakrishnan fix_in_branch => pi
2013-04-24 10:33 pramakrishnan Note Added: 0058164
2013-04-25 13:42 hgbot Checkin
2013-04-25 13:42 hgbot Note Added: 0058249
2013-04-25 13:42 hgbot Status scheduled => resolved
2013-04-25 13:42 hgbot Resolution open => fixed
2013-04-25 13:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/698aa79b72aef989c5158074f2dc676f92df6b8d [^]
2013-04-25 13:42 hgbot Checkin
2013-04-25 13:42 hgbot Note Added: 0058250
2013-04-25 13:43 dmiguelez Note Added: 0058251
2013-04-25 13:43 dmiguelez Status resolved => closed
2013-04-26 23:54 hudsonbot Checkin
2013-04-26 23:54 hudsonbot Note Added: 0058285
2013-04-26 23:54 hudsonbot Checkin
2013-04-26 23:54 hudsonbot Note Added: 0058286

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker