Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023124
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2013-02-20 11:102013-04-16 19:18
ReportermiruritaView Statuspublic 
Assigned Toshankarb 
PrioritynormalResolutionfixedFixed in Version3.0MP23
StatusclosedFix in branchpiFixed in SCM revision84a2a4d680e1
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023124: Tabledir reference not resolving properly column identifier in some cases

DescriptionTabledir reference not resolving properly column identifier in some cases
Steps To Reproduce1) Put core in development
alter table c_invoice add column mytestcolumn character varying(32);
alter table c_invoice add CONSTRAINT mytestcolumnconstraint FOREIGN KEY (mytestcolumn) REFERENCES c_bpartner (c_bpartner_id);

2) Create a new 'OBUISEL_Selector Reference' for c_bpartner table
  
3) Create a new column for 'mytestcolumn' in c_invoice table
  * Used as Record Identifier
  * Link to parent column
  * Reference: OBUISEL_Selector Reference of step 2)

4) Change C_InvoiceLine.C_Invoice_ID column reference to tabledir
5) Compile
6) Go to sales invoice window
7) Create a new header
8) Create a new line

FROM C_Invoice td0
left join C_BPartner td1 on td0.Mytestcolumn = td1.Mytestcolumn
AND td1.AD_Client_ID IN ('0','23C59575B9CF467C9620760EB255B389')
AND td1.AD_Org_ID IN ('E443A31992CB4635AFCAEABE7183CE85','B843C30461EA4501935CB1D125C9C25A','19404EAD144C49A0AF37D54377CF452D','0')
WHERE td0.AD_Client_ID IN ('0','23C59575B9CF467C9620760EB255B389')
AND td0.AD_Org_ID IN ('E443A31992CB4635AFCAEABE7183CE85','B843C30461EA4501935CB1D125C9C25A','19404EAD144C49A0AF37D54377CF452D','0')
AND (td0.isActive = 'Y' OR td0.C_Invoice_ID = (?) )
ORDER BY 2, 2Exception:org.postgresql.util.PSQLException: ERROR: column td1.mytestcolumn does not exist
  Position: 387
TagsNo tags attached.
Attached Filesdiff file icon testIssue23124.diff [^] (14,966 bytes) 2013-04-11 16:41 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0057395)
shankarb (reporter)
2013-03-25 07:07

 Fixes Issue 23124, Related to Issue 23267 : Selectors as Identifiers

When comparing selector columns in ComboData the column name in the table was used to compare with the selector table. This results in exception when the column names are different.
In case the selector has the column field, that column is used for comparison avoiding this error.
(0057400)
shankarb (reporter)
2013-03-25 10:30

 Fixed in pi changeset https://code.openbravo.com/erp/devel/pi/rev/096f0a4c98fd [^]
(0057415)
hudsonbot (developer)
2013-03-25 13:12

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/88ae0db922b5 [^]

Maturity status: Test
(0057476)
hgbot (developer)
2013-03-26 18:31

 Repository: erp/devel/pi
Changeset: fd931cc7208746c5b58800607029bcf68a8ef146
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Mar 26 18:01:18 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fd931cc7208746c5b58800607029bcf68a8ef146 [^]

Related to issue 23124: Fix is backed out until beginning of next MP cycle

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
---
(0057477)
AugustoMauch (manager)
2013-03-26 18:34

 Fix has been backed out:
- It is risky and the end of the current MP cycle is close
- It is difficult to test
(0057525)
hudsonbot (developer)
2013-03-28 01:39

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6c4c5ed08030 [^]

Maturity status: Test
(0057815)
hgbot (developer)
2013-04-10 04:06

 Repository: erp/devel/pi
Changeset: 84a2a4d680e136f831073ff42e8f9848cb0394c3
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Apr 10 07:32:00 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/84a2a4d680e136f831073ff42e8f9848cb0394c3 [^]

Fixes Issue 23124, Related to Issue 23267 : Selectors as Identifiers

When comparing selector columns in ComboData the column name in the table was used to compare with the selector table. This results in exception when the column names are different.
In case the selector has the column field, that column is used for comparison avoiding this error.

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/reference/SelectorUIReference.java
---
(0057846)
AugustoMauch (manager)
2013-04-11 16:41

 Reopened just to attach diff to test the issue
(0057847)
AugustoMauch (manager)
2013-04-11 16:43

 Code reviewed and verified in pi@57cbb59b1aca.

To test the issue, that attached patch has been used, which sets up the components described in the steps to reproduce.
(0057948)
hudsonbot (developer)
2013-04-16 19:18

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8df08bea850d [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-02-20 11:10 mirurita New Issue
2013-02-20 11:10 mirurita Assigned To => AugustoMauch
2013-02-20 11:10 mirurita Modules => Core
2013-02-20 11:10 mirurita Triggers an Emergency Pack => No
2013-03-21 12:51 AugustoMauch Assigned To AugustoMauch => shankarb
2013-03-25 07:06 shankarb Status new => scheduled
2013-03-25 07:06 shankarb fix_in_branch => pi
2013-03-25 07:06 shankarb Review Assigned To => AugustoMauch
2013-03-25 07:06 shankarb fix_in_branch pi =>
2013-03-25 07:06 shankarb Issue Monitored: AugustoMauch
2013-03-25 07:07 shankarb Note Added: 0057395
2013-03-25 07:07 shankarb Status scheduled => resolved
2013-03-25 07:07 shankarb Fixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/096f0a4c98fd [^]
2013-03-25 07:07 shankarb Resolution open => fixed
2013-03-25 10:30 shankarb Note Added: 0057400
2013-03-25 13:12 hudsonbot Checkin
2013-03-25 13:12 hudsonbot Note Added: 0057415
2013-03-26 18:31 hgbot Checkin
2013-03-26 18:31 hgbot Note Added: 0057476
2013-03-26 18:34 AugustoMauch Note Added: 0057477
2013-03-26 18:34 AugustoMauch Status resolved => new
2013-03-26 18:34 AugustoMauch Resolution fixed => open
2013-03-28 01:39 hudsonbot Checkin
2013-03-28 01:39 hudsonbot Note Added: 0057525
2013-04-08 10:55 AugustoMauch Status new => scheduled
2013-04-08 10:55 AugustoMauch fix_in_branch => pi
2013-04-10 04:06 hgbot Checkin
2013-04-10 04:06 hgbot Note Added: 0057815
2013-04-10 04:06 hgbot Status scheduled => resolved
2013-04-10 04:06 hgbot Resolution open => fixed
2013-04-10 04:06 hgbot Fixed in SCM revision https://code.openbravo.com/erp/devel/pi/rev/096f0a4c98fd [^] => http://code.openbravo.com/erp/devel/pi/rev/84a2a4d680e136f831073ff42e8f9848cb0394c3 [^]
2013-04-11 16:41 AugustoMauch Note Added: 0057846
2013-04-11 16:41 AugustoMauch Status resolved => new
2013-04-11 16:41 AugustoMauch Resolution fixed => open
2013-04-11 16:41 AugustoMauch File Added: testIssue23124.diff
2013-04-11 16:42 AugustoMauch Status new => scheduled
2013-04-11 16:42 AugustoMauch Status scheduled => resolved
2013-04-11 16:42 AugustoMauch Resolution open => fixed
2013-04-11 16:43 AugustoMauch Note Added: 0057847
2013-04-11 16:43 AugustoMauch Status resolved => closed
2013-04-11 16:43 AugustoMauch Fixed in Version => 3.0MP23
2013-04-16 19:18 hudsonbot Checkin
2013-04-16 19:18 hudsonbot Note Added: 0057948

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker