Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023035
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajorsometimes2013-02-11 22:342013-02-20 04:50
ReporterVictorVillarView Statuspublic 
Assigned Todmiguelez 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision175182b0760a
ProjectionnoneETAnoneTarget Version3.0MP21
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023035: Randomly wrong cost calculation for Goods movements transactions

DescriptionRandomly wrong cost calculation for Goods movements transactions.
Steps To ReproduceUnder some circunstancies, not defined yet, it happens that the cost for one of Goods Movement transaction (incoming) is 0.

The reason could be that TransactionCostList object is empty on getTransactionCost() method in CostingUtils.java
Proposed SolutionThere could be two solutions:

1.- See the attached .diff

2.- On the CostingServer.java, createTransactionCost() method, we have:

TransactionCost transactionCost = OBProvider.getInstance().get(TransactionCost.class);
...
OBDal.getInstance().save(transactionCost);

and the solution could be:

List<TransactionCost> tcostList = transaction.getTransactionCostList();
tcostList.add(transactionCost);
TagsNo tags attached.
Attached Filesdiff file icon 19459.diff [^] (509 bytes) 2013-02-11 22:34 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0056351)
VictorVillar (developer)
2013-02-11 22:47

 Also Support Ticket: 19117
(0056524)
hgbot (developer)
2013-02-18 15:51

 Repository: erp/devel/pi
Changeset: 175182b0760a68e06dce64b19afdbdeb59a76957
Author: Victor Villar <victor.villar <at> openbravo.com>
Date: Mon Feb 18 15:49:53 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/175182b0760a68e06dce64b19afdbdeb59a76957 [^]

Fixed issue 23035: Randomly wrong cost calculation for Goods movements transactions

---
M src/org/openbravo/costing/CostingServer.java
---
(0056527)
dmiguelez (developer)
2013-02-18 16:24

 Code Review + Testing OK
(0056621)
hudsonbot (developer)
2013-02-20 04:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-02-11 22:34 VictorVillar New Issue
2013-02-11 22:34 VictorVillar Assigned To => dmiguelez
2013-02-11 22:34 VictorVillar File Added: 19459.diff
2013-02-11 22:34 VictorVillar Modules => Core
2013-02-11 22:34 VictorVillar Triggers an Emergency Pack => No
2013-02-11 22:34 VictorVillar Issue Monitored: networkb
2013-02-11 22:47 VictorVillar Note Added: 0056351
2013-02-11 22:52 VictorVillar Steps to Reproduce Updated View Revisions
2013-02-11 22:53 VictorVillar Reproducibility always => sometimes
2013-02-18 15:51 hgbot Checkin
2013-02-18 15:51 hgbot Note Added: 0056524
2013-02-18 15:51 hgbot Status new => resolved
2013-02-18 15:51 hgbot Resolution open => fixed
2013-02-18 15:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/175182b0760a68e06dce64b19afdbdeb59a76957 [^]
2013-02-18 16:24 dmiguelez Review Assigned To => dmiguelez
2013-02-18 16:24 dmiguelez Note Added: 0056527
2013-02-18 16:24 dmiguelez Status resolved => closed
2013-02-20 04:50 hudsonbot Checkin
2013-02-20 04:50 hudsonbot Note Added: 0056621

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker