Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0022969

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 07. Sales management

major

always

2013-02-04 17:46

2013-02-20 04:49

Reporter

jecharri

View Status

public

Assigned To

jecharri

Priority

urgent

Resolution

fixed

Fixed in Version

3.0MP21

Status

closed

Fix in branch

pi

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0MP21

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

egoitz

Web browser

Google Chrome

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0022969: SE_ORDER_Bpartner callout does not work perfectly

Description

SE_ORDER_Bpartner callout does not work perfectly

When you add a default value for "partner address" or "Invoicing address" and default value for "Business Partner" field, the callout is trying to find a null value but empty ("") value comes.

Steps To Reproduce

Insert a default value for Business partner in window sales order.
Insert a default value for Business partner address in window sales order.
Insert a default value for Business partner invoicing address in window sales. order.

Login as Admin and create an order:
-verify that values for addresses are empty due to wrong behaviour of callout

Tags

No tags attached.

issue22969.diff [^] (768 bytes) 2013-02-04 17:47 [Show Content] [Hide Content]

diff -r 532f52037605 src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
--- a/src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java	Fri Feb 01 13:11:19 2013 +0100
+++ b/src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java	Mon Feb 04 17:46:42 2013 +0100
@@ -109,7 +109,7 @@
     FieldProvider[] tdv = null;
 
     String strLocation = info.vars.getStringParameter("inpcBpartnerId_LOC");
-    if (strLocation != null) {
+    if (strLocation != null && !strLocation.isEmpty()) {
       info.addResult("inpcBpartnerLocationId", strLocation);
     }
 
@@ -222,7 +222,7 @@
 
     // Bill to
 
-    if (strLocation != null) {
+    if (strLocation != null && !strLocation.isEmpty()) {
       info.addResult("inpbilltoId", strLocation);
     }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0056321) hgbot (developer) 2013-02-11 12:20	Repository: erp/devel/pi Changeset: ec3dba0dfb75f1af9fb72bf1897f3a071d47c838 Author: Javier Etxarri <javier.echarri <at> openbravo.com> Date: Thu Feb 07 22:28:28 2013 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ec3dba0dfb75f1af9fb72bf1897f3a071d47c838 [^] Fixes issue 22969: SE_ORDER_Bpartner callout does not work perfectly --- M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java ---

(0056555) hudsonbot (developer) 2013-02-20 04:49	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2013-02-04 17:46	jecharri	New Issue
2013-02-04 17:46	jecharri	Assigned To	=> jecharri
2013-02-04 17:46	jecharri	Web browser	=> Google Chrome
2013-02-04 17:46	jecharri	Modules	=> Core
2013-02-04 17:46	jecharri	Triggers an Emergency Pack	=> No
2013-02-04 17:47	jecharri	File Added: issue22969.diff
2013-02-08 01:43	jecharri	Status	new => scheduled
2013-02-08 01:43	jecharri	fix_in_branch	=> pi
2013-02-11 12:20	hgbot	Checkin
2013-02-11 12:20	hgbot	Note Added: 0056321
2013-02-11 12:20	hgbot	Status	scheduled => resolved
2013-02-11 12:20	hgbot	Resolution	open => fixed
2013-02-11 12:20	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/ec3dba0dfb75f1af9fb72bf1897f3a071d47c838 [^]
2013-02-15 09:24	egoitz	Review Assigned To	=> egoitz
2013-02-15 09:24	egoitz	Status	resolved => closed
2013-02-15 09:24	egoitz	Fixed in Version	=> 3.0MP21
2013-02-20 04:49	hudsonbot	Checkin
2013-02-20 04:49	hudsonbot	Note Added: 0056555

Copyright © 2000 - 2009 MantisBT Group