Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0022811
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorsometimes2013-01-16 17:462013-01-17 09:33
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisionc933b4a55810
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022811: The WebPOS creates too many connections, and doesn't reuse them

DescriptionCurrently the WebPOS is generating connections when the user logs in, and this connections are never reused. The result is that the number of active connections grows indefinitely.

Steps To Reproduce- Log in the WebPOS.
- Verify the number of active connections (for example with select * from pg_stat_activity).
- Logout and log in again.
- Verify that the number of active connections went up.
Integer
This sometimes doesn't happen, probably because the garbage collector is able to detect that the class which handles the unneeded connections is no longer referenced and destroys it, alongside its connections.
Proposed SolutionThe root cause of the problem is that a new connection pool is being created every time a call to the POSUtils.getLastDocumentNumberForPOS method is called. This is wrong, and the query should be done using one of the standard connection pools.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0055547)
hgbot (developer)
2013-01-16 17:52

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: abc23166286b575784e8bd32bf642725128b4694
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jan 16 17:52:09 2013 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abc23166286b575784e8bd32bf642725128b4694 [^]

Fixed issue 22811. The login process will no longer create a new connection pool.

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0055548)
guilleaer (manager)
2013-01-16 18:48

Code reviewed and tested
(0055550)
hgbot (developer)
2013-01-17 02:28

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c933b4a55810f9bc88d5167eb564af6991e6765a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jan 16 17:52:09 2013 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c933b4a55810f9bc88d5167eb564af6991e6765a [^]

Fixed issue 22811. The login process will no longer create a new connection pool.

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---
(0055553)
marvintm (manager)
2013-01-17 09:33

Closed again, as it was incorrectly reopened.

- Issue History
Date Modified Username Field Change
2013-01-16 17:46 marvintm New Issue
2013-01-16 17:46 marvintm Assigned To => marvintm
2013-01-16 17:47 marvintm Status new => acknowledged
2013-01-16 17:47 marvintm Status acknowledged => scheduled
2013-01-16 17:47 marvintm fix_in_branch => pi
2013-01-16 17:47 marvintm fix_in_branch pi =>
2013-01-16 17:49 marvintm Review Assigned To => guilleaer
2013-01-16 17:52 hgbot Checkin
2013-01-16 17:52 hgbot Note Added: 0055547
2013-01-16 17:52 hgbot Status scheduled => resolved
2013-01-16 17:52 hgbot Resolution open => fixed
2013-01-16 17:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abc23166286b575784e8bd32bf642725128b4694 [^]
2013-01-16 18:48 guilleaer Note Added: 0055548
2013-01-16 18:48 guilleaer Status resolved => closed
2013-01-16 18:48 guilleaer Fixed in Version => RMP19
2013-01-17 02:28 hgbot Checkin
2013-01-17 02:28 hgbot Note Added: 0055550
2013-01-17 02:28 hgbot Status closed => resolved
2013-01-17 02:28 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abc23166286b575784e8bd32bf642725128b4694 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c933b4a55810f9bc88d5167eb564af6991e6765a [^]
2013-01-17 09:25 caristu Review Assigned To guilleaer => caristu
2013-01-17 09:25 caristu Note Added: 0055552
2013-01-17 09:25 caristu Status resolved => closed
2013-01-17 09:30 caristu Status closed => new
2013-01-17 09:30 caristu Resolution fixed => open
2013-01-17 09:30 caristu Fixed in Version RMP19 =>
2013-01-17 09:31 caristu Note Deleted: 0055552
2013-01-17 09:32 marvintm Status new => scheduled
2013-01-17 09:32 marvintm fix_in_branch => pi
2013-01-17 09:32 marvintm Status scheduled => resolved
2013-01-17 09:32 marvintm Resolution open => fixed
2013-01-17 09:33 marvintm Review Assigned To caristu => guilleaer
2013-01-17 09:33 marvintm Note Added: 0055553
2013-01-17 09:33 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker