Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0022766
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] B. User interfaceminoralways2013-01-10 12:442013-03-04 09:36
ReportercaristuView Statuspublic 
Assigned ToAugustoMauch 
PriorityhighResolutionfixedFixed in Version3.0MP21
StatusclosedFix in branchpiFixed in SCM revision66e71edf502a
ProjectionnoneETAnoneTarget Version3.0MP21
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022766: Information is lost when the record is saved with errors

DescriptionWhen saving a new record with wrong values in [List Reference] tab of [Reference] window, the information is not saved (see attachment). This forces the user to re-enter again all the information.
Steps To ReproduceAs System Admin Role:

1) Go to [Module] window and create a new module. Set it in 'In Development'
2) Go to [Reference] window, in [List Reference] tab insert a new record in grid mode, with the following values:

  - Module: Module created in step 1)
  - Search Key: 000000000100000
  - Name: by campaign

  (With this values the record is not valid because the search key has not the module db_prefix_ sub-string before 000000000100000)

3) Save the record
TagsNo tags attached.
Attached Filespng file icon listReference.png [^] (21,380 bytes) 2013-01-10 12:46


diff file icon issue2276.diff [^] (2,162 bytes) 2013-01-30 13:55 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0055973)
jonalegriaesarte (reporter)
2013-01-30 13:59

Moved to MP21 because it needs to be tested in depth. In any case, the patch is attached to test it.
(0056033)
mtaal (manager)
2013-02-01 08:08

Hi Augusto,
The diff looks fine, but one question. I see this
record['_hasValidationErrors'] = true

but I don't see any code to set it back to false or to remove the hasValidationErrors.

I will close/check the issue again for MP21, okay?

gr. Martin
(0056038)
AugustoMauch (manager)
2013-02-01 09:43

Thanks Martin.

I saw no need to delete/reset the _hasValidationErrors property because when the record is saved without validation errors that property is no longer present in that record.
(0056039)
mtaal (manager)
2013-02-01 09:45

Ok, my impression is that the record will stay in memory during the lifetime of the grid/form. But I am not sure...

gr. Martin
(0056394)
hgbot (developer)
2013-02-12 13:33

Repository: erp/devel/pi
Changeset: 66e71edf502a8804809950b477858294ca8bf7d6
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 12 13:29:13 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/66e71edf502a8804809950b477858294ca8bf7d6 [^]

Fixes issue 22766: Information is not lost when saving a record with errors

The problem was that when a record was saved and in the saving process it was returned with validation errors, the record was being cleared from the grid. This happened because the List
Grid recordHasChanges function returned false (the record had changes indeed, in fact it was not yet saved in the database).

This has been fixed by overwritting the recordHasChanges function, so that it always returns true if the record had validation errors. In that case we can be sure that the record has ch
anges, because we know that a record with validation changes can not be saved in the database.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0056583)
hudsonbot (developer)
2013-02-20 04:50

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056955)
mtaal (manager)
2013-03-04 09:36

Reviewed

- Issue History
Date Modified Username Field Change
2013-01-10 12:44 caristu New Issue
2013-01-10 12:44 caristu Assigned To => dbaz
2013-01-10 12:44 caristu File Added: listReference.png
2013-01-10 12:44 caristu Modules => Core
2013-01-10 12:44 caristu Resolution time => 1362524400
2013-01-10 12:44 caristu Triggers an Emergency Pack => No
2013-01-10 12:44 caristu File Deleted: listReference.png
2013-01-10 12:46 caristu File Added: listReference.png
2013-01-10 12:46 caristu Issue Monitored: networkb
2013-01-10 12:58 caristu Steps to Reproduce Updated View Revisions
2013-01-10 14:02 dbaz Assigned To dbaz => AugustoMauch
2013-01-30 13:54 AugustoMauch Issue Monitored: mtaal
2013-01-30 13:55 AugustoMauch Review Assigned To => mtaal
2013-01-30 13:55 AugustoMauch File Added: issue2276.diff
2013-01-30 13:58 jonalegriaesarte Target Version 3.0MP20 => 3.0MP21
2013-01-30 13:59 jonalegriaesarte Note Added: 0055973
2013-02-01 08:08 mtaal Note Added: 0056033
2013-02-01 09:43 AugustoMauch Note Added: 0056038
2013-02-01 09:45 mtaal Note Added: 0056039
2013-02-01 12:28 AugustoMauch Relationship added has duplicate 0022123
2013-02-01 13:35 AugustoMauch Status new => scheduled
2013-02-01 13:35 AugustoMauch fix_in_branch => pi
2013-02-12 13:14 AugustoMauch Relationship deleted has duplicate 0022123
2013-02-12 13:33 hgbot Checkin
2013-02-12 13:33 hgbot Note Added: 0056394
2013-02-12 13:33 hgbot Status scheduled => resolved
2013-02-12 13:33 hgbot Resolution open => fixed
2013-02-12 13:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/66e71edf502a8804809950b477858294ca8bf7d6 [^]
2013-02-20 04:50 hudsonbot Checkin
2013-02-20 04:50 hudsonbot Note Added: 0056583
2013-03-04 09:36 mtaal Note Added: 0056955
2013-03-04 09:36 mtaal Status resolved => closed
2013-03-04 09:36 mtaal Fixed in Version => 3.0MP21


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker