Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0022572 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2012-12-13 18:45 | 2012-12-17 13:34 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP19 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 2de5e4f708d8 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP19 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0022572: Invalid preference value results in stack overflow when reading properties | |||||||
| Description | When having a preference value which only consists of a [ (a bracket) then you get a stackoverflow exception. a88e7e7a 2012-12-13 17:34:30,869 [ajp-8008-2] ERROR org.openbravo.client.application.PropertiesComponent - null id: OBUIAPP_RecentViewList value: [ java.lang.StackOverflowError at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:86) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:96) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) at org.codehaus.jettison.json.JSONArray.<init>(JSONArray.java:110) at org.codehaus.jettison.json.JSONTokener.nextValue(JSONTokener.java:313) | |||||||
| Steps To Reproduce | Goto the preference window and create a preference, for example recentview with as value only a [ Restart or relogin | |||||||
| Proposed Solution | This should be made robust so that the system ignores the preference and reports it in the log. The attached diff solves it. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
Notes |
|
|
(0054924) hgbot (developer) 2012-12-13 19:01 |
Repository: erp/devel/pi Changeset: 2de5e4f708d8b97aeaff71f13f6c80ae27b528ae Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Dec 13 19:01:30 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/2de5e4f708d8b97aeaff71f13f6c80ae27b528ae [^] Fixes issue 22572: Invalid preference value results in stack overflow when reading properties Make building client side properties more robust. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/PropertiesComponent.java --- |
|
(0054944) AugustoMauch (administrator) 2012-12-14 12:16 |
Code reviewed and verified in pi@3db450e737fd |
|
(0055007) hudsonbot (viewer) 2012-12-17 13:34 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c79ef1b1f830 [^] Maturity status: Test |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-12-13 18:45 | mtaal | New Issue | |
| 2012-12-13 18:45 | mtaal | Assigned To | => mtaal |
| 2012-12-13 18:45 | mtaal | File Added: stack_overflow.diff | |
| 2012-12-13 18:45 | mtaal | Modules | => Core |
| 2012-12-13 18:45 | mtaal | OBNetwork customer | => No |
| 2012-12-13 18:45 | mtaal | Triggers an Emergency Pack | => No |
| 2012-12-13 18:46 | mtaal | Review Assigned To | => AugustoMauch |
| 2012-12-13 19:01 | hgbot | Checkin | |
| 2012-12-13 19:01 | hgbot | Note Added: 0054924 | |
| 2012-12-13 19:01 | hgbot | Status | new => resolved |
| 2012-12-13 19:01 | hgbot | Resolution | open => fixed |
| 2012-12-13 19:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/2de5e4f708d8b97aeaff71f13f6c80ae27b528ae [^] |
| 2012-12-14 12:16 | AugustoMauch | Note Added: 0054944 | |
| 2012-12-14 12:16 | AugustoMauch | Status | resolved => closed |
| 2012-12-14 12:16 | AugustoMauch | Fixed in Version | => 3.0MP19 |
| 2012-12-17 13:34 | hudsonbot | Checkin | |
| 2012-12-17 13:34 | hudsonbot | Note Added: 0055007 | |
| Copyright © 2000 - 2009 MantisBT Group |