0022476: When you create the invoice in the web POS it will be great if you will be able to see the related order

Description

When you create the invoice in the web POS it will be great if you will be able to see the related order.

Legally we can not assign the same documentno to the invoice, so one way to identify easily the relation between the order and invoice, will be to insert the order documentno in the invoice description.

Steps To Reproduce

-login in the web POS
-mark one receipt as "Invoice this receipt", add a product and pay it.

You will see that invoice and order has been created but you are not able to identify easily what invoice goes with what order.

Tags

No tags attached.

Attached Files

issue22476.diff [^] (2,746 bytes) 2012-12-07 12:49 [Show Content] [Hide Content]

diff -r 12d5d943eb22 src-db/database/sourcedata/AD_MESSAGE.xml
--- a/src-db/database/sourcedata/AD_MESSAGE.xml	Fri Dec 07 10:05:08 2012 +0100
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml	Fri Dec 07 12:49:27 2012 +0100
@@ -3094,6 +3094,17 @@
 <!--DE897F28B4324A80994D08DCE24290CE-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
 <!--DE897F28B4324A80994D08DCE24290CE--></AD_MESSAGE>
 
+<!--DEF1813D01D049709AB24DBD41C0B3C9--><AD_MESSAGE>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <AD_MESSAGE_ID><![CDATA[DEF1813D01D049709AB24DBD41C0B3C9]]></AD_MESSAGE_ID>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <VALUE><![CDATA[OBPOS_InvoiceRelatedToOrder]]></VALUE>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <MSGTEXT><![CDATA[Related to ticket: ]]></MSGTEXT>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <MSGTYPE><![CDATA[I]]></MSGTYPE>
+<!--DEF1813D01D049709AB24DBD41C0B3C9-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
+<!--DEF1813D01D049709AB24DBD41C0B3C9--></AD_MESSAGE>
+
 <!--DF0B0C41CE7D490AAE15F6408CE0AF72--><AD_MESSAGE>
 <!--DF0B0C41CE7D490AAE15F6408CE0AF72-->  <AD_MESSAGE_ID><![CDATA[DF0B0C41CE7D490AAE15F6408CE0AF72]]></AD_MESSAGE_ID>
 <!--DF0B0C41CE7D490AAE15F6408CE0AF72-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
diff -r 12d5d943eb22 src/org/openbravo/retail/posterminal/OrderLoader.java
--- a/src/org/openbravo/retail/posterminal/OrderLoader.java	Fri Dec 07 10:05:08 2012 +0100
+++ b/src/org/openbravo/retail/posterminal/OrderLoader.java	Fri Dec 07 12:49:27 2012 +0100
@@ -51,6 +51,7 @@
 import org.openbravo.dal.service.OBQuery;
 import org.openbravo.erpCommon.ad_forms.AcctServer;
 import org.openbravo.erpCommon.utility.OBError;
+import org.openbravo.erpCommon.utility.OBMessageUtils;
 import org.openbravo.erpCommon.utility.Utility;
 import org.openbravo.model.ad.access.InvoiceLineTax;
 import org.openbravo.model.ad.access.OrderLineTax;
@@ -462,6 +463,11 @@
         jsonorder.getLong("timezoneOffset"));
 
     invoice.setDocumentNo(null);
+    String description = jsonorder.has("description") ? jsonorder.getString("description") + "\n"
+        : "";
+    description += OBMessageUtils.getI18NMessage("OBPOS_InvoiceRelatedToOrder", null)
+        + jsonorder.getString("documentNo");
+    invoice.setDescription(description);
     invoice
         .setDocumentType(getInvoiceDocumentType((String) DalUtil.getId(order.getDocumentType())));
     invoice.setTransactionDocument(getInvoiceDocumentType((String) DalUtil.getId(order

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0054772) marvintm (manager) 2012-12-07 12:50	A fix has been uploaded as a patch. It will be committed to the module once the RMP17 release cycle finishes.

(0054962) hgbot (developer) 2012-12-17 11:20	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3c0328625ec0567ad55b86ae22fb553f0949bfef Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Mon Dec 17 11:19:57 2012 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3c0328625ec0567ad55b86ae22fb553f0949bfef [^] Fixed issue 22476. Added order docno to the invoice description --- M src-db/database/sourcedata/AD_MESSAGE.xml M src/org/openbravo/retail/posterminal/OrderLoader.java ---

(0055233) migueldejuana (developer) 2012-12-27 09:33	Tested and reviewed in @c3749ba555d6

Issue History
Date Modified	Username	Field	Change
2012-12-07 10:28	jecharri	New Issue
2012-12-07 10:28	jecharri	Assigned To	=> adrianromero
2012-12-07 10:34	jecharri	Assigned To	adrianromero => marvintm
2012-12-07 12:49	marvintm	File Added: issue22476.diff
2012-12-07 12:50	marvintm	Note Added: 0054772
2012-12-17 11:20	hgbot	Checkin
2012-12-17 11:20	hgbot	Note Added: 0054962
2012-12-17 11:20	hgbot	Status	new => resolved
2012-12-17 11:20	hgbot	Resolution	open => fixed
2012-12-17 11:20	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3c0328625ec0567ad55b86ae22fb553f0949bfef [^]
2012-12-27 09:33	migueldejuana	Note Added: 0055233
2012-12-27 09:33	migueldejuana	Status	resolved => closed