0022444: Cash overpayments in WebPOS when entering the amount using the numeric key pad are not properly registered

Description

Instead of setting the overpayment amount as "Change" and setting the payment to the exact Ticket amount, the system is registering an overpayment (although in the UI it displays "Change").

It works fine when the amount is entered using Notes/Coins buttons.

Steps To Reproduce

* Create a ticket with Amount 9.90
* Tap on the amount to pay it
* Select Cash
* Tap on $ an type 10 using the numeric pad (or type 10 using the keyboard)
* The system displays: Change 0.10, Cash 9.90
* Confirm
* Get the ticket number from the yellow message once it syncs
* Go to the back end and check that the payment amount is 10 instead of 9.90 (either in the payment tab in Order or in the financial account)

Proposed Solution

If the amount is entered tapping on the note 10, then the information is properly registered.

See attached diff for the fix

Tags

No tags attached.

Attached Files

cashTrans.diff [^] (907 bytes) 2012-12-02 10:35 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/OrderLoader.java b/src/org/openbravo/retail/posterminal/OrderLoader.java
--- a/src/org/openbravo/retail/posterminal/OrderLoader.java
+++ b/src/org/openbravo/retail/posterminal/OrderLoader.java
@@ -894,12 +894,10 @@
     try {
       BigDecimal amount = BigDecimal.valueOf(payment.getDouble("paid"));
       BigDecimal origAmount = amount;
-      if (payment.has("rate")) {
-        origAmount = BigDecimal.valueOf(payment.getDouble("amount"));
-      }
       BigDecimal mulrate = new BigDecimal(1);
-      if (payment.has("mulrate")) {
+      if (payment.has("mulrate") && payment.getDouble("mulrate") != 1) {
         mulrate = BigDecimal.valueOf(payment.getDouble("mulrate"));
+        origAmount = amount.multiply(BigDecimal.valueOf(payment.getDouble("mulrate")));
       }
 
       // writeoffAmt.divide(BigDecimal.valueOf(payment.getDouble("rate")));

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0054693) hgbot (developer) 2012-12-04 10:29	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ef832e0f2b8c8cfdbb07db86a299347cc1d6a966 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Tue Dec 04 10:29:04 2012 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef832e0f2b8c8cfdbb07db86a299347cc1d6a966 [^] Fixed issue 22444: Payment in when paying with cash and original keypad works well --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

(0054696) adrianromero (manager) 2012-12-04 11:20	Closed for RMP17

Issue History
Date Modified	Username	Field	Change
2012-12-02 10:35	iciordia	New Issue
2012-12-02 10:35	iciordia	Assigned To	=> migueldejuana
2012-12-02 10:35	iciordia	File Added: cashTrans.diff
2012-12-04 10:29	hgbot	Checkin
2012-12-04 10:29	hgbot	Note Added: 0054693
2012-12-04 10:29	hgbot	Status	new => resolved
2012-12-04 10:29	hgbot	Resolution	open => fixed
2012-12-04 10:29	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef832e0f2b8c8cfdbb07db86a299347cc1d6a966 [^]
2012-12-04 11:20	adrianromero	Note Added: 0054696
2012-12-04 11:20	adrianromero	Status	resolved => closed