Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0022415
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2012-11-28 11:012013-01-29 10:04
ReportermaiteView Statuspublic 
Assigned ToAugustoMauch 
PriorityurgentResolutionfixedFixed in Version3.0MP20
StatusclosedFix in branchpiFixed in SCM revisionc6bcd2cde6a9
ProjectionnoneETAnoneTarget Version3.0MP20
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022415: Error when splitting Payment Plan in more than 2 lines

DescriptionError when splitting Payment Plan in more than 2 lines
Steps To Reproduce1. Logged as System Administrator, access "Windows, Tabs and Fields" and search "Sales Invoice" window. Access "Payment Plan" tab and search "Modify Payment Plan" field and ENABLE it
2. Logout and login
3. Access Sales Invoice window and create new invoice with any line. Process and go to "Payment Plan" tab and press "Modify Payment Plan" button
4. Edit proposed line to set less outstanding amount.
5. Press "Add new", set any date and set less that proposed outstanding amount. 6. Press "Add new" and set different date with rest of outstanding amount
7. SUBMIT and you will obtain Error "One or more fields contain illegal values, check the errors for each field."

Note: if you split payment plan in ONLY 2 lines it will work
TagsNo tags attached.
Attached Filesdiff file icon issue22415.diff [^] (2,647 bytes) 2013-01-11 14:08 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00224043.0MP20 closedjecharri Error in "Modify Payment Plan" process 
related to defect 00225223.0MP20 closedAugustoMauch In Pick&Execute windows a removed selection appears when sorting the columns 

-  Notes
(0055409)
jonalegriaesarte (reporter)
2013-01-09 10:26

Scheduled to MP20
(0055440)
ioritzCia (developer)
2013-01-09 19:17

- Check the validateRows function in 481 line of the ob-pick-and-execute-grid.js file. Around 32490 line int the uuid.js file.
- Check that there is a for structure there that goes through the grid rows and validates the cells.
  - If the validate function does not return errors it clears the errors of the field. This is unexplainably not working for some rows while it is for others.

Steps to reproduce:
- Create a sales invoice for Alimentos y Supermercados and add a line with Agua sin Gas 1L product. This will give a 1.81 payment plan outstanding value.
- Go to payment plan and click on modify payment plan button. Try to split it into 1, 0.8 and 0.01 values. In the funtion code told above this.clearFieldError function will work for the first row (the one with value 1) and it will not for the second one (the one with value 0.8).
(0055488)
AugustoMauch (manager)
2013-01-11 13:57

A patch that solves this issue has been attached. It will be pushed to pi once it is open for MP20 changesets.
(0055616)
hgbot (developer)
2013-01-18 16:44

Repository: erp/devel/pi
Changeset: c6bcd2cde6a9dfcdf216b4e91721b4f7c6c3368e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Jan 18 16:32:42 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c6bcd2cde6a9dfcdf216b4e91721b4f7c6c3368e [^]

Fixes issue 22415: Enables splitting the Payment Plan in more than 2 lines

There were two bugs that prevented Payment Plans from beig splitted in more than 2 lines:
- A bug in ob-pick-and-execute-view.js was using the actual record in the call to grid.getEditedRecord instead of using the record index.
- Calling clearFieldError with the row index did not work propertly. In that argument instead of passing the row index, the row ID can be passed, in that case
all rows that do not have errors are marked as error free.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0055722)
hudsonbot (developer)
2013-01-22 15:33

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^]

Maturity status: Test
(0055935)
alostale (manager)
2013-01-29 10:04

Code reviewed + verified on pi@f8bfaf4760bf

- Issue History
Date Modified Username Field Change
2012-11-28 11:01 maite New Issue
2012-11-28 11:01 maite Assigned To => dmiguelez
2012-11-28 11:01 maite Modules => Advanced Payables and Receivables Mngmt
2012-11-28 11:02 maite Relationship added related to 0022404
2012-11-28 11:23 maite Target Version => 3.0MP18
2012-11-28 11:23 maite Issue Monitored: networkb
2012-11-28 14:31 heccam Issue Monitored: heccam
2012-12-04 12:48 jonalegriaesarte Target Version 3.0MP18 => 3.0MP19
2012-12-10 09:35 dmiguelez Assigned To dmiguelez => jonalegriaesarte
2013-01-09 10:26 jonalegriaesarte Triggers an Emergency Pack => No
2013-01-09 10:26 jonalegriaesarte Note Added: 0055409
2013-01-09 10:26 jonalegriaesarte Severity major => minor
2013-01-09 10:26 jonalegriaesarte Target Version 3.0MP19 => 3.0MP20
2013-01-09 19:17 ioritzCia Note Added: 0055440
2013-01-09 19:17 ioritzCia Assigned To jonalegriaesarte => AugustoMauch
2013-01-10 12:52 alostale Issue Monitored: alostale
2013-01-11 13:56 AugustoMauch Review Assigned To => alostale
2013-01-11 13:57 AugustoMauch File Added: issue22415.export
2013-01-11 13:57 AugustoMauch Note Added: 0055488
2013-01-11 14:07 AugustoMauch File Deleted: issue22415.export
2013-01-11 14:08 AugustoMauch File Added: issue22415.diff
2013-01-14 10:17 AugustoMauch Status new => scheduled
2013-01-14 10:17 AugustoMauch fix_in_branch => pi
2013-01-18 16:44 hgbot Checkin
2013-01-18 16:44 hgbot Note Added: 0055616
2013-01-18 16:44 hgbot Status scheduled => resolved
2013-01-18 16:44 hgbot Resolution open => fixed
2013-01-18 16:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c6bcd2cde6a9dfcdf216b4e91721b4f7c6c3368e [^]
2013-01-22 15:33 hudsonbot Checkin
2013-01-22 15:33 hudsonbot Note Added: 0055722
2013-01-29 10:04 alostale Note Added: 0055935
2013-01-29 10:04 alostale Status resolved => closed
2013-01-29 10:04 alostale Fixed in Version => 3.0MP20
2013-01-29 12:03 AugustoMauch Relationship added related to 0022522


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker