Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0022299

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 08. Project and service management

major

always

2012-11-14 13:31

2012-11-21 06:06

Reporter

ngarcia

View Status

public

Assigned To

dmiguelez

Priority

immediate

Resolution

fixed

Fixed in Version

pi

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

main

SCM revision

Merge Request Status

Review Assigned To

mirurita

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Packaging and release

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0022299: Create AP Expense Invoices process fails if it needs to create a new invoice

Description

Create AP Expense Invoices process fails if it needs to create a new invoice.

Steps To Reproduce

Create an Expense Sheet:
   Define an employee BP (for example, Javier Martin) as a Vendor and configure the following parameters:
      Purchase Pricelist: for example Otros servicios
      PO Payment Method
      PO Payment Terms
      PO Financial Account
   Create a new product:
      Product Type: Expense type
   Add a price for the same price list defined before
   Create a new Expense sheet for that employee, add a line with the created product and process it
   Run the Create AP Expense Invoices process for that employee
   A null pointer exception appears

Tags

No tags attached.

ExpenseAPInvoice.diff [^] (933 bytes) 2012-11-14 13:32 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java b/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java
--- a/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java
+++ b/src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java
@@ -44,6 +44,7 @@
 import org.openbravo.erpCommon.utility.SequenceIdData;
 import org.openbravo.erpCommon.utility.ToolBar;
 import org.openbravo.erpCommon.utility.Utility;
+import org.openbravo.service.db.DalConnectionProvider;
 import org.openbravo.xmlEngine.XmlDocument;
 
 public class ExpenseAPInvoice extends HttpSecureAppServlet {
@@ -119,7 +120,7 @@
 
     Connection conn = null;
     try {
-      conn = this.getTransactionConnection();
+      conn = new DalConnectionProvider(false).getConnection();
 
       ExpenseAPInvoiceData[] data = ExpenseAPInvoiceData.select(this,
           Utility.getContext(this, vars, "#User_Client", "ExpenseAPInvoice"),

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

Deferred revenue / expense feature is incompatible with financial invoice lines feature

Notes
(0054237) hgbot (developer) 2012-11-14 16:24	Repository: erp/devel/pi Changeset: 425ad00656710c16b1a4c38a853e990d324f1019 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Wed Nov 14 16:23:41 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/425ad00656710c16b1a4c38a853e990d324f1019 [^] Fixes Issue 0022299. Changed the definition of the conn variable so it uses the same connection for all the transactions made. --- M src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java ---

(0054238) mirurita (viewer) 2012-11-14 16:31	code review + testing OK

(0054385) hudsonbot (viewer) 2012-11-21 06:06	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c3c5e61b0164 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2012-11-14 13:31	ngarcia	New Issue
2012-11-14 13:31	ngarcia	Assigned To	=> dmiguelez
2012-11-14 13:31	ngarcia	Modules	=> Core
2012-11-14 13:31	ngarcia	OBNetwork customer	=> No
2012-11-14 13:32	ngarcia	File Added: ExpenseAPInvoice.diff
2012-11-14 13:35	ngarcia	Regression level	=> Packaging and release
2012-11-14 13:40	ngarcia	Relationship added	related to 0022143
2012-11-14 16:24	hgbot	Checkin
2012-11-14 16:24	hgbot	Note Added: 0054237
2012-11-14 16:24	hgbot	Status	new => resolved
2012-11-14 16:24	hgbot	Resolution	open => fixed
2012-11-14 16:24	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/425ad00656710c16b1a4c38a853e990d324f1019 [^]
2012-11-14 16:31	mirurita	Review Assigned To	=> mirurita
2012-11-14 16:31	mirurita	Note Added: 0054238
2012-11-14 16:31	mirurita	Status	resolved => closed
2012-11-14 16:31	mirurita	Fixed in Version	=> pi
2012-11-21 06:06	hudsonbot	Checkin
2012-11-21 06:06	hudsonbot	Note Added: 0054385

Copyright © 2000 - 2009 MantisBT Group