0022215: Impossible to create a sales order in the backend if you create an invoice at the same time

Description

Impossible to create a sales order in the backend if you create an invoice at the same time.

Steps To Reproduce

-Go to the webPOS and create a receipt (without promotions)
-Mark the receipt as "invoice this receipt"
-Pay the receipt

You will see that the order and invoice has not been synchronized. The error is:

org.codehaus.jettison.json.JSONException: JSONObject["promotions"] is not a JSONArray.
    at org.codehaus.jettison.json.JSONObject.getJSONArray(JSONObject.java:440)
    at org.openbravo.retail.posterminal.OrderLoader.createInvoiceLines(OrderLoader.java:361)
    at org.openbravo.retail.posterminal.OrderLoader.saveOrder(OrderLoader.java:215)
    at org.openbravo.retail.posterminal.OrderLoader.saveOrder(OrderLoader.java:121)
    at org.openbravo.retail.posterminal.OrderLoader.exec(OrderLoader.java:108)
    at org.openbravo.retail.posterminal.JSONProcessSimple.exec(JSONProcessSimple.java:25)
    at org.openbravo.retail.posterminal.TerminalServlet.execClassName(TerminalServlet.java:154)
    at org.openbravo.retail.posterminal.TerminalServlet.doGetOrPost(TerminalServlet.java:76)
    at org.openbravo.retail.posterminal.TerminalServlet.doPost(TerminalServlet.java:47)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:225)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:435)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.retail.posterminal.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:52)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)
    at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:602)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
    at java.lang.Thread.run(Thread.java:679)

If we go to the JSON object you will see:
"promotions":null,"discountedLinePrice":null,"promotionCandidates":null

Notes
(0054094) hgbot (developer) 2012-11-08 11:46	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3611d7553424db4d40e7b6c9bf9fb9f481f48dff Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Nov 08 11:45:58 2012 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3611d7553424db4d40e7b6c9bf9fb9f481f48dff [^] Fixed issue 22215. Order+Invoice will be generated correctly if there are no promotions. --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

(0054581) adrianromero (manager) 2012-11-27 18:44	Closed for RMP17

Issue History
Date Modified	Username	Field	Change
2012-11-06 13:02	jecharri	New Issue
2012-11-06 13:02	jecharri	Assigned To	=> adrianromero
2012-11-08 11:46	hgbot	Checkin
2012-11-08 11:46	hgbot	Note Added: 0054094
2012-11-08 11:46	hgbot	Status	new => resolved
2012-11-08 11:46	hgbot	Resolution	open => fixed
2012-11-08 11:46	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3611d7553424db4d40e7b6c9bf9fb9f481f48dff [^]
2012-11-27 10:19	adrianromero	Target Version	=> RMP17
2012-11-27 18:44	adrianromero	Note Added: 0054581
2012-11-27 18:44	adrianromero	Status	resolved => closed

Relationships [ Relation Graph ] [ Dependency Graph ]