Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0022030 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2012-10-22 14:47 | 2012-10-31 13:30 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP18 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 8dd5c8c26c73 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP17 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0022030: Adding and then removing summary field gives datasource javascript error | |||||||
| Description | See the attached image and steps to reproduce. | |||||||
| Steps To Reproduce | go to sales order screen remove all filters click the dropdown on the Document No column pick the Add Summary Field option in the dropdown menu click the Document No in the Source Field column (Summary input should become sth. like #{D}, Title = New Field ) click Save click the dropdown on the New Field column pick the Remove Summary Field option | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Selection_003.png [^] (160,315 bytes) 2012-10-22 14:47
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0053689) mtaal (manager) 2012-10-25 11:52 |
Issue was caused by the fact that the datasource of the viewgrid was used by the formula/summary editor also. When closing the formula/summary editor it gets destroyed. In ob-smartclient.js we have code that destroys the datasource of a canvas it has one. This happened here also, only this same datasource was being re-used in the summary row. So the data source may only be removed when the viewgrid itself gets destroyed. For this the potentiallyShared flag is used (this flag was already there). |
|
(0053690) hgbot (developer) 2012-10-25 11:54 |
Repository: erp/devel/pi Changeset: 8dd5c8c26c733993d7bdc8405dd2e0afa4ebdd31 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Thu Oct 25 11:53:06 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/8dd5c8c26c733993d7bdc8405dd2e0afa4ebdd31 [^] Fixes issue 22030: Adding and then removing summary field gives datasource javascript error Datasource of the grid was shared/re-used in the formula editor when this editor is closed the ds was destroyed. The code changes prevent this. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
|
(0053782) alostale (manager) 2012-10-30 09:11 |
code reviewed and tested on pi@b2e90dcc4dc7 |
|
(0053924) hudsonbot (developer) 2012-10-31 13:30 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e773cbcb723 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-10-22 14:47 | mtaal | New Issue | |
| 2012-10-22 14:47 | mtaal | Assigned To | => mtaal |
| 2012-10-22 14:47 | mtaal | File Added: Selection_003.png | |
| 2012-10-22 14:47 | mtaal | Modules | => Core |
| 2012-10-25 11:51 | mtaal | Review Assigned To | => AugustoMauch |
| 2012-10-25 11:52 | mtaal | Note Added: 0053689 | |
| 2012-10-25 11:54 | hgbot | Checkin | |
| 2012-10-25 11:54 | hgbot | Note Added: 0053690 | |
| 2012-10-25 11:54 | hgbot | Status | new => resolved |
| 2012-10-25 11:54 | hgbot | Resolution | open => fixed |
| 2012-10-25 11:54 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/8dd5c8c26c733993d7bdc8405dd2e0afa4ebdd31 [^] |
| 2012-10-30 09:11 | alostale | Review Assigned To | AugustoMauch => alostale |
| 2012-10-30 09:11 | alostale | Note Added: 0053782 | |
| 2012-10-30 09:11 | alostale | Status | resolved => closed |
| 2012-10-30 09:11 | alostale | Fixed in Version | => 3.0MP18 |
| 2012-10-31 13:30 | hudsonbot | Checkin | |
| 2012-10-31 13:30 | hudsonbot | Note Added: 0053924 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |