Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0021957
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 05. Production managementmajoralways2012-10-16 18:232012-10-22 13:27
ReporterVictorVillarView Statuspublic 
Assigned Todmiguelez 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisiona6c8cf620986
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket16657
Regression levelProduction - QA Approved
Regression date2012-08-31
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/8af60f70a49cc3abf00bdb3245742298b3abda84 [^]
Triggers an Emergency Packyes
Summary

0021957: The costing migration process does not work

DescriptionThe costing migration process does not work. The process finishes successfully but it does not create the closing physical inventory and the opening physical inventory, after that no cost could be calculated.

The problem is the null date parameter passed to the createCostingRuleInits method

crp.createCostingRuleInits(rule.getId(), childOrgs, null);

the getStockLines query does not get any register
Steps To ReproduceIn MP 15 and followings..

As system admin role ,

Go to Costing migration Process and launch it.

realise that the process finishes successfully.

As group admin role,
   Go to Physical inventory window and realise that no closed physical inventory and opening physical inventory were created.
Proposed Solution1.- add in CostingRuleProcess.java Line 347

if (date != null) {
      select.append(" and trx." + MaterialTransaction.PROPERTY_TRANSACTIONPROCESSDATE
          + " < :date");
    }

check that PROPERTY_TRANSACTIONPROCESSDATE is correct.

2.- Add in Line 368:
  if (date != null) {
      stockLinesQry.setDate("date", date);
    }

The fix proposed before is not complete, it is necessary to make a decision what date pass to the method because in Costingruleprocess.java -- method CreateCostingRuleInitLine fails with date null because violates the not-null constratint inserting in the movementdate
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0021406 closedgorkaion Costing Background Process blocked by Transactions without cost calculated. 

-  Notes
(0053421)
hgbot (developer)
2012-10-17 13:59

 Repository: erp/devel/pi
Changeset: a6c8cf620986bba854fb6c5570cc361eb8fbfbdc
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Oct 17 13:58:55 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a6c8cf620986bba854fb6c5570cc361eb8fbfbdc [^]

Fixes issue 21957: Fixes issue when date is null.

---
M src/org/openbravo/costing/CostingMigrationProcess.java
M src/org/openbravo/costing/CostingRuleProcess.java
---
(0053424)
VictorVillar (viewer)
2012-10-17 15:31

 Verified by Victor Villar + Code Review by Gorka Ion
(0053432)
VictorVillar (viewer)
2012-10-17 17:44

 fill regression fields
(0053433)
VictorVillar (viewer)
2012-10-17 17:47

 Closed again after filling the Regression fields
(0053434)
VictorVillar (viewer)
2012-10-17 17:47

 Closed again after filling the Regression fields
(0053436)
VictorVillar (viewer)
2012-10-17 17:48

 Closed again after filling the Regression fields
(0053512)
hudsonbot (viewer)
2012-10-22 13:27

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/483f2e6dc1af [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-10-16 18:23 VictorVillar New Issue
2012-10-16 18:23 VictorVillar Assigned To => dmiguelez
2012-10-16 18:23 VictorVillar Modules => Core
2012-10-16 18:23 VictorVillar OBNetwork customer => Yes
2012-10-16 18:23 VictorVillar Support ticket => 16657
2012-10-16 18:24 VictorVillar Regression level => Production - QA Approved
2012-10-16 18:24 VictorVillar Issue Monitored: networkb
2012-10-17 13:59 hgbot Checkin
2012-10-17 13:59 hgbot Note Added: 0053421
2012-10-17 13:59 hgbot Status new => resolved
2012-10-17 13:59 hgbot Resolution open => fixed
2012-10-17 13:59 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a6c8cf620986bba854fb6c5570cc361eb8fbfbdc [^]
2012-10-17 15:31 VictorVillar Review Assigned To => VictorVillar
2012-10-17 15:31 VictorVillar Note Added: 0053424
2012-10-17 15:31 VictorVillar Status resolved => closed
2012-10-17 17:44 VictorVillar Note Added: 0053432
2012-10-17 17:44 VictorVillar Status closed => new
2012-10-17 17:44 VictorVillar Resolution fixed => open
2012-10-17 17:46 VictorVillar Regression date => 2012-08-31
2012-10-17 17:46 VictorVillar Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/8af60f70a49cc3abf00bdb3245742298b3abda84 [^]
2012-10-17 17:47 VictorVillar Status new => scheduled
2012-10-17 17:47 VictorVillar Note Added: 0053433
2012-10-17 17:47 VictorVillar fix_in_branch => pi
2012-10-17 17:47 VictorVillar Note Added: 0053434
2012-10-17 17:47 VictorVillar Status scheduled => resolved
2012-10-17 17:47 VictorVillar Resolution open => fixed
2012-10-17 17:48 VictorVillar Note Added: 0053436
2012-10-17 17:48 VictorVillar Status resolved => closed
2012-10-17 18:20 dmiguelez Status closed => new
2012-10-17 18:20 dmiguelez Resolution fixed => open
2012-10-17 18:20 dmiguelez Relationship added related to 0021406
2012-10-17 18:20 dmiguelez Status new => scheduled
2012-10-17 18:20 dmiguelez Status scheduled => resolved
2012-10-17 18:20 dmiguelez Resolution open => fixed
2012-10-17 18:20 dmiguelez Status resolved => closed
2012-10-22 13:27 hudsonbot Checkin
2012-10-22 13:27 hudsonbot Note Added: 0053512

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker