Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0021849

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

always

2012-10-03 16:37

2012-10-30 09:17

Reporter

ioritzCia

View Status

public

Assigned To

AugustoMauch

Priority

normal

Resolution

fixed

Fixed in Version

3.0MP17

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

alostale

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0021849: Export.sampledata reorganizes properties that have same column position.

Description

Export.sampledata reorganizes properties of the entities that have same column position value.

Steps To Reproduce

- Execute ant export.sampledata and see that some properties are reorganized.

For example:

diff --git a/referencedata/sampledata/F_B_International_Group.xml b/referencedata/sampledata/F_B_International_Group.xml
--- a/referencedata/sampledata/F_B_International_Group.xml
+++ b/referencedata/sampledata/F_B_International_Group.xml
@@ -28193,9 +28193,9 @@
     <description xsi:nil="true"/>
     <aprmModifPaymentINPlan>false</aprmModifPaymentINPlan>
     <aprmModifPaymentOUTPlan>false</aprmModifPaymentOUTPlan>
- <daysOverdue>0</daysOverdue>
     <lastPaymentDate>2011-12-05T00:00:00.0Z</lastPaymentDate>
     <numberOfPayments>1</numberOfPayments>
+ <daysOverdue>0</daysOverdue>
   </FIN_Payment_Schedule>
   <FIN_Payment_Schedule id="00DFF28676AE4CE49B08790361D86AB4">
     <id>00DFF28676AE4CE49B08790361D86AB4</id>
@@ -28216,9 +28216,9 @@
     <description xsi:nil="true"/>
     <aprmModifPaymentINPlan>false</aprmModifPaymentINPlan>
     <aprmModifPaymentOUTPlan>false</aprmModifPaymentOUTPlan>
- <daysOverdue>22</daysOverdue>
     <lastPaymentDate>2012-08-21T00:00:00.0Z</lastPaymentDate>
     <numberOfPayments>1</numberOfPayments>
+ <daysOverdue>22</daysOverdue>
   </FIN_Payment_Schedule>
   <FIN_Payment_Schedule id="01EB58DB89354C88956D2FB821353D12">
     <id>01EB58DB89354C88956D2FB821353D12</id>
@@ -28239,9 +28239,9 @@
     <description xsi:nil="true"/>
     <aprmModifPaymentINPlan>false</aprmModifPaymentINPlan>
     <aprmModifPaymentOUTPlan>false</aprmModifPaymentOUTPlan>
- <daysOverdue>0</daysOverdue>
     <lastPaymentDate xsi:nil="true"/>
     <numberOfPayments>0</numberOfPayments>
+ <daysOverdue>0</daysOverdue>
   </FIN_Payment_Schedule>
   <FIN_Payment_Schedule id="02DADE02A2E74E9EBE197711615E3093">
     <id>02DADE02A2E74E9EBE197711615E3093</id>

And so on.

Tags

No tags attached.

issue21849.diff [^] (461 bytes) 2012-10-04 17:18 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/base/model/ModelProvider.java b/src/org/openbravo/base/model/ModelProvider.java
--- a/src/org/openbravo/base/model/ModelProvider.java
+++ b/src/org/openbravo/base/model/ModelProvider.java
@@ -425,6 +425,7 @@
   private List<Column> readColumns(Session session) {
     final Criteria c = session.createCriteria(Column.class);
     c.addOrder(Order.asc("position"));
+    c.addOrder(Order.asc("name"));
     return c.list();
   }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0053113) hgbot (developer) 2012-10-08 14:08	Repository: erp/devel/pi Changeset: e7effc11e1bea22ce60f048c3c7fbf6442010189 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Oct 08 14:03:36 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e7effc11e1bea22ce60f048c3c7fbf6442010189 [^] Fixes issue 21849: Column with same position are ordered by name When all the database columns are listed in the readColumns method of ModelProvider, they were ordered by its position. If several columns had the same position, its order was not deterministic. Now the name of the column has been added to the order clause. --- M src/org/openbravo/base/model/ModelProvider.java ---

(0053260) hudsonbot (developer) 2012-10-11 07:50	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63dfc135f2a1 [^] Maturity status: Test

(0053783) alostale (manager) 2012-10-30 09:17	Code reviewed and tested on pi@b2e90dcc4dc7

Issue History
Date Modified	Username	Field	Change
2012-10-03 16:37	ioritzCia	New Issue
2012-10-03 16:37	ioritzCia	Assigned To	=> AugustoMauch
2012-10-03 16:37	ioritzCia	Modules	=> Core
2012-10-04 17:18	AugustoMauch	File Added: issue21849.diff
2012-10-04 17:19	AugustoMauch	Status	new => scheduled
2012-10-04 17:19	AugustoMauch	fix_in_branch	=> pi
2012-10-08 14:03	AugustoMauch	Issue Monitored: dbaz
2012-10-08 14:03	AugustoMauch	Issue End Monitor: dbaz
2012-10-08 14:04	AugustoMauch	Issue Monitored: marvintm
2012-10-08 14:04	AugustoMauch	Review Assigned To	=> marvintm
2012-10-08 14:04	AugustoMauch	fix_in_branch	pi =>
2012-10-08 14:08	hgbot	Checkin
2012-10-08 14:08	hgbot	Note Added: 0053113
2012-10-08 14:08	hgbot	Status	scheduled => resolved
2012-10-08 14:08	hgbot	Resolution	open => fixed
2012-10-08 14:08	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/e7effc11e1bea22ce60f048c3c7fbf6442010189 [^]
2012-10-11 07:50	hudsonbot	Checkin
2012-10-11 07:50	hudsonbot	Note Added: 0053260
2012-10-30 09:17	alostale	Review Assigned To	marvintm => alostale
2012-10-30 09:17	alostale	Note Added: 0053783
2012-10-30 09:17	alostale	Status	resolved => closed
2012-10-30 09:17	alostale	Fixed in Version	=> 3.0MP17

Copyright © 2000 - 2009 MantisBT Group