Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0021831
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2012-10-02 13:182017-05-12 12:31
ReporterxabiermerinoView Statuspublic 
Assigned Tojecharri 
PriorityurgentResolutionno change requiredFixed in Version
StatusclosedFix in branchFixed in SCM revision26799413cdbc
ProjectionnoneETAnoneTarget Version3.0MP19
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket17216
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021831: Trial Balance shows different Final Balance depending the check 'Opening Entry Amount to Initial Balance'

DescriptionTrial Balance shows different Final Balance depending the check 'Opening Entry Amount to Initial Balance'.
Steps To ReproduceIn the database execute this query:
update fact_acct set factaccttype = 'N' where acctvalue like '%57200%' and factaccttype = 'O'

As admin execute the report with the field checked, the result is correct.
Execute the report with the field unchecked, the result is wrong
Proposed SolutionReportTrialBalance.java

Method calculateTree:

Change:

        // Set calculated Initial Balances
        for (int k = 0; k < dataIB.length; k++) {
          if (dataIB[k].accountId.equals(data[i].id)) {
            if (strNotInitialBalance.equals("Y")) {
              data[i].saldoInicial = (new BigDecimal(dataIB[k].saldoInicial).add(parcialInicial))
                  .toPlainString();
            } else {
              data[i].amtacctdr = (new BigDecimal(dataIB[k].amtacctdr).add(parcialDR))
                  .toPlainString();
              data[i].amtacctcr = (new BigDecimal(dataIB[k].amtacctcr).add(parcialCR))
                  .toPlainString();
            }
            data[i].saldoFinal = (new BigDecimal(dataIB[k].saldoInicial).add(parcialDR)
                .subtract(parcialCR)).toPlainString();
          }
        }

for:

        // Set calculated Initial Balances
        for (int k = 0; k < dataIB.length; k++) {
          if (dataIB[k].accountId.equals(data[i].id)) {
            if (strNotInitialBalance.equals("Y")) {
              data[i].saldoInicial = (new BigDecimal(dataIB[k].saldoInicial).add(parcialInicial))
                  .toPlainString();
            } else {
              data[i].amtacctdr = (new BigDecimal(dataIB[k].amtacctdr).add(parcialDR).add(new BigDecimal(data[i].amtacctdr)))
                  .toPlainString();
              data[i].amtacctcr = (new BigDecimal(dataIB[k].amtacctcr).add(parcialCR).add(new BigDecimal(data[i].amtacctcr)))
                  .toPlainString();
            }
            data[i].saldoFinal = (new BigDecimal(dataIB[k].saldoInicial).add(parcialDR)
                .subtract(parcialCR)).toPlainString();
          }
        }
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 00284523.0PR15Q2 closedreinaldoguerra Wrong Trial Balance when standard accounting information exists in Opening date 
related to defect 0035896 closedAtulOpenbravo Wrong Trial Balance at "Account" level and without checking "Opening Entry Amount to Initial Balance" 

-  Notes
(0053853)
hgbot (developer)
2012-10-30 17:48

 Repository: erp/devel/pi
Changeset: 26799413cdbcee5d0ed80f4a4c08fd481d62d9c5
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Oct 30 17:47:23 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/26799413cdbcee5d0ed80f4a4c08fd481d62d9c5 [^]

Fixes issue 21831: Trial Balance shows different Final Balance depending
the check 'Opening Entry Amount to Initial Balance'

---
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
---
(0053854)
jecharri (viewer)
2012-10-30 17:51

 test plan. With steps to reproduce is enough.

You can try to launch the report in a short time periods or large periods:
-only some days or 3 years
(0053944)
hudsonbot (viewer)
2012-10-31 13:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e773cbcb723 [^]

Maturity status: Test
(0053959)
hgbot (developer)
2012-10-31 19:51

 Repository: erp/devel/pi
Changeset: f88e6d65740382a4922bf2f7af50b80d1021bc5c
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Oct 31 19:48:02 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f88e6d65740382a4922bf2f7af50b80d1021bc5c [^]

Backout issue 21831: Trial Balance shows different Final Balance depending
the check 'Opening Entry Amount to Initial Balance'

---
M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalance.java
---
(0054026)
hudsonbot (viewer)
2012-11-06 10:47

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/905762a34c04 [^]

Maturity status: Test
(0054299)
jonalegriaesarte (viewer)
2012-11-16 17:42

 It must be tested in depth
(0055079)
jonalegriaesarte (viewer)
2012-12-19 14:53

 After last refactor, this check has disappeared

- Issue History
Date Modified Username Field Change
2012-10-02 13:18 xabiermerino New Issue
2012-10-02 13:18 xabiermerino Assigned To => dmiguelez
2012-10-02 13:18 xabiermerino Modules => Core
2012-10-02 13:18 xabiermerino OBNetwork customer => Yes
2012-10-02 13:18 xabiermerino Support ticket => 17216
2012-10-02 13:18 xabiermerino Issue Monitored: networkb
2012-10-02 16:22 dmiguelez Assigned To dmiguelez => jonalegriaesarte
2012-10-03 18:31 xabiermerino Description Updated View Revisions
2012-10-03 18:31 xabiermerino Steps to Reproduce Updated View Revisions
2012-10-03 18:31 xabiermerino Proposed Solution updated
2012-10-04 16:10 jonalegriaesarte Target Version => 3.0MP17
2012-10-23 18:41 jonalegriaesarte Assigned To jonalegriaesarte => jecharri
2012-10-30 17:48 hgbot Checkin
2012-10-30 17:48 hgbot Note Added: 0053853
2012-10-30 17:48 hgbot Status new => resolved
2012-10-30 17:48 hgbot Resolution open => fixed
2012-10-30 17:48 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/26799413cdbcee5d0ed80f4a4c08fd481d62d9c5 [^]
2012-10-30 17:51 jecharri Note Added: 0053854
2012-10-31 13:31 hudsonbot Checkin
2012-10-31 13:31 hudsonbot Note Added: 0053944
2012-10-31 16:40 jecharri Status resolved => new
2012-10-31 16:40 jecharri Resolution fixed => open
2012-10-31 16:40 jecharri Resolution time => 1349560800
2012-10-31 16:40 jecharri Target Version 3.0MP17 => 3.0MP18
2012-10-31 19:51 hgbot Checkin
2012-10-31 19:51 hgbot Note Added: 0053959
2012-11-06 10:47 hudsonbot Checkin
2012-11-06 10:47 hudsonbot Note Added: 0054026
2012-11-16 17:42 jonalegriaesarte Note Added: 0054299
2012-11-16 17:42 jonalegriaesarte Severity major => minor
2012-12-04 11:50 jonalegriaesarte Target Version 3.0MP18 => 3.0MP19
2012-12-19 14:53 jonalegriaesarte Note Added: 0055079
2012-12-19 14:53 jonalegriaesarte Status new => closed
2012-12-19 14:53 jonalegriaesarte Resolution open => no change required
2017-05-09 18:09 aferraz Relationship added related to 0035896
2017-05-12 12:31 aferraz Relationship added has duplicate 0028452

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker